Skip to content

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to BE constraints #41123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 3 commits into from
May 3, 2024
Merged

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to BE constraints #41123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a02d5dc
Update Regex and titile limit for rooms
allgandalf Apr 26, 2024
65bf525
update unit test
allgandalf Apr 30, 2024
9862f92
update unit test
allgandalf Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ const CONST = {
},
RESERVED_ROOM_NAMES: ['#admins', '#announce'],
MAX_PREVIEW_AVATARS: 4,
MAX_ROOM_NAME_LENGTH: 79,
MAX_ROOM_NAME_LENGTH: 99,

@allgandalf allgandalf Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eh2077 @dangrous, we use MAX_ROOM_NAME_LENGTH only to create a room, also we need to have it limited to 99 because during room creation, we prefix # as a extra character.

Do let me know if you have any doubt about this, thanks have a great weekend

@eh2077 eh2077 Apr 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to set the limit to 99.

LAST_MESSAGE_TEXT_MAX_LENGTH: 200,
OWNER_EMAIL_FAKE: '__FAKE__',
OWNER_ACCOUNT_ID_FAKE: 0,
Expand Down Expand Up @@ -1799,7 +1799,7 @@ const CONST = {
CARD_NUMBER: /^[0-9]{15,16}$/,
CARD_SECURITY_CODE: /^[0-9]{3,4}$/,
CARD_EXPIRATION_DATE: /^(0[1-9]|1[0-2])([^0-9])?([0-9]{4}|([0-9]{2}))$/,
ROOM_NAME: /^#[\p{Ll}0-9-]{1,80}$/u,
ROOM_NAME: /^#[\p{Ll}0-9-]{1,100}$/u,

// eslint-disable-next-line max-len, no-misleading-character-class
EMOJI: /[\p{Extended_Pictographic}\u200d\u{1f1e6}-\u{1f1ff}\u{1f3fb}-\u{1f3ff}\u{e0020}-\u{e007f}\u20E3\uFE0F]|[#*0-9]\uFE0F?\u20E3/gu,
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/ValidationUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ describe('ValidationUtils', () => {
expect(ValidationUtils.isValidRoomName('#')).toBe(false);
});

test('room name with 81 characters', () => {
expect(ValidationUtils.isValidRoomName('#123456789012345678901234567890123456789012345678901234567890123456789012345678901')).toBe(false);
test('room name with 101 characters', () => {
expect(ValidationUtils.isValidRoomName('#12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901')).toBe(false);
});

test('room name with lowercase letters, numbers, and dashes', () => {
Expand Down