Fix confirmation page isn't closed after completing share expense by bernhardoj · Pull Request #40740 · Expensify/App

bernhardoj · 2024-04-23T02:24:34Z

Details

When we share an expense to a workspace, it will open an invite page. But if we go back, it will navigate back the user to the confirmation page again.

Fixed Issues

$ #40490
PROPOSAL: #40490 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open your self DM chat
Track a new expense. Wait until the concierge message shows up
Choose Share it with my accountant
Select any workspace and Submit
Verify you are navigated to the invite page
Press the back button
Verify you are navigated back to the workspace chat that you choose to share

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-23.at.10.20.39.mov

Android: mWeb Chrome

Screen.Recording.2024-04-23.at.10.16.38.mov

iOS: Native

Screen.Recording.2024-04-23.at.10.21.21.mov

iOS: mWeb Safari

Screen.Recording.2024-04-23.at.10.00.53.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-23.at.09.57.45.mov

MacOS: Desktop

Screen.Recording.2024-04-23.at.09.58.31.mov

melvin-bot · 2024-04-23T02:24:40Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-04-23T02:31:04Z

        }
    }
    if (action === CONST.IOU.ACTION.SHARE) {
+        Navigation.dismissModal();


This will just close the modal without navigating the user to the report chat and will only navigate to the report chat after inviting the user (@jjcoffee as you mentioned here)/go back from the invite page.

Do we want to navigate the user after submitting the expense? Here is how it looks:

Screen.Recording.2024-04-23.at.10.25.59.mov

Personally I think it makes sense to immediately navigate upon submitting the expense, but there may be some reason why this was not implemented and I'm not sure it's really within scope for this PR - it's more of a polish thing.

Asked on Slack!

jjcoffee · 2024-04-23T09:41:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-04-23_12.11.01.mp4

Android: mWeb Chrome

android-chrome-2024-04-23_12.14.56.mp4

iOS: Native

ios-app-2024-04-23_13.52.09.mp4

iOS: mWeb Safari

ios-safari-2024-04-23_14.07.50.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-04-23_11.21.52.mp4

MacOS: Desktop

desktop-app-2024-04-23_11.43.24.mp4

bernhardoj · 2024-04-23T10:50:29Z

Fixed this issue

jjcoffee

LGTM, thanks for the extra fix!

jjcoffee · 2024-04-23T12:16:24Z

@thienlnam All yours! Just a side-note, I've decided that changing the point at which we navigate to the workspace is OOS for this PR (and to keep it moving quickly) as it's more of a polish issue from the original PR rather than a bug per se. I also wasn't able to get confirmation on Slack whether or not it was intentional.

Anyway, here's how it currently works in case you disagree. Note that we don't navigate to the workspace until after the invite screen is interacted with (either back button press to dismiss, or select some member(s) to invite), even though the expense is submitted/moved in the previous step.

desktop-chrome-2024-04-23_11.21.52.mp4

thienlnam · 2024-04-23T18:16:04Z

Yeah that's fine for now, we can do some follow up polish in another issue - thanks for the urgency!

OSBotify · 2024-04-23T18:30:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-24T00:08:44Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:47:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits April 23, 2024 10:17

dismiss modal before navigating to invite page

2d51b22

fix infinite back loop

97b4a11

bernhardoj requested a review from a team as a code owner April 23, 2024 02:24

melvin-bot Bot requested review from jjcoffee and removed request for a team April 23, 2024 02:24

bernhardoj commented Apr 23, 2024

View reviewed changes

Comment thread src/pages/RoomInvitePage.tsx

bernhardoj commented Apr 23, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

just go back when it's a share action

e1e22f0

jjcoffee approved these changes Apr 23, 2024

View reviewed changes

melvin-bot Bot requested a review from thienlnam April 23, 2024 12:11

thienlnam approved these changes Apr 23, 2024

View reviewed changes

thienlnam merged commit dadf0ba into Expensify:main Apr 23, 2024

github-actions Bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

kbecciv mentioned this pull request Apr 24, 2024

[Payment due 2024-05-14][$250] iOS - Track expense - Swiping to right on invite page does not return to workspace chat #40913

Closed

6 tasks

melvin-bot Bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-05-02] CRITICAL: [Actionable Whispers] [$500] Unable to return to invite page after returning to confirmation page #40490

Closed

6 tasks

Uh oh!

Conversation

bernhardoj commented Apr 23, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 23, 2024

Uh oh!

Uh oh!

bernhardoj Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

jjcoffee Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

jjcoffee Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

jjcoffee commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Apr 23, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thienlnam commented Apr 23, 2024

Uh oh!

OSBotify commented Apr 23, 2024

Uh oh!

OSBotify commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jjcoffee commented Apr 23, 2024 •

edited

Loading

jjcoffee commented Apr 23, 2024 •

edited

Loading