Skip to content

fix: Quick action - 'Pay elsewhere' button is small when paying someone via Quick action #40727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gonals merged 2 commits into from
Apr 24, 2024
Merged

fix: Quick action - 'Pay elsewhere' button is small when paying someone via Quick action #40727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352d844
fix: Quick action - 'Pay elsewhere' button is small when paying someo…
Krishna2323 Apr 22, 2024
83acd68
wrap SettlementButton with View.
Krishna2323 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 37 additions & 35 deletions src/pages/iou/steps/MoneyRequestAmountForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,41 +387,43 @@ function MoneyRequestAmountForm(
longPressHandlerStateChanged={updateLongPressHandlerState}
/>
) : null}
{iouType === CONST.IOU.TYPE.PAY && skipConfirmation ? (
<SettlementButton
pressOnEnter
onPress={submitAndNavigateToNextPage}
enablePaymentsRoute={ROUTES.IOU_SEND_ENABLE_PAYMENTS}
addBankAccountRoute={bankAccountRoute}
addDebitCardRoute={ROUTES.IOU_SEND_ADD_DEBIT_CARD}
currency={currency ?? CONST.CURRENCY.USD}
policyID={policyID ?? ''}
style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt3]}
buttonSize={CONST.DROPDOWN_BUTTON_SIZE.LARGE}
kycWallAnchorAlignment={{
horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
}}
paymentMethodDropdownAnchorAlignment={{
horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
}}
shouldShowPersonalBankAccountOption
enterKeyEventListenerPriority={1}
/>
) : (
<Button
success
// Prevent bubbling on edit amount Page to prevent double page submission when two CTA are stacked.
allowBubble={!isEditing}
pressOnEnter
medium={isExtraSmallScreenHeight}
large={!isExtraSmallScreenHeight}
style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt3]}
onPress={() => submitAndNavigateToNextPage()}
text={buttonText}
/>
)}
<View style={styles.w100}>
{iouType === CONST.IOU.TYPE.PAY && skipConfirmation ? (
<SettlementButton
pressOnEnter
onPress={submitAndNavigateToNextPage}
enablePaymentsRoute={ROUTES.IOU_SEND_ENABLE_PAYMENTS}
addBankAccountRoute={bankAccountRoute}
addDebitCardRoute={ROUTES.IOU_SEND_ADD_DEBIT_CARD}
currency={currency ?? CONST.CURRENCY.USD}
policyID={policyID ?? ''}
style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt3]}
buttonSize={CONST.DROPDOWN_BUTTON_SIZE.LARGE}
kycWallAnchorAlignment={{
horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
}}
paymentMethodDropdownAnchorAlignment={{
horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
}}
shouldShowPersonalBankAccountOption
enterKeyEventListenerPriority={1}
/>
) : (
<Button
success
// Prevent bubbling on edit amount Page to prevent double page submission when two CTA are stacked.
allowBubble={!isEditing}
pressOnEnter
medium={isExtraSmallScreenHeight}
large={!isExtraSmallScreenHeight}
style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt3]}
onPress={() => submitAndNavigateToNextPage()}
text={buttonText}
/>
)}
</View>
</View>
</ScrollView>
);
Expand Down