Fix unread issue in combine report by nkdengineer · Pull Request #40676 · Expensify/App

nkdengineer · 2024-04-22T07:57:17Z

Details

Fix unread issue in combine report

Fixed Issues

$ #39407
PROPOSAL: #39407 (comment)

Tests

Go to workspace chat or a DM that has no unsettled requests.
Create a money request
Pin both IOU report and transaction thread report in LHN
Open the combine report and edit any field of the request
Hover or long press on the modified message
Verify that the unread marker appears
Verify that the combine report and transaction thread report are bold in LHN
Scroll up to the top until New message button appears
Click on this button and verify that the chat scroll to the bottom
Verify that in LHN the combine report and transaction thread report aren't bold

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to workspace chat or a DM that has no unsettled requests.
Create a money request
Pin both IOU report and transaction thread report in LHN
Open the combine report and edit any field of the request
Hover or long press on the modified message
Verify that the unread marker appears
Verify that the combine report and transaction thread report are bold in LHN
Scroll up to the top until New message button appears
Click on this button and verify that the chat scroll to the bottom
Verify that in LHN the combine report and transaction thread report aren't bold

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-22.at.17.06.14.mov

Android: mWeb Chrome

Screen.Recording.2024-04-22.at.17.03.50.mov

iOS: Native

Screen.Recording.2024-04-22.at.17.12.38.mov

iOS: mWeb Safari

Screen.Recording.2024-04-22.at.17.00.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-22.at.16.56.19.mov

MacOS: Desktop

Screen.Recording.2024-04-22.at.17.14.23.mov

melvin-bot · 2024-04-22T10:22:58Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2024-04-22T10:24:28Z

@paultsimura For IOS native, when we scroll up the New message button doesn't appear, I've checked and this bug also happens on the latest main.

paultsimura · 2024-04-22T18:23:25Z

+        const unreadActionSubscriptionForTransactionThread = DeviceEventEmitter.addListener(`unreadAction_${transactionThreadReport?.reportID}`, (newLastReadTime) => {
+            resetUnreadMarker(newLastReadTime);
+            setMessageManuallyMarkedUnread(new Date().getTime());
+        });
+
+        const readNewestActionSubscriptionForTransactionThread = DeviceEventEmitter.addListener(`readNewestAction_${transactionThreadReport?.reportID}`, (newLastReadTime) => {
+            resetUnreadMarker(newLastReadTime);
+            setMessageManuallyMarkedUnread(0);
+        });


Please wrap these into if (transactionThreadReport?.reportID) ...

@paultsimura I updated.

paultsimura · 2024-04-22T18:40:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android20.38.mp4

Android: mWeb Chrome

chrome20.38.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-22.at.20.38.0520.38.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-22.at.20.35.2120.38.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-22.at.20.24.3020.38.mp4

MacOS: Desktop

Screen.Recording.2024-04-22.at.20.26.2220.38.mp4

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

paultsimura

After these changes we'll be good to go

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

nkdengineer · 2024-04-24T07:39:14Z

@paultsimura Updated your suggestion.

paultsimura

LGTM ✔️

Note: the "New messages" button stopped scrolling down, but it's also happening in prod.

paultsimura · 2024-04-24T08:04:55Z

@amyevans I'm currently not in the C+ team, so the automation didn't assign you. Please proceed with the review here

amyevans · 2024-04-24T16:21:55Z

Note: the "New messages" button stopped scrolling down, but it's also happening in prod.

Thanks, confirmed this as well. Are you aware of a tracking issue for it? I see #40911 which might cover it, though it's technically currently scoped to the Self DM, so just wondering if there's another GH floating around. I'm surprised the bug made it to prod without being caught.

The code here LGTM!

OSBotify · 2024-04-24T16:29:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-25T14:08:29Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:26:08Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-26T22:57:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkdengineer added 5 commits April 22, 2024 14:49

fix unread issue in combine report

d3eeff3

add transaction thread report ID to option item

a97a864

add missing prop

27c8a30

reset hard code

bf3a0aa

fix lint

363d88b

nkdengineer mentioned this pull request Apr 22, 2024

[$500] Unable to mark system message unread in one transaction view #39407

Closed

6 tasks

revert hard code

9e93ce6

nkdengineer marked this pull request as ready for review April 22, 2024 10:22

nkdengineer requested a review from a team as a code owner April 22, 2024 10:22

melvin-bot Bot removed the request for review from a team April 22, 2024 10:22

melvin-bot Bot requested a review from paultsimura April 22, 2024 10:22

paultsimura suggested changes Apr 22, 2024

View reviewed changes

nkdengineer and others added 3 commits April 23, 2024 16:55

Merge branch 'main' into fix/39407

1b7042b

Update src/components/LHNOptionsList/types.ts

0ebd5be

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

wrap subscribe into check transaction thread report

d62791a

nkdengineer force-pushed the fix/39407 branch from 56e4327 to d62791a Compare April 23, 2024 11:08

fix typescript check

553ab3e

paultsimura suggested changes Apr 23, 2024

View reviewed changes

Comment thread src/pages/home/report/ReportActionsList.tsx Outdated

Comment thread src/pages/home/report/ReportActionsList.tsx Outdated

nkdengineer and others added 3 commits April 24, 2024 14:37

merge main

65423bf

Update src/pages/home/report/ReportActionsList.tsx

6a83a06

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

Update src/pages/home/report/ReportActionsList.tsx

c07e107

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

paultsimura approved these changes Apr 24, 2024

View reviewed changes

amyevans self-requested a review April 24, 2024 13:54

amyevans approved these changes Apr 24, 2024

View reviewed changes

amyevans merged commit 92acb42 into Expensify:main Apr 24, 2024

github-actions Bot mentioned this pull request Apr 25, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks

This was referenced Apr 26, 2024

[$250] Expense - Combined report in LHN is always bolded after modifying transaction #41088

Closed

[CP Staging] Revert "Fix unread issue in combine report" #41099

Merged

Uh oh!

Conversation

nkdengineer commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 22, 2024

Uh oh!

nkdengineer commented Apr 22, 2024

Uh oh!

Uh oh!

paultsimura Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

paultsimura commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Apr 24, 2024

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

paultsimura commented Apr 24, 2024

Uh oh!

amyevans commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Apr 22, 2024 •

edited

Loading

paultsimura commented Apr 22, 2024 •

edited

Loading