fix allow to search selfDM in new chat page by nkdengineer · Pull Request #40672 · Expensify/App

nkdengineer · 2024-04-22T06:37:38Z

Details

Fixed Issues

$ #40259
PROPOSAL: #40259 (comment)

Tests

Press FAB then Start chat
In the search field, type your email, your name or the word "you" ("tù" if language is set to Spanish)
Verify you see the self dm report (a report with your name and avatar)
Press the self dm report
Verify you are navigated to the self dm report

Verify that no errors appear in the JS console

Offline tests

QA Steps

Press FAB then Start chat
In the search field, type your email, your name or the word "you" ("tù" if language is set to Spanish)
Verify you see the self dm report (a report with your name and avatar)
Press the self dm report
Verify you are navigated to the self dm report

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-23.at.06.00.06.mov

Android: mWeb Chrome

Screen.Recording.2024-04-23.at.05.52.56.mov

iOS: Native

Screen.Recording.2024-04-23.at.06.02.46.mov

iOS: mWeb Safari

Screen.Recording.2024-04-23.at.05.55.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-22.at.16.20.46.mov

MacOS: Desktop

Screen.Recording.2024-04-22.at.16.24.44.mov

melvin-bot · 2024-04-22T06:39:49Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2024-04-22T06:47:43Z

I am updating the videos.

nkdengineer · 2024-04-22T09:14:01Z

+    if (!includeSelfDM) {
+        optionsToExclude.push({login: currentUserLogin});
+    }


@s77rt Using like this leads to the jest test 2 is failed

If I revert that change and update this to:

if (!reportOption.isSelfDM && (!includeThreads && (!!reportOption.login || reportOption.reportID) && optionsToExclude.some((option) => option.login === reportOption.login || option.reportID === reportOption.reportID)) ) {

the test is passed

I'm not seeing any failing test

Here is the test result https://github.com/Expensify/App/actions/runs/8780426190/job/24090318554?pr=40672. can you check it?

s77rt · 2024-04-22T18:04:46Z

Please change the testing steps to:

Press FAB then Start chat
In the search field, type your email, your name or the word "you" ("tù" if language is set to Spanish)
Verify you see the self dm report (a report with your name and avatar)
Press the self dm report
Verify you are navigated to the self dm report

s77rt · 2024-04-22T18:14:16Z

@nkdengineer Can you please add the missing screenshots

s77rt · 2024-04-22T18:16:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-04-22T18:17:08Z

Please tag me once the above concerns are addressed

nkdengineer · 2024-04-22T23:04:15Z

@s77rt All the videos and test steps are updated. Just need to address the issue #40672 (comment)

s77rt · 2024-04-23T13:03:37Z

I checked this and it seems the comments and the code do not match (outdated comments). We want to exclude the current user login from the personal details list only and not the reports list. The reports list already works es expected because If includeSelfDM is false, the user won't be even included in the reports list => we don't need to exclude him / nothing to exclude.

In the reports list however we want to exclude selected options, even if that option is a self dm. Your solution will break this as it will make the self dm always present even when we want to exclude it (if it's selected)

Suggested solution:

Define optionsToExclude as follow: const optionsToExclude: Option[] = [{login: CONST.EMAIL.NOTIFICATIONS}];
In personal details list loop extend the optionsToExlucde to cover the current user login: [...optionsToExclude, {login: currentUserLogin}]

nkdengineer · 2024-04-23T20:03:41Z

@s77rt Thanks for your suggestion. I updated PR based on that.

nkdengineer · 2024-04-24T03:13:42Z

@s77rt I resolved comment

thienlnam

Great, thanks!

OSBotify · 2024-04-25T14:08:26Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:26:05Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-26T22:57:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix allow to search selfDM in new chat page

90834be

nkdengineer marked this pull request as ready for review April 22, 2024 06:39

nkdengineer requested a review from a team as a code owner April 22, 2024 06:39

melvin-bot Bot requested review from s77rt and removed request for a team April 22, 2024 06:39

s77rt suggested changes Apr 22, 2024

View reviewed changes

Comment thread src/pages/NewChatPage.tsx Outdated

fix lint

4fa9dec

s77rt reviewed Apr 22, 2024

View reviewed changes

Comment thread src/pages/NewChatPage.tsx Outdated

nkdengineer added 3 commits April 22, 2024 14:30

fix use option.reportID in createChat

84605aa

fix lint

d40e0cf

fix revert fix jest

ac68346

nkdengineer commented Apr 22, 2024

View reviewed changes

nkdengineer added 2 commits April 24, 2024 02:48

fix jest test

666e9da

fix move logic push currentUserLogin to top

f60a610

s77rt suggested changes Apr 23, 2024

View reviewed changes

Comment thread src/libs/OptionsListUtils.ts Outdated

nkdengineer added 2 commits April 24, 2024 10:00

fix create new var personalDetailsOptionsToExclude

6698121

fix remove comment

003defb

s77rt approved these changes Apr 24, 2024

View reviewed changes

melvin-bot Bot requested a review from thienlnam April 24, 2024 03:21

thienlnam approved these changes Apr 24, 2024

View reviewed changes

thienlnam merged commit 59ae423 into Expensify:main Apr 24, 2024

github-actions Bot mentioned this pull request Apr 25, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks

melvin-bot Bot mentioned this pull request Apr 26, 2024

[CRITICAL][HOLD for payment 2024-05-03][Track Expense] [$500] Allow the self-DM to show up within the 'Start Chat' participant selector #40259

Closed

Uh oh!

Conversation

nkdengineer commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 22, 2024

Uh oh!

Uh oh!

nkdengineer commented Apr 22, 2024

Uh oh!

Uh oh!

nkdengineer Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Apr 22, 2024

Uh oh!

s77rt commented Apr 22, 2024

Uh oh!

s77rt commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Apr 22, 2024

Uh oh!

nkdengineer commented Apr 22, 2024

Uh oh!

s77rt commented Apr 23, 2024

Uh oh!

nkdengineer commented Apr 23, 2024

Uh oh!

Uh oh!

nkdengineer commented Apr 24, 2024

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Apr 22, 2024 •

edited

Loading

s77rt commented Apr 22, 2024 •

edited

Loading