Fixes ability to mention reports for room invited users by rlinoz · Pull Request #40506 · Expensify/App

rlinoz · 2024-04-18T21:12:07Z

Details

This fixes the behavior of when to show the auto complete widget for report mentions and when to parse report mentions in the reportActions list for users that are not members of a policy but got invited to a room.

cc: @robertKozik

Fixed Issues

$ https://github.com/Expensify/Web-Expensify/pull/41654#issuecomment-2065259420
PROPOSAL:

Tests

Preconditions: Have user A and user B, where user A is member of the policy and user B isn't.

[User A] Invite user B to a room created in the policy
[User A] Create a comment mentioning another room like #announce
[User B] Open the room you were invited to and check that you can see the mention and it is highlighted and clickable (you won't be able to access the other room, but it will try to redirect you to it)
[User B] Try to mention a room typing # and see that the auto complete widget shows up

Verify that no errors appear in the JS console

Offline tests

Preconditions: Have user A and user B, where user A is member of the policy and user B isn't.

[User B] While offline try to mention a room typing # and see that the auto complete widget shows up
[User B] Send the message with the room and go online
Check that the message was sent and received by user A

QA Steps

Preconditions: Have user A and user B, where user A is member of the policy and user B isn't.

[User A] Invite user B to a room created in the policy
[User A] Create a comment mentioning another room like #announce
[User B] Open the room you were invited to and check that you can see the mention and it is highlighted and clickable (you won't be able to access the other room, but it will try to redirect you to it)
[User B] Try to mention a room typing # and see that the auto complete widget shows up

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-04-18.at.18.36.45.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-18.at.18.26.51.mov

MacOS: Desktop

melvin-bot · 2024-04-18T21:45:26Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2024-04-18T21:52:50Z

+
+    // When we invite someone to a room they don't have the policy type, but we still want them to be able see and click on report mentions, so we also check the reportType in case the policyType was empty.
+    const isGroupPolicyReport = useMemo(
+        () => (currentReport && !isEmptyObject(currentReport) ? ReportUtils.isGroupPolicy(currentReport) || ReportUtils.isChatRoom(currentReport) : false),


Will this account for all report types on policies? Expense reports, workspace chats, transaction threads, user created rooms, default rooms, etc?

I don't think you can invite people into Expense reports, workspace chats and transaction threads.

So, for invited people it should account for created and default rooms, and for policy members it should account for all the ones you mentioned.

Oh you actually can invite to the workspace chat via whispers.

But even if you do it is kind of broken..not sure what is the expected behavior here.

Asked about it here.

But thinking better about this, I believe that if a report has a policy that is not _FAKE_ we should render the mention.

So we should be able to change this check to currentReport.policyID && currentReport.policyID !== CONST.POLICY.ID_FAKE.

That makes sense to me.

…invited-users

github-actions · 2024-04-19T17:42:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40506/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40506/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40506/NewExpensify.dmg	https://40506.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…portID

…invited-users

puneetlath · 2024-04-22T13:41:14Z

+
+    // When we invite someone to a room they don't have the policy object, but we still want them to be able to see and click on report mentions, so we only check if the policyID in the report is from a workspace
+    const isGroupPolicyReport = useMemo(
+        () => (currentReport && !isEmptyObject(currentReport) ? !!currentReport.policyID && currentReport.policyID !== CONST.POLICY.ID_FAKE : false),


I find the ternary here a bit hard to follow. A ternary seems like a weird choice for this type of condition. Is this the same as saying?

(currentReport && !isEmptyObject(currentReport) && !!currentReport.policyID && currentReport.policyID !== CONST.POLICY.ID_FAKE : false),

(currentReport && !isEmptyObject(currentReport) && !!currentReport.policyID && currentReport.policyID !== CONST.POLICY.ID_FAKE

It is, thanks

allroundexperts · 2024-04-22T13:52:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Julesssss

This mostly works for me on Web, maybe you can spot my mistake:

I can see the auto-complete widget appear ✅
I see the mention and can click the here link
The mentioned rooms aren't appearing as links like they do in your screenshots 😕

I am building against both of your PRs

robertKozik · 2024-04-23T16:24:38Z

I believe backend is, for now, removing the mention tags when room is not existing (I've compared the request payload and the backend response - correct me if I'm wrong with this @rlinoz ). Try mentioning already existing room.
Also npm ci is worth trying - in my case I had outdated expensify-common in node_modules

rlinoz · 2024-04-23T16:35:42Z

Yeah, basically what Robert said.

Another thing that can point to outdated node modules is if the mention is not highlighted in the composer.

rlinoz · 2024-04-23T16:35:52Z

Yeah, basically what Robert said.

Another thing that can point to outdated node modules is if the mention is not highlighted in the composer.

Julesssss

Cool, thanks both for the explanation.

OSBotify · 2024-04-24T06:17:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-25T14:08:17Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:25:56Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-26T22:56:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rlinoz added 3 commits April 18, 2024 18:09

checking if room is from a policy in case the policy type is emtpy

c23def1

better comment in rendere

d99c451

prettier

2936567

rlinoz self-assigned this Apr 18, 2024

rlinoz marked this pull request as ready for review April 18, 2024 21:45

rlinoz requested a review from a team as a code owner April 18, 2024 21:45

melvin-bot Bot removed the request for review from a team April 18, 2024 21:45

melvin-bot Bot requested a review from jasperhuangg April 18, 2024 21:45

puneetlath requested changes Apr 18, 2024

View reviewed changes

rlinoz added 2 commits April 19, 2024 12:40

Merge remote-tracking branch 'origin/main' into rodrigo-fix-mentions-…

4f4eb0e

…invited-users

checking only the policyID instead of checking types

2e085f3

rlinoz added the Ready To Build label Apr 19, 2024

rlinoz changed the title ~~Fixes ability to mention reports for room invited users~~ [HOLD] Fixes ability to mention reports for room invited users Apr 19, 2024

Removed unused import

6caa78c

Using the reportID from the HTML in case the report doesn't have a re…

23497bf

…portID

rlinoz changed the title ~~[HOLD] Fixes ability to mention reports for room invited users~~ Fixes ability to mention reports for room invited users Apr 20, 2024

Merge remote-tracking branch 'origin/main' into rodrigo-fix-mentions-…

f15d3fd

…invited-users

rlinoz requested a review from puneetlath April 20, 2024 14:08

puneetlath requested changes Apr 22, 2024

View reviewed changes

rlinoz requested a review from allroundexperts April 22, 2024 13:49

simpler condition

2126f53

prettier

8c16334

puneetlath approved these changes Apr 22, 2024

View reviewed changes

Julesssss requested changes Apr 23, 2024

View reviewed changes

jasperhuangg approved these changes Apr 24, 2024

View reviewed changes

Julesssss approved these changes Apr 24, 2024

View reviewed changes

Julesssss merged commit 915a1b6 into main Apr 24, 2024

Julesssss deleted the rodrigo-fix-mentions-invited-users branch April 24, 2024 06:10

github-actions Bot mentioned this pull request Apr 25, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks

izarutskaya mentioned this pull request Apr 26, 2024

Room - Flickering it's not here error when opening a room mention without access #41073

Closed

6 tasks

Uh oh!

Conversation

rlinoz commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 18, 2024

Uh oh!

puneetlath Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

rlinoz Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

rlinoz Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rlinoz Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

puneetlath Apr 19, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

puneetlath Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

rlinoz Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Apr 22, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

robertKozik commented Apr 23, 2024

Uh oh!

rlinoz commented Apr 23, 2024

Uh oh!

rlinoz commented Apr 23, 2024

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 24, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

OSBotify commented Apr 25, 2024

Uh oh!

OSBotify commented Apr 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rlinoz commented Apr 18, 2024 •

edited

Loading

rlinoz Apr 18, 2024 •

edited

Loading

rlinoz Apr 19, 2024 •

edited

Loading