Skip to content

[CP Staging] Fix: Composer - Pointer returns to previous line when adding new line #39934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 2 commits into from
Apr 9, 2024
Merged

[CP Staging] Fix: Composer - Pointer returns to previous line when adding new line #39934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca8e4f8
save white-characters-only drafts
kacper-mikolajczak Apr 9, 2024
6d3096b
replace nullish with OR fallback
kacper-mikolajczak Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libs/DraftCommentUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function getDraftComment(reportID: string): OnyxEntry<string> | null | undefined
* A valid draft comment is a non-empty string.
*/
function isValidDraftComment(comment?: string | null): boolean {
return !!comment?.trim();
return !!comment;
}

/**
Expand All @@ -36,12 +36,12 @@ function hasValidDraftComment(reportID: string): boolean {
}

/**
* Prepares a draft comment by trimming it and returning null if it's empty.
* Prepares a draft comment by returning null if it's empty.
*/
function prepareDraftComment(comment: string | null) {
// logical OR is used to convert empty string to null
Comment thread
kacper-mikolajczak marked this conversation as resolved.
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
return comment?.trim() || null;
return comment || null;
}

export {getDraftComment, isValidDraftComment, hasValidDraftComment, prepareDraftComment};