Skip to content

[No QA] Use one API call when receiving push notifications #39375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 6 commits into from
Apr 3, 2024
Merged

[No QA] Use one API call when receiving push notifications #39375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
997984c
remove background refresh
arosiclair Apr 1, 2024
c555004
add GetMissingOnyxMessagesForPushNotification
arosiclair Apr 1, 2024
837eb25
use GetMissingOnyxMessagesForPushNotification when filling onyx updat…
arosiclair Apr 1, 2024
948104d
Revert "use GetMissingOnyxMessagesForPushNotification when filling on…
arosiclair Apr 3, 2024
ad4ec77
Revert "add GetMissingOnyxMessagesForPushNotification"
arosiclair Apr 3, 2024
d81de8f
Merge branch 'main' of github.com:Expensify/App into arosiclair-push-…
arosiclair Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions src/libs/Notification/PushNotification/backgroundRefresh/index.android.ts
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions src/libs/Notification/PushNotification/backgroundRefresh/index.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/libs/Notification/PushNotification/backgroundRefresh/types.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import type {OnyxUpdatesFromServer} from '@src/types/onyx';
import {isEmptyObject} from '@src/types/utils/EmptyObject';
import backgroundRefresh from './backgroundRefresh';
import PushNotification from './index';

let lastVisitedPath: string | undefined;
Expand Down Expand Up @@ -51,8 +50,6 @@ export default function subscribeToReportCommentPushNotifications() {
} else {
Log.hmmm("[PushNotification] Didn't apply onyx updates because some data is missing", {lastUpdateID, previousUpdateID, onyxDataCount: onyxData?.length ?? 0});
}

backgroundRefresh();
});

// Open correct report when push notification is clicked
Expand Down