Fix infinite loading on invite and task assignee page after refresh by bernhardoj · Pull Request #39223 · Expensify/App

bernhardoj · 2024-03-29T02:09:23Z

Details

After refreshing on invite and task assignee page, the screen transition event is never captured and we won't show anything if the screen transition event is not captured.

Fixed Issues

$ #22508
PROPOSAL: #22508 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to workspace invite page
Refresh
Verify the page doesn't infinitely loading
Go to assign task page
Enter any task name and go next
Press the assignee to open the assignee picker page
Refresh
Verify the page doesn't infinitely loading
Go to any own room chat (create one if you don't have)
Press the room header to open the details
Press Member and Invite
Refresh
Verify the page doesn't infinitely loading

Android/iOS
Can't refresh, so just make sure that opening each page is working fine.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-01.at.20.55.42.mov

Screen.Recording.2024-04-01.at.20.56.47.mov

Screen.Recording.2024-04-01.at.20.57.46.mov

Android: mWeb Chrome

Screen.Recording.2024-03-29.at.09.58.55.mov

Screen.Recording.2024-03-29.at.10.03.56.mov

Screen.Recording.2024-03-29.at.10.04.40.mov

iOS: Native

Screen.Recording.2024-04-01.at.20.53.56.mov

Screen.Recording.2024-04-01.at.20.54.37.mov

Screen.Recording.2024-04-01.at.20.55.28.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.09.57.05.mov

Screen.Recording.2024-03-29.at.09.57.53.mov

Screen.Recording.2024-03-29.at.09.58.36.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-29.at.09.52.51.mov

Screen.Recording.2024-03-29.at.09.54.30.mov

Screen.Recording.2024-03-29.at.09.52.04.mov

MacOS: Desktop

Screen.Recording.2024-03-29.at.09.55.52.mov

Screen.Recording.2024-03-29.at.09.56.18.mov

Screen.Recording.2024-03-29.at.09.56.37.mov

melvin-bot · 2024-03-29T02:09:28Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-03-29T02:18:36Z

You can temporarily comment out this code to be able to access workspace page in small screen.

App/src/libs/Navigation/linkTo.ts

Line 198 in c56458f

if (action.payload.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {

situchan

Code looks good

situchan · 2024-03-29T20:07:35Z

@@ -0,0 +1,39 @@
+import {useNavigation} from '@react-navigation/native';


NAB: I think withNavigationTransitionEnd file name makes more sense

situchan · 2024-03-29T20:25:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

mchrome.mov

iOS: Native

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web-invite.mov

web-room.mov

web-task.mov

MacOS: Desktop

desktop.mov

situchan · 2024-03-29T20:26:01Z

Bug: Not able to go to workspace detail on mWeb

Go to Settings > Workspaces
Select any workspace
Nothing happens

bug.mov

situchan · 2024-03-29T20:27:50Z

NVM, bug fixed after pulling main locally. Please merge main

bernhardoj · 2024-03-30T05:41:45Z

Merged with main and renamed

rlinoz · 2024-04-01T12:40:18Z

Did we test on native just to make sure the pages are normally loading?

bernhardoj · 2024-04-01T13:03:35Z

Oh good point, I just added the recording for native platforms.

rlinoz

LGTM, thanks!

melvin-bot · 2024-04-01T13:23:31Z

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

rlinoz · 2024-04-01T13:24:44Z

I honestly don't know what is happening with GH, even reloaded the page to validate if there was a missing check, but yeah, no emergency here.

OSBotify · 2024-04-01T13:30:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-02T11:15:24Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T10:56:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 4 commits March 28, 2024 18:50

create withTransitionEnd hook

a32c7ee

use didScreenTransitionEnd from withTransitionEnd HOC

bb40f85

add missing forwardRef

77c05c9

Merge branch 'main' into fix/22508-infinite-loading-invite-page-2

4689f4e

bernhardoj requested a review from a team as a code owner March 29, 2024 02:09

melvin-bot Bot requested review from situchan and removed request for a team March 29, 2024 02:09

situchan reviewed Mar 29, 2024

View reviewed changes

situchan approved these changes Mar 29, 2024

View reviewed changes

melvin-bot Bot requested a review from rlinoz March 29, 2024 20:28

bernhardoj added 2 commits March 30, 2024 13:35

Merge branch 'main' into fix/22508-infinite-loading-invite-page-2

f4861a1

renaming

471895f

rlinoz approved these changes Apr 1, 2024

View reviewed changes

rlinoz merged commit aacfa8c into Expensify:main Apr 1, 2024

melvin-bot Bot added the Emergency label Apr 1, 2024

rlinoz removed the Emergency label Apr 1, 2024

github-actions Bot mentioned this pull request Apr 2, 2024

Deploy Checklist: New Expensify 2024-04-02 #39399

Closed

87 tasks

melvin-bot Bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [$1000] Infinite loading on Invite members page after refresh #22508

Closed

6 tasks

		@@ -0,0 +1,39 @@
		import {useNavigation} from '@react-navigation/native';

Uh oh!

Conversation

bernhardoj commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 29, 2024

Uh oh!

bernhardoj commented Mar 29, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan Mar 29, 2024

Choose a reason for hiding this comment

Uh oh!

situchan commented Mar 29, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Mar 29, 2024

Uh oh!

situchan commented Mar 29, 2024

Uh oh!

bernhardoj commented Mar 30, 2024

Uh oh!

rlinoz commented Apr 1, 2024

Uh oh!

bernhardoj commented Apr 1, 2024

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 1, 2024

Uh oh!

rlinoz commented Apr 1, 2024

Uh oh!

OSBotify commented Apr 1, 2024

Uh oh!

OSBotify commented Apr 2, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented Mar 29, 2024 •

edited

Loading