Fix/37448: Incorrect title thread by dukenv0307 · Pull Request #38267 · Expensify/App

dukenv0307 · 2024-03-14T01:26:22Z

Details

Incorrect title for "Edited money request" thread

Fixed Issues

$ #37448
PROPOSAL: #37448 (comment)

Tests

Request money
Open the created money request
Modify a field (e.g. merchant)
Find the system message that says "changed the merchant to ..."
Click "Reply in thread"
Check the title in the header
It should reflect the text of the system

Verify that no errors appear in the JS console

Offline tests

QA Steps

Request money
Open the created money request
Modify a field (e.g. merchant)
Find the system message that says "changed the merchant to ..."
Click "Reply in thread"
Check the title in the header
It should reflect the text of the system

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-14.at.08.43.31.mov

Android: mWeb Chrome

Screen.Recording.2024-03-14.at.08.29.51.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-03-14.at.08.41.30.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-14.at.08.23.58.mov

MacOS: Desktop

Screen.Recording.2024-03-14.at.08.46.49.mov

melvin-bot · 2024-03-14T01:26:27Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-03-18T02:43:17Z

@mkhutornyi Ping to review the PR in case you miss it

mkhutornyi · 2024-03-18T06:04:04Z

 * If we change this function be sure to update the backend as well.
 */
-function getForReportAction(reportID: string | undefined, reportAction: OnyxEntry<ReportAction>): string {
+function getForReportAction(reportID: string | undefined, reportAction: OnyxEntry<ReportAction> | ReportAction | Record<string, never>): string {


I don't like updating type of reportAction here.
If this causes TS error in other place, fix it to match OnyxEntry<ReportAction> instead of fixing here.

Do you have any idea to do like you mentioned?

Additionally, I just tested the current implementation and there is no TS error in other place

ok, I am fine with this as already existing pattern in other place

mkhutornyi · 2024-03-18T06:07:52Z

@@ -0,0 +1,32 @@
+import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';


I see that this is to avoid cycle dependency.
Please add comment why this separate file is needed.

Added comment

mkhutornyi · 2024-03-20T12:20:19Z

Please merge main. I will check shortly

dukenv0307 · 2024-03-20T12:22:19Z

I merged main

mkhutornyi · 2024-03-24T09:49:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

desktop.mov

paultsimura · 2024-10-08T09:10:05Z

            return `${parentReportActionMessage} (${Localize.translateLocal('common.archived')})`;
        }
+        if (ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {
+            return ModifiedExpenseMessage.getForReportAction(report?.reportID, parentReportAction);


We should have used formatReportLastMessageText here similar to other cases above. More context here: #49518

fix incorrect title thread

e5a4710

dukenv0307 requested a review from a team as a code owner March 14, 2024 01:26

melvin-bot Bot removed the request for review from a team March 14, 2024 01:26

melvin-bot Bot requested a review from mkhutornyi March 14, 2024 01:26

dukenv0307 added 4 commits March 14, 2024 09:11

fix lint

c3210dd

fix revert lint fix

8ca3778

fix lint deps cycle

f92c833

fix pretier

475f300

dukenv0307 mentioned this pull request Mar 14, 2024

[HOLD for payment 2024-04-05] [$500] Incorrect title for "Edited money request" thread #37448

Closed

6 tasks

mkhutornyi reviewed Mar 18, 2024

View reviewed changes

fix add comment to a new file

7089e82

fix merge main

f5a2eff

mkhutornyi approved these changes Mar 24, 2024

View reviewed changes

melvin-bot Bot requested a review from cristipaval March 24, 2024 09:49

cristipaval approved these changes Mar 25, 2024

View reviewed changes

cristipaval merged commit a35ccc6 into Expensify:main Mar 25, 2024

github-actions Bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

paultsimura reviewed Oct 8, 2024

View reviewed changes

paultsimura mentioned this pull request Oct 8, 2024

[HOLD for Payment OCT 08] [$250] [Search v2.3] - Default name is not displayed correctly for multiline system message thread #49330

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/37448: Incorrect title thread#38267

Fix/37448: Incorrect title thread#38267
cristipaval merged 7 commits into
Expensify:mainfrom
dukenv0307:fix/37448-incorrect-title-for-edit-request-message

dukenv0307 commented Mar 14, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 14, 2024

Uh oh!

dukenv0307 commented Mar 18, 2024

Uh oh!

mkhutornyi Mar 18, 2024

Uh oh!

dukenv0307 Mar 20, 2024

Uh oh!

mkhutornyi Mar 24, 2024

Uh oh!

mkhutornyi Mar 18, 2024

Uh oh!

dukenv0307 Mar 20, 2024

Uh oh!

mkhutornyi commented Mar 20, 2024

Uh oh!

dukenv0307 commented Mar 20, 2024

Uh oh!

mkhutornyi commented Mar 24, 2024

Uh oh!

paultsimura Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,32 @@
		import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';

Conversation

dukenv0307 commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 14, 2024

Uh oh!

dukenv0307 commented Mar 18, 2024

Uh oh!

mkhutornyi Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Mar 20, 2024

Choose a reason for hiding this comment

Uh oh!

mkhutornyi Mar 24, 2024

Choose a reason for hiding this comment

Uh oh!

mkhutornyi Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Mar 20, 2024

Choose a reason for hiding this comment

Uh oh!

mkhutornyi commented Mar 20, 2024

Uh oh!

dukenv0307 commented Mar 20, 2024

Uh oh!

mkhutornyi commented Mar 24, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 commented Mar 14, 2024 •

edited

Loading