Skip to content

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript"#37529

Merged
puneetlath merged 1 commit into
mainfrom
revert-34168-ts-migration/MoneyRequestConfirmationList/component
Feb 29, 2024
Merged

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript"#37529
puneetlath merged 1 commit into
mainfrom
revert-34168-ts-migration/MoneyRequestConfirmationList/component

Conversation

@puneetlath

@puneetlath puneetlath commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Reverts #34168

@puneetlath puneetlath marked this pull request as ready for review February 29, 2024 16:58
@puneetlath puneetlath requested a review from a team as a code owner February 29, 2024 16:58
@melvin-bot melvin-bot Bot removed the request for review from a team February 29, 2024 16:58
@melvin-bot

melvin-bot Bot commented Feb 29, 2024

Copy link
Copy Markdown

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested a review from blimpich February 29, 2024 16:58
@puneetlath

puneetlath commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

Money requests seem to generally work after the revert.
image

@puneetlath

puneetlath commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

Going to go ahead and merge without tests passing since it's a straight revert.

@puneetlath puneetlath merged commit 3730ed2 into main Feb 29, 2024
@puneetlath puneetlath deleted the revert-34168-ts-migration/MoneyRequestConfirmationList/component branch February 29, 2024 17:04
@melvin-bot melvin-bot Bot added the Emergency label Feb 29, 2024
@melvin-bot

melvin-bot Bot commented Feb 29, 2024

Copy link
Copy Markdown

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath

puneetlath commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

Merged without tests passing because of #37529 (comment)

This was referenced Feb 29, 2024
Closed
Closed
OSBotify pushed a commit that referenced this pull request Feb 29, 2024
@puneetlath @OSBotify
Merge pull request #37529 from Expensify/revert-34168-ts-migration/Mo…
00449ee 
…neyRequestConfirmationList/component

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript"

(cherry picked from commit 3730ed2)
This was referenced Feb 29, 2024
Closed
Closed
Closed
@github-actions github-actions Bot mentioned this pull request Feb 29, 2024
Closed
91 tasks
@OSBotify

OSBotify commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.45-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

OSBotify commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@puneetlath puneetlath self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes
@blimpich blimpich Awaiting requested review from blimpich

Assignees

@puneetlath puneetlath

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@puneetlath @OSBotify @AndrewGable