Refactor/align selectionlist checkboxes by ArekChr · Pull Request #37402 · Expensify/App

ArekChr · 2024-02-28T10:35:24Z

This PR introduces an enhancement to the SelectionList by adding an additional press handler. This modification caters to scenarios where a different function is needed upon pressing a row.

Details

When onCheckboxPress is defined, its handler is applied to the checkbox only.
When onCheckboxPress is not defined, its handler applies to the entire row.

Check Desktop Web videos for both scenarios, as other platforms contain the first case

Fixed Issues

$ #37307
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Go to workspace categories as an admin of the paid policy group
Press on the checkbox of any category
Confirm that its state changes to reflect the selection
Click on the row of the category list item, outside the checkbox area.
Ensure that clicking the list item row opens the category's settings page

Offline tests

QA Steps

the same as a test steps

PR Author Checklist

Screenshots/Videos

Android: Native

Scenario when onCheckboxPress defined

Nagranie.z.ekranu.2024-02-28.o.12.06.25.mov

Android: mWeb Chrome

iOS: Native

Scenario when onCheckboxPress defined

Nagranie.z.ekranu.2024-02-28.o.12.02.53.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Scenario with toggle function in 'onCheckboxPress' and navigation onSelectRow

Nagranie.z.ekranu.2024-02-28.o.11.36.46.mov

Scenario with toggle function in 'onSelectRow'

Nagranie.z.ekranu.2024-02-28.o.11.36.46.mov

MacOS: Desktop

Nagranie.z.ekranu.2024-02-28.o.12.13.28.mov

ArekChr · 2024-02-28T11:03:45Z

Maybe we should limit the touch handler for the select all function to the checkbox area, not the entire row? cc @Expensify/design

Nagranie.z.ekranu.2024-02-28.o.12.02.53.mov

melvin-bot · 2024-02-28T11:14:36Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2024-02-28T11:18:51Z

cc @luacmartins

shawnborton · 2024-02-28T14:26:06Z

Maybe we should limit the touch handler for the select all function to the checkbox area, not the entire row? cc

Yup, I agree with that.

dannymcclain · 2024-02-28T14:27:57Z

Maybe we should limit the touch handler for the select all function to the checkbox area, not the entire row? cc

Yup, I agree with that.

I agree as well.

ArekChr · 2024-02-28T14:47:14Z

Cool, this change will be implemented in all selection lists

luacmartins

LGTM

luacmartins · 2024-02-28T19:19:40Z

Reassigning to @situchan since @ntdiary seems to be out sick

situchan · 2024-02-28T19:50:58Z

Text should be selectable? And show I-beam cursor on hover?

situchan

Looks good. Some minor feedback

situchan · 2024-02-28T20:05:00Z

        return rightHandSideComponent;
    };

+    const handleCheckboxPress = () => {


NAB:

use useCallback with item dependency.

or I think onPress={() => (onCheckboxPress ?? onSelectRow)(item)} is better without defining this function

situchan · 2024-02-28T20:06:25Z

                showTooltip={showTooltip}
                canSelectMultiple={canSelectMultiple}
                onSelectRow={() => selectRow(item)}
+                onCheckboxPress={onCheckboxPress ? () => onCheckboxPress?.(item) : undefined}


NAB:

Suggested change

onCheckboxPress={onCheckboxPress ? () => onCheckboxPress?.(item) : undefined}

onCheckboxPress={onCheckboxPress ? () => onCheckboxPress(item) : undefined}

situchan · 2024-02-28T20:27:41Z

Text should be selectable? And show I-beam cursor on hover?

Screen.Recording.2024-02-29.at.2.27.12.AM.mov

cc: @Expensify/design

shawnborton · 2024-02-28T20:30:15Z

I don't feel too strongly whether or not that text is selectable... I'm fine with how it is right now.

situchan · 2024-02-28T21:05:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

luacmartins · 2024-02-28T21:08:37Z

Thanks for the review. I'll go ahead and merge this since it unblocks further Simplified Collect development.

OSBotify · 2024-02-28T21:13:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:08:40Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary · 2024-02-29T10:37:01Z

                            {canSelectMultiple && (
-                                <View
+                                <PressableWithFeedback
+                                    accessibilityLabel={item.text}


a minor regression:

regression.mp4

we also need to pass disabled={isDisabled}? 🤔

yes, I noticed that as well. Btw not blocker since admin cannot be actually removed.
Hope @ArekChr would fix it as follow-up along with my NAB feedback

OSBotify · 2024-02-29T23:33:08Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ArekChr added 4 commits February 28, 2024 11:34

feat: add optional checkbox press handled

66a4c0a

chore: temporary navigate to categories settings when pressing row

ad6aa38

fix: pass undefined if onCheckboxPress is undefined

ee31536

feat: add support for radio and user list item

645a1a4

MrMuzyk approved these changes Feb 28, 2024

View reviewed changes

ArekChr marked this pull request as ready for review February 28, 2024 11:14

ArekChr requested a review from a team as a code owner February 28, 2024 11:14

melvin-bot Bot requested review from ntdiary and removed request for a team February 28, 2024 11:14

refactor: select all checkbox only in checkbox area

2e1472b

luacmartins self-requested a review February 28, 2024 15:43

burczu approved these changes Feb 28, 2024

View reviewed changes

luacmartins approved these changes Feb 28, 2024

View reviewed changes

luacmartins requested a review from situchan February 28, 2024 19:18

luacmartins removed the request for review from ntdiary February 28, 2024 19:19

situchan reviewed Feb 28, 2024

View reviewed changes

luacmartins merged commit e07156c into Expensify:main Feb 28, 2024

github-actions Bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

ntdiary reviewed Feb 29, 2024

View reviewed changes

m-natarajan mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-04-03] Category - Checkbox is clickable outside near the right of checkbox #37511

Closed

6 tasks

melvin-bot Bot mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-03-07] [$500] Update SelectionList to handle checkbox callback #37307

Closed

	onCheckboxPress={onCheckboxPress ? () => onCheckboxPress?.(item) : undefined}
	onCheckboxPress={onCheckboxPress ? () => onCheckboxPress(item) : undefined}

Uh oh!

Conversation

ArekChr commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ArekChr commented Feb 28, 2024

Uh oh!

melvin-bot Bot commented Feb 28, 2024

Uh oh!

ArekChr commented Feb 28, 2024

Uh oh!

shawnborton commented Feb 28, 2024

Uh oh!

dannymcclain commented Feb 28, 2024

Uh oh!

ArekChr commented Feb 28, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Feb 28, 2024

Uh oh!

situchan commented Feb 28, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Feb 28, 2024

Uh oh!

shawnborton commented Feb 28, 2024

Uh oh!

situchan commented Feb 28, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Feb 28, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

ntdiary Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

situchan Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ArekChr commented Feb 28, 2024 •

edited

Loading

situchan Feb 28, 2024 •

edited

Loading

situchan Feb 28, 2024 •

edited

Loading