[CP Staging] Fix Apple and Google SSO when login in from public room with mentions in it#36041
Conversation
|
@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
|
Ignoring perf tests |
|
@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
This resolves a fire, so I ignored the performance check |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix Apple and Google SSO when login in from public room with mentions in it (cherry picked from commit 79540ce)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.38-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Parent issue here btw: https://github.com/Expensify/Expensify/issues/367462 |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.38-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀
|
|
Based on the pull request description and diff provided, the PR is fixing an issue with Single Sign-On (SSO) using Apple and Google when a user attempts to login from a public room on the web, particularly in scenarios where the room contains mentions. The changes involve handling email domain checks more gracefully to avoid application crashes. Relevant Test Cases:
These test cases cover the login process, handling of mentions, and potential issues affecting user navigation and interactions within public or custom rooms. |
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
|
Based on the provided pull request context, the PR addresses a bug related to Apple and Google SSO when logging in from a public room with mentions. The issue was causing the app to crash due to a TypeError in the Here are the test cases that are most relevant to this PR:
These test cases cover the areas of SSO login and public room interactions, which are the primary focus of the PR. |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
1 similar comment
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
|
new |
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers: |
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
1 similar comment
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
|
new |
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|

Details
When signing using Apple SSO as anonymous user from public room in web, the app crashed with following stacktrace:
The error comes from expensify-common on this line, where the str seems to be undefined, that is passed from the extractEmailDomain here and that is called from the App here.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/367462
https://expensify.slack.com/archives/C06HN74HKMG/p1707321835134969
Tests
Offline tests
n/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2024-02-07.at.16.40.37.mp4
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop