[TS migration] Migrate 'IOU' page to TypeScript by pac-guerreiro · Pull Request #35253 · Expensify/App

pac-guerreiro · 2024-01-26T14:42:44Z

Details

Fixed Issues

$#25200
PROPOSAL: N/A

Tests

Split bill - Details (SplitBillDetailsPage.tsx & WithReportAndReportActionOrNotFound.tsx)

On home screen, click on the ( + ) floating action button and select Request money
Select manual, enter any valid amount and continue
Click on Split on any participant and click on Add to split
Click on Split {currency} {amount}
Click on the newly created split preview
Check that the page renders correctly and works as expected

Send money - Confirmation step (MoneyRequestConfirmationList.tsx)

On home screen, click on the ( + ) floating action button and select Send money
Enter any valid amount and continue
Select any participant and continue
Check that the confirmation page renders correctly and works as expected

NewDistanceRequestPage.tsx

Unable to test

NewRequestAmountPage.tsx

Unable to test

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ypescript

pac-guerreiro · 2024-01-26T14:47:40Z

This PR is dependent on ~~#34335~~, ~~#24921~~ and ~~#32004~~

…ypescript # Conflicts: # src/ONYXKEYS.ts # src/pages/iou/SplitBillDetailsPage.js

…ypescript # Conflicts: # src/ONYXKEYS.ts # src/libs/actions/IOU.ts

…ypescript # Conflicts: # src/pages/home/report/withReportAndReportActionOrNotFound.tsx

…ypescript # Conflicts: # src/ONYXKEYS.ts

…ypescript # Conflicts: # src/libs/actions/IOU.ts

fabioh8010 · 2024-03-07T13:39:54Z

What's the status on this @pac-guerreiro ?

…ypescript # Conflicts: # src/libs/actions/IOU.ts

…ypescript # Conflicts: # src/libs/TransactionUtils.ts # src/libs/actions/IOU.ts

…ypescript

pac-guerreiro · 2024-03-16T01:33:42Z

@fabioh8010

This is ready for re-review by our team!

…ypescript # Conflicts: # src/libs/Navigation/types.ts

blazejkustra

Great work! Left couple comments 😄

…ypescript

c3024 · 2024-03-22T16:33:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

iouAndroid.mp4

Android: mWeb Chrome

iouAndroidChrome.mp4

iOS: Native

iouiOS.mp4

iOS: mWeb Safari

iouiOSSafari.mp4

MacOS: Chrome / Safari

splitBillChrome.mp4

sendMoneyChrome.mp4

MacOS: Desktop

splitBillDesktop.mp4

sendMoneyDesktop.mp4

c3024 · 2024-03-24T15:47:06Z

Creating a split bill offline shows a continuous loading indicator on the group chat on this branch whereas on main it shows the optimistic report preview of the split request on the group chat correctly.

splitBillOffline.mp4

fabioh8010 · 2024-03-26T06:57:03Z

@pac-guerreiro bump

…ypescript

…ypescript # Conflicts: # src/libs/actions/IOU.ts

pac-guerreiro · 2024-03-26T23:34:41Z

@fabioh8010 @c3024

All feedback addressed, thanks for your patience! 😄

The split bill bug should be resolved, as you can see below but give it a try once again just in case

Screen.Recording.2024-03-26.at.23.32.22.mp4

srikarparsi · 2024-03-27T21:29:20Z

Hi @c3024, can you take another look at this whenever you get a chance?

c3024 · 2024-03-28T10:28:42Z

NewDistanceRequestPage.tsx

Unable to test

No changes are made to this file in this PR so I think this need not be tested. This is not being used anywhere and completely deprecated in #34610

NewRequestAmountPage.tsx

Unable to test

This is not used anywhere anymore and this will also be deprecated in #34614

c3024

LGTM

blazejkustra · 2024-03-28T11:24:07Z

@srikarparsi All yours!

blazejkustra · 2024-03-28T11:24:28Z

@pac-guerreiro Let's merge the newest main here

…ypescript

pac-guerreiro · 2024-03-28T19:07:15Z

@fabioh8010 @srikarparsi @blazejkustra I merged latest main to this branch

kubabutkiewicz · 2024-03-29T15:51:23Z

@srikarparsi kind bump 😄

srikarparsi · 2024-03-29T17:18:55Z

Sorry about that, taking a look

srikarparsi

lgtm as well, thanks for the changes :)

melvin-bot · 2024-03-29T17:50:38Z

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

srikarparsi · 2024-03-29T17:51:36Z

No tests failed above, removing the emergency label

Screen.Recording.2024-03-29.at.1.51.48.PM.mov

OSBotify · 2024-04-02T11:13:48Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T10:53:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pac-guerreiro added 2 commits January 26, 2024 12:07

refactor(typescript): migrate iou page

be682af

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

546e43a

…ypescript

pac-guerreiro added 3 commits February 5, 2024 10:15

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

cf5f1cd

…ypescript # Conflicts: # src/ONYXKEYS.ts # src/pages/iou/SplitBillDetailsPage.js

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

4ff2192

…ypescript # Conflicts: # src/ONYXKEYS.ts # src/libs/actions/IOU.ts

chore(typescript): migrate IOU related components

3c16bee

fabioh8010 reviewed Feb 8, 2024

View reviewed changes

VickyStash reviewed Feb 8, 2024

View reviewed changes

pac-guerreiro added 7 commits February 9, 2024 17:16

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

96c467f

…ypescript # Conflicts: # src/pages/home/report/withReportAndReportActionOrNotFound.tsx

chore: apply pull request suggestions

b25f22f

fix: typing issues

9eebd1b

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

9ee97a0

…ypescript # Conflicts: # src/ONYXKEYS.ts

chore: apply pull request feedback

264dbbc

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

45a08a8

…ypescript # Conflicts: # src/libs/actions/IOU.ts

chore: remove unused typescript expect error

9ab98e0

pac-guerreiro added 6 commits March 11, 2024 16:49

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

b2ab8c6

…ypescript # Conflicts: # src/libs/actions/IOU.ts

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

0845c3e

…ypescript # Conflicts: # src/libs/TransactionUtils.ts # src/libs/actions/IOU.ts

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

54a4ac9

…ypescript

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

6f8fcb7

…ypescript

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

fad75a9

…ypescript

fix(typescript): type mismatches

dfdb162

VickyStash reviewed Mar 18, 2024

View reviewed changes

Comment thread src/ONYXKEYS.ts Outdated

Comment thread src/pages/iou/NewDistanceRequestPage.tsx Outdated

Comment thread src/components/DistanceRequest/index.tsx Outdated

Comment thread src/pages/iou/SplitBillDetailsPage.tsx Outdated

Comment thread src/pages/iou/SplitBillDetailsPage.tsx Outdated

pac-guerreiro added 4 commits March 18, 2024 17:51

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

c6b427b

…ypescript # Conflicts: # src/libs/Navigation/types.ts

refactor(typescript): apply pull request feedback

a0655e1

refactor(typescript): apply pull request feedback

a1794d0

fix: add missing dependency on useEffect

521f2ba

blazejkustra approved these changes Mar 18, 2024

View reviewed changes

Comment thread src/pages/iou/steps/NewRequestAmountPage.tsx

Comment thread src/pages/iou/steps/NewRequestAmountPage.tsx Outdated

Comment thread src/pages/iou/steps/NewRequestAmountPage.tsx

Comment thread src/pages/iou/steps/NewRequestAmountPage.tsx Outdated

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

3b41c2e

…ypescript

c3024 suggested changes Mar 24, 2024

View reviewed changes

Comment thread src/pages/iou/SplitBillDetailsPage.tsx Outdated

Comment thread src/pages/iou/SplitBillDetailsPage.tsx Outdated

c3024 reviewed Mar 24, 2024

View reviewed changes

Comment thread src/pages/iou/steps/NewRequestAmountPage.tsx Outdated

pac-guerreiro added 3 commits March 26, 2024 09:56

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

6431baf

…ypescript

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

38be36d

…ypescript # Conflicts: # src/libs/actions/IOU.ts

refactor(typescript): apply pull request suggestions

2f643b2

c3024 approved these changes Mar 28, 2024

View reviewed changes

pac-guerreiro added 2 commits March 28, 2024 15:01

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

ad93e44

…ypescript

Merge branch 'main' into pac-guerreiro/refactor/migrate-iou-page-to-t…

49b4982

…ypescript

srikarparsi approved these changes Mar 29, 2024

View reviewed changes

srikarparsi merged commit 2d7addc into Expensify:main Mar 29, 2024

melvin-bot Bot added the Emergency label Mar 29, 2024

srikarparsi removed the Emergency label Mar 29, 2024

github-actions Bot mentioned this pull request Apr 2, 2024

Deploy Checklist: New Expensify 2024-04-02 #39399

Closed

87 tasks

tgolen mentioned this pull request Apr 3, 2024

IOU - Comment on a deleted IOU isn't opening from the combined report view #39512

Closed

6 tasks

melvin-bot Bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [TS migration] Migrate 'IOU' page to TypeScript #25200

Closed

Uh oh!

Conversation

pac-guerreiro commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

pac-guerreiro commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabioh8010 commented Mar 7, 2024

Uh oh!

pac-guerreiro commented Mar 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c3024 commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c3024 commented Mar 24, 2024

Uh oh!

fabioh8010 commented Mar 26, 2024

Uh oh!

pac-guerreiro commented Mar 26, 2024

Uh oh!

srikarparsi commented Mar 27, 2024

Uh oh!

c3024 commented Mar 28, 2024

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra commented Mar 28, 2024

Uh oh!

blazejkustra commented Mar 28, 2024

Uh oh!

pac-guerreiro commented Mar 28, 2024

Uh oh!

kubabutkiewicz commented Mar 29, 2024

Uh oh!

srikarparsi commented Mar 29, 2024

Uh oh!

pac-guerreiro commented Jan 26, 2024 •

edited

Loading

pac-guerreiro commented Jan 26, 2024 •

edited

Loading

c3024 commented Mar 22, 2024 •

edited

Loading

srikarparsi commented Mar 29, 2024 •

edited

Loading