Refactor task preview for hidden case by dukenv0307 · Pull Request #35027 · Expensify/App

dukenv0307 · 2024-01-24T04:37:41Z

Details

Refactor task preview for hidden case

Fixed Issues

$ #34052
PROPOSAL: #34052 (comment)

Tests

Go to FAB > Assign task
Enter title > Next
Enter an assignee as a user with no display name that has no chat history with the current user
Confirm to create a task
Verify that Hidden appears as assignee in task preview.

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Go to FAB > Assign task
Enter title > Next
Enter an assignee as a user with no display name that has no chat history with the current user
Confirm to create a task
Verify that Hidden appears as assignee in task preview.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-28.at.20.08.44.mov

Android: mWeb Chrome

Screen.Recording.2024-01-24.at.11.17.38.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-01-24.at.11.10.58.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-24.at.11.05.50.mov

MacOS: Desktop

Screen.Recording.2024-01-24.at.11.28.37.mov

melvin-bot · 2024-01-24T04:38:02Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-01-24T04:38:34Z

@hoangzinh I have some problems with my iOS and Android simulator. Will update the screenshot for this soon.

hoangzinh · 2024-01-24T11:07:45Z

        const user = lodashGet(personalDetails, htmlAttribAccountID);
        accountID = parseInt(htmlAttribAccountID, 10);
-        displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || lodashGet(user, 'displayName', '') || translate('common.hidden');
+        displayNameOrLogin = lodashGet(user, 'displayName', '') || LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || translate('common.hidden');


Do you think we can replace this line by ReportUtils.getDisplayNameForParticipant

Looked at getDisplayNameForParticipant function and yeah we can use this as well.

TLDR; we tried to use getDisplayNameForParticipant but we found a bug here, so we decided to keep it as it is for now.
#35027 (comment)

hoangzinh · 2024-01-24T11:09:58Z

-        taskAssignee && taskAssigneeAccountID !== 0
-            ? `<comment><mention-user accountid="${taskAssigneeAccountID}">@${taskAssignee}</mention-user> ${taskTitle}</comment>`
-            : `<comment>${taskTitle}</comment>`;
+        taskAssigneeAccountID !== 0 ? `<comment><mention-user accountid="${taskAssigneeAccountID}"></mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;


Is there any linter warning if we keep 3 lines as before instead of 1 line of code, it's hard to read code for me atm?

It's displayed after I run prettier.

hoangzinh · 2024-01-24T11:12:59Z

@dukenv0307

PR is missing recording native platforms
There is a short period the app shows login email instead of "Hidden" after task is created. Are you able to fix it?

hoangzinh · 2024-01-28T03:58:47Z

Bump @dukenv0307 just in case you missed this PR.

dukenv0307 · 2024-01-28T13:16:42Z

PR is missing recording native platforms

I updated android vide, my IOS simulator is failing.

dukenv0307 · 2024-01-28T13:18:54Z

There is a short period the app shows login email instead of "Hidden" after task is created. Are you able to fix it?

It's a known bug here #31746.

hoangzinh · 2024-01-29T07:32:00Z

Oh no @dukenv0307 Lint code is failed

dukenv0307 · 2024-01-29T07:34:51Z

@hoangzinh I updated, missed to remove us-use import.

hoangzinh · 2024-01-29T07:40:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-06.at.21.35.06.android.mov

Android: mWeb Chrome

Screen.Recording.2024-02-06.at.21.29.19.android.chrome.mov

iOS: Native

Screen.Recording.2024-02-06.at.21.30.42.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-02-06.at.21.33.57.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-06.at.21.24.13.web.mov

MacOS: Desktop

Screen.Recording.2024-02-06.at.21.25.01.desktop.mov

hoangzinh · 2024-01-30T10:08:15Z

@dukenv0307 are you able to reproduce this bug now?

dukenv0307 · 2024-01-30T10:12:59Z

@hoangzinh Still able to reproduce this bug on the latest main.

hoangzinh · 2024-01-30T10:23:24Z

could you share the recording? It looks like BE already returns the login props in personalDetails, so it would display login of the assignee

dukenv0307 · 2024-01-30T11:05:08Z

@hoangzinh The screenshot here. Not sure how BE implements the logic now. For some account it returns personal detail but sometimes it not.

Screen.Recording.2024-01-30.at.18.03.46.mov

hoangzinh · 2024-02-02T11:19:36Z

        const user = lodashGet(personalDetails, htmlAttributeAccountID);
        accountID = parseInt(htmlAttributeAccountID, 10);
-        displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || lodashGet(user, 'displayName', '') || translate('common.hidden');
+        displayNameOrLogin = ReportUtils.getDisplayNameForParticipant(accountID);


it looks like we need to revert this change. I tested a case that:
We have 3 users, UserA, UserB and UserC. UserA and UserB already chatted. But they haven't chatted with UserC

UserA open chat with UserB

UserA create a task, assign to UserC and shared in chat with UserB

Login in UserB and open chat with UserA

With this change, I'm seeing:

But if I visit a task, and then back, it displays "Hidden"

I think it's because of this logic

App/src/libs/ReportUtils.ts

Lines 1615 to 1621 in d5eba65

const formattedLogin = LocalePhoneNumber.formatPhoneNumber(personalDetails.login || '');

// This is to check if account is an invite/optimistically created one

// and prevent from falling back to 'Hidden', so a correct value is shown

// when searching for a new user

if (personalDetails.isOptimisticPersonalDetail === true) {

return formattedLogin;

}

@hoangzinh Thanks for your testing, I reverted.

There are lint errors here. Could you help to recheck? Thanks

@hoangzinh I fixed.

hoangzinh

LGTM, I still reproduce this issue with the email in the GH issue description yonghongkok2+03011@gmail.com

OSBotify · 2024-02-07T10:09:18Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-07T10:25:51Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-08T18:21:09Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-02-14T09:37:21Z

@dukenv0307 @hoangzinh I think this may have caused a regression in #36443. Could you take a look? Thanks!

hoangzinh · 2024-02-14T14:30:31Z

@jjcoffee No, I don't think so. I think it's a regression from https://github.com/Expensify/App/pull/35462/files#diff-a4fc8bbb64960d70ffb3c3d2b6dae62c6881855d6e3c66d9e3b5976441832b3dR42, this PR changed the order

refactor task preview for hidden case

8c802ed

dukenv0307 marked this pull request as ready for review January 24, 2024 04:37

dukenv0307 requested a review from a team as a code owner January 24, 2024 04:37

melvin-bot Bot requested review from hoangzinh and removed request for a team January 24, 2024 04:38

hoangzinh reviewed Jan 24, 2024

View reviewed changes

resolve conflict

bba68ba

fix lint

357ef0c

fix lint

caaf8c1

hoangzinh reviewed Feb 2, 2024

View reviewed changes

dukenv0307 added 3 commits February 6, 2024 01:11

Merge branch 'main' into fix/34052

852c38d

revert change

069e83e

fix lint

03743f7

hoangzinh approved these changes Feb 6, 2024

View reviewed changes

melvin-bot Bot requested a review from grgia February 6, 2024 14:44

grgia approved these changes Feb 6, 2024

View reviewed changes

grgia merged commit ccad061 into Expensify:main Feb 6, 2024

github-actions Bot mentioned this pull request Feb 7, 2024

Deploy Checklist: New Expensify 2024-02-07 #35983

Closed

49 tasks

melvin-bot Bot mentioned this pull request Feb 8, 2024

[HOLD for payment 2024-02-15] [$500] Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat #34052

Closed

6 tasks

fedirjh mentioned this pull request Feb 12, 2024

[HOLD for payment 2024-02-20] [$500] Task – User with the custom name is shown as Hidden in task assignee field #36341

Closed

6 tasks

jjcoffee mentioned this pull request Feb 14, 2024

[$500] Task – Assignee with the custom name is shown as email in a task name #36443

Closed

6 tasks

	const formattedLogin = LocalePhoneNumber.formatPhoneNumber(personalDetails.login \|\| '');
	// This is to check if account is an invite/optimistically created one
	// and prevent from falling back to 'Hidden', so a correct value is shown
	// when searching for a new user
	if (personalDetails.isOptimisticPersonalDetail === true) {
	return formattedLogin;
	}

Uh oh!

Conversation

dukenv0307 commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 24, 2024

Uh oh!

dukenv0307 commented Jan 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jan 24, 2024

Uh oh!

hoangzinh commented Jan 28, 2024

Uh oh!

dukenv0307 commented Jan 28, 2024

Uh oh!

dukenv0307 commented Jan 28, 2024

Uh oh!

hoangzinh commented Jan 29, 2024

Uh oh!

dukenv0307 commented Jan 29, 2024

Uh oh!

hoangzinh commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Jan 30, 2024

Uh oh!

dukenv0307 commented Jan 30, 2024

Uh oh!

hoangzinh commented Jan 30, 2024

Uh oh!

dukenv0307 commented Jan 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

OSBotify commented Feb 8, 2024

Uh oh!

jjcoffee commented Feb 14, 2024

Uh oh!

hoangzinh commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented Jan 24, 2024 •

edited

Loading

hoangzinh commented Jan 29, 2024 •

edited

Loading