Skip to content

IOU requests failing for certain decimal amounts#3429

Merged
iwiznia merged 2 commits into
mainfrom
jules-fixFailedIOUTransaction
Jun 8, 2021
Merged

IOU requests failing for certain decimal amounts#3429
iwiznia merged 2 commits into
mainfrom
jules-fixFailedIOUTransaction

Conversation

@Julesssss

@Julesssss Julesssss commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

Details

IOU requests were failing for certain amounts, due to a Javascript type issue. This PR simply updates the API params to pass the expected amount type (int).

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/166578

Tests

  • Create multiple IOU requests and splits, with the following amounts, in any currency
1.11-1.19
1.22
1.33
2.22
  • Ensure that the IOU Request completes successfully, and you are not presented with an infinite loading spinner

Screenshot 2021-06-08 at 15 13 58

QA Steps

  • Run above tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-06-08 at 15 13 58

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-06-08 at 15 26 53

Desktop

Screenshot 2021-06-08 at 15 29 29

iOS

Simulator Screen Shot - iPhone 11 - 2021-06-08 at 15 24 14

Android

device-2021-06-08-155424

@Julesssss Julesssss self-assigned this Jun 8, 2021
@Julesssss Julesssss requested review from a team and iwiznia June 8, 2021 14:30
@MelvinBot MelvinBot requested review from Gonals and removed request for a team June 8, 2021 14:30
@Julesssss Julesssss marked this pull request as ready for review June 8, 2021 14:38
@Julesssss Julesssss requested a review from a team as a code owner June 8, 2021 14:38
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team June 8, 2021 14:38
@Julesssss Julesssss removed the request for review from stitesExpensify June 8, 2021 14:55
@Julesssss

Copy link
Copy Markdown
Contributor Author

Please ignore that @stitesExpensify!

@iwiznia iwiznia merged commit 0735aa9 into main Jun 8, 2021
@iwiznia iwiznia deleted the jules-fixFailedIOUTransaction branch June 8, 2021 16:05
@OSBotify

OSBotify commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging in version: 1.0.64-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production in version: 1.0.65-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants