Menu auto close#3363
Merged
Merged
Conversation
NikkiWines
requested changes
Jun 7, 2021
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
This looks good. I know this issue only occurred on web/desktop app, but can you add videos for mWeb and iOS, as well as the remaining one for web or desktop (not sure which platform the current video is for since they're under the same heading)
Member
Author
|
@NikkiWines Updated. Thanks |
NikkiWines
requested changes
Jun 7, 2021
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
Looks great, with only a couple of very minor comments.
Member
Author
|
@NikkiWines Updated. Thanks |
Member
Author
|
|
It's a blocker for one of the issues.
9 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.64-5🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.65-0🚀
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Mark as Unread,Copy to ClipboardContextMenu actions.Edit Commentaction.Delete Commentaction via Confirm Modal.Fixed Issues
Fixes #3187
Tests
Copy to clipboard, Menu should close after some time automatically.mark unread. The menu should close after some time automatically.QA Steps (Web/Desktop)
Copy to ClipboardorMark as Unread.QA Steps (M-Web/Android/IOS)
Copy to ClipboardorMark as Unread.Tested On
Screenshots
Web
menu-w.mp4
Desktop
picker-d.mp4
Mobile Web
1623093534388.mp4
iOS
picker-ios.mp4
Android
1622857105728.mp4