Fix/28021: Prevent user from replacing receipt when scanning by DylanDylann · Pull Request #32990 · Expensify/App

DylanDylann · 2023-12-13T17:54:37Z

Details

Web - User B cannot view a scan request money when it is replaced while it is in progress

Fixed Issues

$ #28021
PROPOSAL: #28021 (comment)

Tests

Login with User A account and Open a User B chat.
Navigate to the "Request money" section and select "Scan."
Send a scanned image.
Click on the sent request and go to its details.
Click on the receipt image
Click on the three dot
Verify that there is no option "Replace" when the receipt is scanning.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with User A account and Open a User B chat.
Navigate to the "Request money" section and select "Scan."
Send a scanned image.
Click on the sent request and go to its details.
Click on the receipt image
Click on the three dot
Verify that there is no option "Replace" when the receipt is scanning.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.14-12-2023.01.10.31.webm

Android: mWeb Chrome

Screencast.from.14-12-2023.00.57.01.webm

iOS: Native

iOS: mWeb Safari

Screencast.from.14-12-2023.00.57.01.webm

MacOS: Chrome / Safari

Screencast.from.14-12-2023.00.42.23.webm

MacOS: Desktop

melvin-bot · 2023-12-13T17:54:42Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-12-15T14:52:11Z

Reviewing now

abdulrahuman5196

@DylanDylann

abdulrahuman5196 · 2023-12-15T15:07:11Z

 *
 */
-function canEditFieldOfMoneyRequest(reportAction: OnyxEntry<ReportAction>, reportID: string, fieldToEdit: ValueOf<typeof CONST.EDIT_REQUEST_FIELD>): boolean {
+function canEditFieldOfMoneyRequest(reportAction: OnyxEntry<ReportAction>, reportID: string, fieldToEdit: ValueOf<typeof CONST.EDIT_REQUEST_FIELD>, transaction: Transaction): boolean {


Shouldn't the transaction be optional here?

@DylanDylann Can you check on this?

I will check it today

@abdulrahuman5196 I just added the optional to transaction param.

abdulrahuman5196 · 2023-12-25T12:20:50Z

@DylanDylann Could you kindly update the PR as per the discussion here https://expensify.slack.com/archives/C01GTK53T8Q/p1703093134040619

DylanDylann · 2023-12-26T19:05:58Z

@abdulrahuman5196 I just updated the PR based on your suggestions

abdulrahuman5196 · 2023-12-28T17:32:51Z

@DylanDylann And Kindly also fix the author's checklist which is failing.

Co-authored-by: abdulrahuman5196 <46707890+abdulrahuman5196@users.noreply.github.com>

DylanDylann · 2023-12-29T04:55:48Z

@abdulrahuman5196 I just updated

abdulrahuman5196 · 2023-12-31T07:49:08Z

Reviewing now

abdulrahuman5196 · 2023-12-31T08:48:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-31.at.10.56.38.PM.mp4

Android: mWeb Chrome

Screen.Recording.2023-12-31.at.2.07.48.PM.mp4

iOS: Native

Screen.Recording.2023-12-31.at.1.58.51.PM.mp4

iOS: mWeb Safari

Screen.Recording.2023-12-31.at.2.01.32.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-12-31.at.1.52.53.PM.mp4

MacOS: Desktop

Screen.Recording.2023-12-31.at.1.55.15.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Gonals

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-01-02T14:30:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-02T23:51:16Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T18:53:52Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:18:42Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:16:09Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix prevent user from replacing receipt when scanning

76cb656

DylanDylann requested a review from a team as a code owner December 13, 2023 17:54

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team December 13, 2023 17:54

DylanDylann mentioned this pull request Dec 15, 2023

[HOLD for payment 2024-01-11] [$500] Web - User B cannot view a scan request money when it is replaced while it is in progress #28021

Closed

6 tasks

abdulrahuman5196 suggested changes Dec 15, 2023

View reviewed changes

DylanDylann added 2 commits December 20, 2023 00:54

fix add optional to transaction param

cd3637d

fix lint issue

6d8eb98

fix add OnyxEntry

dcccbd4

abdulrahuman5196 suggested changes Dec 28, 2023

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

fix remove optional from tracsaction param

9735497

Co-authored-by: abdulrahuman5196 <46707890+abdulrahuman5196@users.noreply.github.com>

abdulrahuman5196 approved these changes Dec 31, 2023

View reviewed changes

melvin-bot Bot requested a review from Gonals December 31, 2023 17:35

Gonals approved these changes Jan 2, 2024

View reviewed changes

Gonals merged commit d0b8783 into Expensify:main Jan 2, 2024

github-actions Bot mentioned this pull request Jan 2, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

Uh oh!

Conversation

DylanDylann commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 13, 2023

Uh oh!

abdulrahuman5196 commented Dec 15, 2023

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

DylanDylann Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Dec 25, 2023

Uh oh!

DylanDylann commented Dec 26, 2023

Uh oh!

Uh oh!

abdulrahuman5196 commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Dec 29, 2023

Uh oh!

abdulrahuman5196 commented Dec 31, 2023

Uh oh!

abdulrahuman5196 commented Dec 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DylanDylann commented Dec 13, 2023 •

edited

Loading

abdulrahuman5196 commented Dec 28, 2023 •

edited

Loading

abdulrahuman5196 commented Dec 31, 2023 •

edited

Loading