fix/28562: text input in the Composer disappears by rinej · Pull Request #32799 · Expensify/App

rinej · 2023-12-11T11:28:11Z

Details

Fixed Issues

$ #28562

PROPOSAL:
$ #28562 (comment)

Tests

Same as QA

Offline tests

QA Steps

It should be tested on high traffic account and on android device
In order to simulate low performing device we can change the debounce time as stated here:
#28562 (comment)

Close the app
Open chat
Start typing
Check that no input is lost while typing fast

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web2.mp4

iOS: Native

iOS.mp4

iOS: mWeb Safari

iOS-web.mp4

MacOS: Chrome / Safari

WEB.mp4

MacOS: Desktop

desktop.mp4

github-actions · 2023-12-11T11:28:24Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

rinej · 2023-12-11T12:19:17Z

I have read the CLA Document and I hereby sign the CLA

Julesssss · 2023-12-11T15:17:09Z

Build is in progress ...

OSBotify · 2023-12-11T15:40:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/32799/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://32799.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

melvin-bot · 2023-12-18T09:22:19Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-12-18T09:22:36Z

Oops, i made this open befoe the Author checklist was added. My bad

Julesssss · 2023-12-18T09:22:50Z

@rinej could you please go ahead and prepare this for review?

rinej · 2023-12-18T14:26:41Z

@Julesssss Sure, I am on it

rinej · 2023-12-18T17:01:16Z

@Julesssss the PR is ready for the review

Julesssss · 2023-12-18T17:14:30Z

+        // Adding isWeb check to fix issue on Android, assuming we don't need tab sync on mobiles - https://github.com/Expensify/App/issues/28562
+        const shouldSyncComment = isWeb && prevCommentProp !== comment && value !== comment;


Ah sorry for not mentioning this earlier, but ideally we don't use getPlatform and instead create a specific file for the web-specific code.

allroundexperts · 2023-12-19T04:24:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Uploading Screen Recording 2023-12-22 at 9.54.51 AM.mov…

Android: mWeb Chrome

Screen.Recording.2023-12-22.at.9.52.48.AM.mov

iOS: Native

Screen.Recording.2023-12-22.at.9.52.03.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-22.at.9.51.35.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-22.at.9.44.20.AM.mov

MacOS: Desktop

Screen.Recording.2023-12-22.at.9.47.09.AM.mov

allroundexperts · 2023-12-19T04:25:24Z

Lint errors @rinej!

rinej · 2023-12-20T14:05:09Z

@Julesssss I updated the PR and created specific file for android, so we do not update the comment field when the prev value is different. With that we disable the tab synchronization on android and it fixes the current bug.

@allroundexperts I also fixed the lint errors

Without the fix:
https://github.com/Expensify/App/assets/2650904/b7f20d07-2cba-4152-b915-ff9465dccdd0

After the fix:
https://github.com/Expensify/App/assets/2650904/6c93661b-63f7-4a02-8908-2999a29d0886

Julesssss · 2023-12-21T10:15:54Z

    useEffect(() => {
        // Value state does not have the same value as comment props when the comment gets changed from another tab.
        // In this case, we should synchronize the value between tabs.
+


Please remove unnecessary newline

Julesssss · 2023-12-21T10:19:06Z

Bumping @allroundexperts for C+ review

allroundexperts · 2023-12-21T10:27:06Z

On it today @Julesssss!

rinej · 2023-12-21T11:30:49Z

@Julesssss I noticed that the PR Author Checklist failed, even though I have checked all checkboxes. Should I add some additional ones?

Julesssss · 2023-12-21T13:24:02Z

@Julesssss I noticed that the PR Author Checklist failed, even though I have checked all checkboxes. Should I add some additional ones?

Hmm, maybe the checklist was just updated... We can ignore

allroundexperts

Looks good!

rinej · 2023-12-22T11:49:21Z

@Julesssss how can we move forward with the PR?

Julesssss · 2024-01-04T09:49:18Z

@Julesssss how can we move forward with the PR?

I was awaiting final C+ approval, then was OOO. Approving now

OSBotify · 2024-01-04T09:53:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-04T19:03:12Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:10:49Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-09T05:19:29Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: add isWeb check for tab syncing

0fc7eb3

rinej mentioned this pull request Dec 11, 2023

[$1500] Android - Text input in the compose box disappears/reappears erratically when typing a message immediately after launching the app #28562

Closed

6 tasks

Julesssss assigned rinej Dec 11, 2023

Julesssss added the Ready To Build label Dec 11, 2023

Julesssss marked this pull request as ready for review December 18, 2023 09:22

Julesssss requested a review from a team as a code owner December 18, 2023 09:22

melvin-bot Bot requested review from allroundexperts and removed request for a team December 18, 2023 09:22

rinej added 2 commits December 18, 2023 16:35

fix: fix linter

9d9e958

Merge branch 'main' into fix/28562-android-input-dissapears

d539ad7

rinej marked this pull request as draft December 18, 2023 17:00

rinej marked this pull request as ready for review December 18, 2023 17:00

Julesssss reviewed Dec 18, 2023

View reviewed changes

rinej added 4 commits December 19, 2023 13:57

Merge branch 'main' into fix/28562-android-input-dissapears

5d40bc4

fix: fix prettier

d7f5af4

Merge branch 'main' into fix/28562-android-input-dissapears

3a84db5

refactor: add android file for SilentCommentUpdate

e91d79d

rinej requested a review from Julesssss December 21, 2023 09:10

Julesssss reviewed Dec 21, 2023

View reviewed changes

refactor: format fix

44ef921

rinej requested a review from Julesssss December 21, 2023 10:25

allroundexperts approved these changes Dec 22, 2023

View reviewed changes

Julesssss approved these changes Jan 4, 2024

View reviewed changes

Julesssss merged commit 3b424bb into Expensify:main Jan 4, 2024

github-actions Bot mentioned this pull request Jan 4, 2024

Deploy Checklist: New Expensify 2024-01-04 #33973

Closed

74 tasks

bernhardoj mentioned this pull request May 3, 2024

[HOLD for payment 2024-06-05] [$250] Android - Composer - Draft text reappears after clearing the compose box and navigating back #41499

Closed

6 tasks

		// Adding isWeb check to fix issue on Android, assuming we don't need tab sync on mobiles - https://github.com/Expensify/App/issues/28562
		const shouldSyncComment = isWeb && prevCommentProp !== comment && value !== comment;

Conversation

rinej commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rinej commented Dec 11, 2023

Uh oh!

Julesssss commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

melvin-bot Bot commented Dec 18, 2023

Uh oh!

Julesssss commented Dec 18, 2023

Uh oh!

Julesssss commented Dec 18, 2023

Uh oh!

rinej commented Dec 18, 2023

Uh oh!

rinej commented Dec 18, 2023

Uh oh!

Julesssss Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Dec 19, 2023

Uh oh!

rinej commented Dec 20, 2023

Uh oh!

Julesssss Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

rinej Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Dec 21, 2023

Uh oh!

allroundexperts commented Dec 21, 2023

Uh oh!

rinej commented Dec 21, 2023

Uh oh!

Julesssss commented Dec 21, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

rinej commented Dec 22, 2023

Uh oh!

Julesssss commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rinej commented Dec 11, 2023 •

edited

Loading

github-actions Bot commented Dec 11, 2023 •

edited

Loading

Julesssss Dec 18, 2023 •

edited

Loading

allroundexperts commented Dec 19, 2023 •

edited

Loading