Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ module.exports = {
'rulesdir/prefer-underscore-method': 'off',
'rulesdir/prefer-import-module-contents': 'off',
'react/require-default-props': 'off',
'react/prop-types': 'off',
'no-restricted-syntax': [
'error',
{
Expand Down
25 changes: 0 additions & 25 deletions src/components/HeaderGap/index.desktop.js

This file was deleted.

13 changes: 13 additions & 0 deletions src/components/HeaderGap/index.desktop.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import React, {memo} from 'react';
import {View} from 'react-native';
import useThemeStyles from '@styles/useThemeStyles';
import type {HeaderGapProps, HeaderGapReturnType} from './types';

function HeaderGap({styles}: HeaderGapProps): HeaderGapReturnType {
const themeStyles = useThemeStyles();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const themeStyles = useThemeStyles();
const themeStyles = useThemeStyles();

return <View style={[themeStyles.headerGap, styles]} />;
}

HeaderGap.displayName = 'HeaderGap';

export default memo(HeaderGap);
6 changes: 0 additions & 6 deletions src/components/HeaderGap/index.js

This file was deleted.

10 changes: 10 additions & 0 deletions src/components/HeaderGap/index.tsx
Comment thread
SzymczakJ marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import type {HeaderGapProps, HeaderGapReturnType} from './types';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
function HeaderGap({styles}: HeaderGapProps): HeaderGapReturnType {
return null;
}

HeaderGap.displayName = 'HeaderGap';

export default HeaderGap;
10 changes: 10 additions & 0 deletions src/components/HeaderGap/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import {ReactNode} from 'react';
import {StyleProp, ViewStyle} from 'react-native';

type HeaderGapProps = {
styles?: StyleProp<ViewStyle>;
};

type HeaderGapReturnType = ReactNode;

export type {HeaderGapProps, HeaderGapReturnType};
4 changes: 2 additions & 2 deletions src/components/SplashScreenHider/index.native.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import Reanimated, {Easing, runOnJS, useAnimatedStyle, useSharedValue, withTimin
import Logo from '@assets/images/new-expensify-dark.svg';
import BootSplash from '@libs/BootSplash';
import useThemeStyles from '@styles/useThemeStyles';
import type SplashScreenHiderProps from './types';
import type {SplashScreenHiderProps, SplashScreenHiderReturnType} from './types';

function SplashScreenHider({onHide = () => {}}: SplashScreenHiderProps) {
function SplashScreenHider({onHide = () => {}}: SplashScreenHiderProps): SplashScreenHiderReturnType {
const styles = useThemeStyles();
const logoSizeRatio = BootSplash.logoSizeRatio || 1;
const navigationBarHeight = BootSplash.navigationBarHeight || 0;
Expand Down
4 changes: 2 additions & 2 deletions src/components/SplashScreenHider/index.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {useEffect} from 'react';
import BootSplash from '@libs/BootSplash';
import type SplashScreenHiderProps from './types';
import type {SplashScreenHiderProps, SplashScreenHiderReturnType} from './types';

function SplashScreenHider({onHide = () => {}}: SplashScreenHiderProps) {
function SplashScreenHider({onHide = () => {}}: SplashScreenHiderProps): SplashScreenHiderReturnType {
useEffect(() => {
BootSplash.hide().then(() => onHide());
}, [onHide]);
Expand Down
6 changes: 5 additions & 1 deletion src/components/SplashScreenHider/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import {ReactNode} from 'react';

type SplashScreenHiderProps = {
/** Splash screen has been hidden */
onHide: () => void;
};

export default SplashScreenHiderProps;
type SplashScreenHiderReturnType = ReactNode;

export type {SplashScreenHiderProps, SplashScreenHiderReturnType};