fix reposition of popover when window resize by ishpaul777 · Pull Request #32492 · Expensify/App

ishpaul777 · 2023-12-05T15:47:11Z

Details

Fixed Issues

$ #31706
PROPOSAL: #31706 (comment)

Tests

Verify that no errors appear in the JS console
Same as QA steps

Offline tests

QA Steps

Verify that no errors appear in the JS console

Preconditon - have atleast a bank account added.

Go to Wallet page,
Click "Add Bank Account"
Resize window , make sure the popover repositions with window size.
Click Bank account
Resize window , make sure the popover repositions with window size.

PR Author Checklist

Screenshots/Videos

Android: Native

N/a window cant be resized

Android: mWeb Chrome

N/a window cant be resized

iOS: Native

N/a window cant be resized

iOS: mWeb Safari

N/a window cant be resized

MacOS: Chrome / Safari

Screen.Recording.2023-12-05.at.10.30.04.PM-1.mov

MacOS: Desktop

Screen.Recording.2023-12-05.at.11.12.27.PM-1.mov

melvin-bot · 2023-12-06T20:42:48Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2023-12-11T17:05:06Z

gentle bump @akinwale for review

akinwale · 2023-12-13T11:27:44Z

gentle bump @akinwale for review

Apologies for the delay. I will review today.

akinwale · 2023-12-14T08:44:33Z

Reviewing now. @ishpaul777 Please resolve merge conflicts.

akinwale · 2023-12-14T08:45:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

32492-web.mp4

MacOS: Desktop

32492-desktop.mp4

akinwale · 2023-12-14T09:17:51Z

@ishpaul777 The repositioning doesn't seem to be working properly on web and desktop when I drag the window to resize. Please check this. See attached video.

32492-desktop-bug.mp4

ishpaul777 · 2023-12-15T11:18:02Z

I am not able to reproduce this, sometimes when there is a delay in app layout resizing and popover get its position sligtly wrong because it's present at right most part of app and because of delay there's space (white space if you notice) available in window as popover position is absolute to widow, i guess this a performance issue depend on user device or browser performace.

Screen.Recording.2023-12-15.at.4.24.29.PM.mov

Screen.Recording.2023-12-15.at.4.30.18.PM.mov

ishpaul777 · 2023-12-15T12:06:15Z

@akinwale Can you check if its better that before i used useLayoutEffect instead useEffect.

Screen.Recording.2023-12-15.at.5.34.01.PM.mov

Screen.Recording.2023-12-15.at.5.26.27.PM.mov

akinwale · 2023-12-19T03:28:50Z

@ishpaul777 I'm still seeing the same issue when dragging the window. The issue is not solved until we can ensure that the popover is properly repositioned after the window resize is complete, since that is the main goal here.

ishpaul777 · 2023-12-19T21:23:14Z

@akinwale Actually it does if you see #32492 (comment), i am not able to reproduce like #32492 (comment)....

any ideas what might be wrong with code because i follow the standard pattern we use across all popovers, nothing fancy?

akinwale · 2024-01-01T14:26:09Z

@ishpaul777 I have tested again on a different machine with better performance and it looks like the issue is solved. Please fix merge conflicts so that I can approve. Thanks.

ishpaul777 · 2024-01-01T16:52:48Z

Thanks @akinwale Glad that it's resolved I'll do that As soon as i am with my machine 💻(in few hours or by tomorrow)

…x/31706

akinwale · 2024-01-02T07:34:55Z

@ishpaul777 Looks like the PR author checklist was updated. You can update the first post with the updated checklist from https://github.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md.

akinwale

LGTM

OSBotify · 2024-01-02T22:33:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-02T23:51:07Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T18:53:43Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:18:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:16:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

shubham1206agra · 2025-06-14T13:33:40Z

        }
-        setMenuPosition();
-    }, [shouldListenForResize, setMenuPosition]);
+        const popoverPositionListener = Dimensions.addEventListener('change', () => {


This change caused some de-sync between dimension calculation when resized quickly, which caused #61801

ishpaul777 and others added 2 commits December 5, 2023 21:10

fix reposition of popover when window resize

cd7f52b

Merge branch 'Expensify:main' into fix/31706

5432fa8

ishpaul777 marked this pull request as ready for review December 6, 2023 20:42

ishpaul777 requested a review from a team as a code owner December 6, 2023 20:42

melvin-bot Bot requested review from akinwale and removed request for a team December 6, 2023 20:42

Merge branch 'main' into fix/31706

25dd13d

Merge branch 'Expensify:main' into fix/31706

de89322

replace useEffect with useLayoutEffect

4452a16

remove console statement

90ad8ba

ishpaul777 and others added 3 commits January 2, 2024 11:57

Merge branch 'main' into fix/31706

4381515

FIX conflicts

8e17db4

Merge branch 'fix/31706' of https://github.com/ishpaul777/App into fi…

62588ea

…x/31706

akinwale approved these changes Jan 2, 2024

View reviewed changes

melvin-bot Bot requested a review from francoisl January 2, 2024 07:42

francoisl approved these changes Jan 2, 2024

View reviewed changes

francoisl merged commit 33ff94c into Expensify:main Jan 2, 2024

github-actions Bot mentioned this pull request Jan 2, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

melvin-bot Bot mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-01-11] [$500] Wallet - The popup moves to the side if the page is resized #31706

Closed

6 tasks

shubham1206agra reviewed Jun 14, 2025

View reviewed changes

Uh oh!

Conversation

ishpaul777 commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 6, 2023

Uh oh!

ishpaul777 commented Dec 11, 2023

Uh oh!

akinwale commented Dec 13, 2023

Uh oh!

akinwale commented Dec 14, 2023

Uh oh!

akinwale commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale commented Dec 14, 2023

Uh oh!

ishpaul777 commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Dec 15, 2023

Uh oh!

akinwale commented Dec 19, 2023

Uh oh!

ishpaul777 commented Dec 19, 2023

Uh oh!

akinwale commented Jan 1, 2024

Uh oh!

ishpaul777 commented Jan 1, 2024

Uh oh!

akinwale commented Jan 2, 2024

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

shubham1206agra Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ishpaul777 commented Dec 5, 2023 •

edited

Loading

akinwale commented Dec 14, 2023 •

edited

Loading

ishpaul777 commented Dec 15, 2023 •

edited

Loading