Skip to content

fix(get physical card): bad margins affecting personal details addres… #31759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Nov 28, 2023
Merged

fix(get physical card): bad margins affecting personal details addres… #31759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eaced1
fix(get physical card): bad margins affecting personal details addres…
pac-guerreiro Nov 22, 2023
4fdf3a5
Merge branch 'main' into fix/personal-details-extra-padding-address-l…
pac-guerreiro Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/AddressForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ function AddressForm({city, country, formID, onAddressChanged, onSubmit, shouldS
submitButtonText={submitButtonText}
enabledWhenOffline
>
<View style={styles.formSpaceVertical} />
<View>
<AddressSearch
inputID="addressLine1"
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Wallet/Card/BaseGetPhysicalCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ function BaseGetPhysicalCard({
title={title}
onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(domain))}
/>
<Text style={[styles.textHeadline, styles.mh5]}>{headline}</Text>
<Text style={[styles.textHeadline, styles.mh5, styles.mb5]}>{headline}</Text>
{renderContent(onSubmit, submitButtonText, children, onValidate)}
</ScreenWrapper>
);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Wallet/Card/GetPhysicalCardConfirm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function GetPhysicalCardConfirm({
submitButtonText={translate('getPhysicalCard.shipCard')}
title={translate('getPhysicalCard.header')}
>
<Text style={[styles.baseFontStyle, styles.mv5, styles.mh5]}>{translate('getPhysicalCard.estimatedDeliveryMessage')}</Text>
<Text style={[styles.baseFontStyle, styles.mb5, styles.mh5]}>{translate('getPhysicalCard.estimatedDeliveryMessage')}</Text>
<MenuItemWithTopDescription
description={translate('getPhysicalCard.legalName')}
iconRight={Expensicons.ArrowRight}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Wallet/Card/GetPhysicalCardName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function GetPhysicalCardName({
role={CONST.ACCESSIBILITY_ROLE.TEXT}
autoCapitalize="words"
defaultValue={legalFirstName}
containerStyles={[styles.mt5, styles.mh5]}
containerStyles={[styles.mh5]}
shouldSaveDraft
/>
<TextInput
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Wallet/Card/GetPhysicalCardPhone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function GetPhysicalCardPhone({
aria-label={translate('getPhysicalCard.phoneNumber')}
role={CONST.ACCESSIBILITY_ROLE.TEXT}
defaultValue={phoneNumber}
containerStyles={[styles.mt5, styles.mh5]}
containerStyles={[styles.mh5]}
shouldSaveDraft
/>
</BaseGetPhysicalCard>
Expand Down