fix link to the referral program details#31574
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@luacmartins All yours! 🚀 |
Reviewer Checklist
Screenshots/VideosN/A updating external URL const Android: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
fix link to the referral program details (cherry picked from commit 278f307)
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.1-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.1-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀
|
Details
Fixed Issues
$ #31567
PROPOSAL: #31567 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-21.at.12.48.14.AM.mov
Android: mWeb Chrome
Record_2023-11-21-00-38-59.mp4
iOS: Native
Screen.Recording.2023-11-21.at.12.10.53.AM.mov
iOS: mWeb Safari
Screen.Recording.2023-11-21.at.12.11.47.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-21.at.12.08.15.AM.mov
MacOS: Desktop
Screen.Recording.2023-11-21.at.12.23.51.AM.mov