Migrate EmojiPickerMenu to FlashList by TMisiukiewicz · Pull Request #31479 · Expensify/App

TMisiukiewicz · 2023-11-17T09:26:04Z

Details

Migrating EmojiPickerMenu to FlashList for both Web and Mobile

Fixed Issues

$ #30911
PROPOSAL:

Tests

Open emoji picker
Scroll the list
Press the emojis category on the top and verify it scrolls to the category
Change skin tone and verify it changed in the emoji list
Type "aaa" in search bar and verify no results message is displayed
Type "a" in search bar and verify filtered list scrolls

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Open emoji picker
Scroll the list
Press the emojis category on the top and verify it scrolls to the category
Change skin tone and verify it changed in the emoji list
Type "aaa" in search bar and verify no results message is displayed
Type "a" in search bar and verify filtered list scrolls

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

ANDROID_WEB.mov

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS_WEB.mp4

MacOS: Chrome / Safari

WEB.mov

MacOS: Desktop

DESKTOP.mov

melvin-bot · 2023-11-17T10:57:23Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jakub-trzebiatowski · 2023-11-20T13:14:15Z

Exception:

emojipicker-flashlist-migration-ios.mp4

TMisiukiewicz · 2023-11-20T14:14:28Z

@cubuspl42 thanks for testing, I addressed both of your comments

TMisiukiewicz · 2023-11-22T11:28:57Z

hi @cubuspl42, did you have a chance to take another look on this PR?

jakub-trzebiatowski · 2023-11-22T11:50:12Z

@TMisiukiewicz I will; I have a personal situation that affects my capacity. Everything will be back to normal after Friday. Is this urgent or conflict-prone?

TMisiukiewicz · 2023-11-22T12:00:31Z

@cubuspl42 no worries, it can wait until you are back!

TMisiukiewicz · 2023-11-29T10:03:58Z

hi @cubuspl42, will you find some time to check this PR this week? 🙏

jakub-trzebiatowski · 2023-11-29T10:21:20Z

@TMisiukiewicz I'll do this right now, thank you for reminding ♡

jakub-trzebiatowski · 2023-11-29T10:27:13Z

Please also merge main

jakub-trzebiatowski

Left one comment, otherwise things look good!

TMisiukiewicz · 2023-11-29T10:41:17Z

main has been merged ✅

jakub-trzebiatowski

👍

roryabraham

Also please investigate what can be DRYed up between the web and mobile implementations, creating a Base component if necessary

TMisiukiewicz · 2023-12-01T13:37:36Z

@roryabraham thanks for your review - created a Base component to share some parts of it across platforms and also extracted the common functions, where possible. Mind taking a look once again?

…ashlist-migration

TMisiukiewicz · 2023-12-18T14:37:30Z

@roryabraham thanks for your eagle-eye reviews! Really appreciate all the stuff you keep findind and your knowledge of the project. I addressed your comments and fixed the flicker on the initial list render I mentioned on Friday

roryabraham

Thanks for all your work on this. It's much better than it was. I do want us to follow-up with a PR to build support for ArrowLeft and ArrowRight in useArrowKeyFocusManager as that will further reduce platform differences between these files, I believe to the point where everything can be recombined into a single component.

roryabraham · 2023-12-20T23:34:36Z

@cubuspl42 there have been a lot of changes here since your last review. Can you please review and test again before I merge this? I see the reviewer checklist is failing, maybe try again with a fresh checklist?

TMisiukiewicz · 2023-12-21T08:08:22Z

thanks for your review @roryabraham! Can we create an issue for supporting ArrowLeft and ArrowRight in useArrowKeyFocusManager? Christmas break is very close and just want to make sure once we are back from holidays, me or other Callstack folk could pick this up

jakub-trzebiatowski · 2023-12-21T12:01:26Z

@TMisiukiewicz Would you merge main? We're >600 commits behind

TMisiukiewicz · 2023-12-21T12:25:16Z

@cubuspl42 whoops that's a pretty big number, updated!

jakub-trzebiatowski · 2023-12-21T12:27:37Z

main goes forward fast, it's easy to get >1000

Too big diversion can result in lint issues and other problems, that's why C+ often remind about merging

jakub-trzebiatowski · 2023-12-21T14:39:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

flashlist-web.mp4

Mobile Web - Chrome

flashlist-android-web-compressed.mp4

Mobile Web - Safari

flashlist-ios-web.mp4

Desktop

iOS

flashlist-ios.mp4

Android

flashlist-android-compressed.mp4

jakub-trzebiatowski

I re-tested, and things still work cross-platform!

OSBotify · 2023-12-22T18:10:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-26T00:37:30Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

mountiny · 2023-12-26T14:28:38Z

+// On windows, flag emojis are not supported
+const emojisForOperatingSystem =
+    getOperatingSystem() === CONST.OS.WINDOWS
+        ? emojis.slice(
+              0,
+              emojis.findIndex((emoji) => {
+                  if (!('header' in emoji)) {
+                      return;
+                  }
+
+                  return emoji.header && emoji.code === 'flags';
+              }),
+          )
+        : emojis;


@TMisiukiewicz This was implemented during the time you have worked on this PR but we have added the support for flag emojis on Windows in this issues and pr #31717

There was this issue raised here #33593, if you could comment on it so I can assign you and you could make a follow up to remove this Windows specific code. thanks!

OSBotify · 2023-12-27T16:10:33Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.17-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rushatgabhane · 2024-01-30T01:20:59Z

+
+            if (item.header) {
+                return (
+                    <View style={[styles.emojiHeaderContainer, target === 'StickyHeader' ? styles.mh4 : {width: windowWidth}]}>


Coming from #33709 (comment)

We had a bug here scroll not working over header.
RCA: emoji header is wrapped in an absolute container and overlaps with scroll bar

shubham1206agra · 2024-03-15T01:45:25Z

-                    {overflowY: filteredEmojis.length > overflowLimit ? 'auto' : 'hidden'},
                    // Set scrollPaddingTop to consider sticky headers while scrolling
-                    {scrollPaddingTop: isFiltered ? 0 : CONST.EMOJI_PICKER_ITEM_HEIGHT},
+                    {scrollPaddingTop: isListFiltered ? 0 : CONST.EMOJI_PICKER_ITEM_HEIGHT},


This line is applied at the wrong place, which created #36883

barttom reviewed Nov 17, 2023

View reviewed changes

Comment thread src/components/EmojiPicker/EmojiPickerMenu/index.js Outdated

Comment thread src/components/EmojiPicker/EmojiPickerMenu/index.native.js Outdated

fabioh8010 reviewed Nov 17, 2023

View reviewed changes

Comment thread src/components/EmojiPicker/EmojiPickerMenu/index.js Outdated

Comment thread src/components/EmojiPicker/EmojiPickerMenu/index.native.js Outdated

TMisiukiewicz marked this pull request as ready for review November 17, 2023 10:57

TMisiukiewicz requested a review from a team as a code owner November 17, 2023 10:57

melvin-bot Bot requested review from jakub-trzebiatowski and removed request for a team November 17, 2023 10:57

jakub-trzebiatowski reviewed Nov 20, 2023

View reviewed changes

Comment thread src/components/EmojiPicker/EmojiPickerMenu/index.js Outdated

TMisiukiewicz force-pushed the feat/emojipicker-flashlist-migration branch from 4f41024 to a55a640 Compare November 20, 2023 14:13

jakub-trzebiatowski reviewed Nov 29, 2023

View reviewed changes

Comment thread src/components/EmojiPicker/EmojiPickerMenu/getItemType.js Outdated

jakub-trzebiatowski suggested changes Nov 29, 2023

View reviewed changes

TMisiukiewicz force-pushed the feat/emojipicker-flashlist-migration branch from a55a640 to 62d795e Compare November 29, 2023 10:41

jakub-trzebiatowski approved these changes Nov 29, 2023

View reviewed changes

melvin-bot Bot requested a review from roryabraham November 29, 2023 12:32

roryabraham requested changes Nov 30, 2023

View reviewed changes

TMisiukiewicz force-pushed the feat/emojipicker-flashlist-migration branch 2 times, most recently from 0a85015 to b482d91 Compare December 1, 2023 09:36

TMisiukiewicz requested a review from roryabraham December 1, 2023 13:20

TMisiukiewicz force-pushed the feat/emojipicker-flashlist-migration branch 2 times, most recently from 1b1f5de to 2d96196 Compare December 4, 2023 14:55

TMisiukiewicz added 3 commits December 18, 2023 13:22

Merge remote-tracking branch 'upstream/main' into feat/emojipicker-fl…

46a24a6

…ashlist-migration

add estimatedListSize to emoji picker menu

46177ef

update getEmojiPickerListHeight

7c774f9

TMisiukiewicz requested a review from roryabraham December 18, 2023 14:34

adhorodyski mentioned this pull request Dec 18, 2023

SearchPage list refactor #33080

Merged

46 tasks

roryabraham approved these changes Dec 20, 2023

View reviewed changes

roryabraham requested a review from jakub-trzebiatowski December 20, 2023 23:34

Merge branch 'main' into feat/emojipicker-flashlist-migration

6b555d0

jakub-trzebiatowski approved these changes Dec 21, 2023

View reviewed changes

melvin-bot Bot requested a review from roryabraham December 21, 2023 14:40

roryabraham merged commit e89e466 into Expensify:main Dec 22, 2023

github-actions Bot mentioned this pull request Dec 26, 2023

Deploy Checklist: New Expensify 2023-12-26 #33576

Closed

42 tasks

mkhutornyi mentioned this pull request Dec 26, 2023

[HOLD for payment 2024-01-04] [$125] Web - Emoji - Flag emoji category is missing #33593

Closed

6 tasks

mountiny reviewed Dec 26, 2023

View reviewed changes

melvin-bot Bot mentioned this pull request Dec 27, 2023

[$500] [MEDIUM] Migrate the EmojiPickerMenu to Flashlist #30911

Closed

samilabud mentioned this pull request Jan 17, 2024

[$250] Android - Chat - Emoji list in the emoji picker is misaligned #34522

Closed

6 tasks

rushatgabhane reviewed Jan 30, 2024

View reviewed changes

rushatgabhane mentioned this pull request Jan 30, 2024

[RUSHAT to complete checklist] [$500] Web - Emoji picker - Holding down on scroll bar and sliding down selects emoji instead of scrolling #33709

Closed

6 tasks

Pujan92 mentioned this pull request Feb 21, 2024

[HOLD for payment 2024-03-14] [$500] Emoji picker - Highlight is removed from emoji when scrolling up with up key #36883

Closed

6 tasks

shubham1206agra reviewed Mar 15, 2024

View reviewed changes

Conversation

TMisiukiewicz commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Nov 17, 2023

Uh oh!

Uh oh!

jakub-trzebiatowski commented Nov 20, 2023

Uh oh!

TMisiukiewicz commented Nov 20, 2023

Uh oh!

TMisiukiewicz commented Nov 22, 2023

Uh oh!

jakub-trzebiatowski commented Nov 22, 2023

Uh oh!

TMisiukiewicz commented Nov 22, 2023

Uh oh!

TMisiukiewicz commented Nov 29, 2023

Uh oh!

jakub-trzebiatowski commented Nov 29, 2023

Uh oh!

Uh oh!

jakub-trzebiatowski commented Nov 29, 2023

Uh oh!

jakub-trzebiatowski left a comment

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz commented Nov 29, 2023

Uh oh!

jakub-trzebiatowski left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TMisiukiewicz commented Dec 1, 2023

Uh oh!

TMisiukiewicz commented Dec 18, 2023

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Dec 20, 2023

Uh oh!

TMisiukiewicz commented Dec 21, 2023

Uh oh!

jakub-trzebiatowski commented Dec 21, 2023

Uh oh!

TMisiukiewicz commented Dec 21, 2023

Uh oh!

jakub-trzebiatowski commented Dec 21, 2023

Uh oh!

jakub-trzebiatowski commented Dec 21, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

jakub-trzebiatowski left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 22, 2023

Uh oh!

OSBotify commented Dec 26, 2023

Uh oh!

mountiny Dec 26, 2023

TMisiukiewicz commented Nov 17, 2023 •

edited

Loading