fix: double tap on currency selects AFN by BhuvaneshPatil · Pull Request #31225 · Expensify/App

BhuvaneshPatil · 2023-11-11T11:14:02Z

Details

Fixed Issues

$ #30508
PROPOSAL: #30508 (comment)

Tests

Go to Create money request flow
On amount page, click on currency symbol multiple times
Verify if currency is selected only after the page has transitioned and user selects the currency

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Screen.Recording.2023-11-14.at.2.38.01.PM.mov

iOS: Native

Screen.Recording.2023-11-10.at.3.19.49.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-14.at.4.39.32.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-14.at.4.50.15.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-14.at.4.47.07.PM.mov

melvin-bot · 2023-11-11T11:14:07Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2023-11-13T18:28:09Z

@BhuvaneshPatil could you please complete the checklist?

BhuvaneshPatil · 2023-11-13T18:31:56Z

@getusha
Sure, I had some network issue so it was failing to upload.

BhuvaneshPatil · 2023-11-14T11:23:12Z

@getusha Uploaded the videos
and completed checklist

getusha · 2023-11-15T14:30:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-15.at.8.06.38.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-15.at.6.03.56.PM.mov

iOS: Native

Screen.Recording.2023-11-15.at.6.30.41.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-15.at.5.48.07.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-15.at.5.45.03.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-15.at.7.05.25.PM.mov

getusha

Looks good to me and works well!

getusha · 2023-11-15T17:11:22Z

@BhuvaneshPatil seems like your checklist is outdated, mind checking https://github.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md?

amyevans

Code looks good but yes let's get the author checklist passing so that we don't have to merge with failing tests

BhuvaneshPatil · 2023-11-16T12:46:03Z

I copied the check list and updated it, not sure why it's still failing

…uble-tap-issue

BhuvaneshPatil · 2023-11-16T13:21:39Z

Updated with main and seems to be working.

OSBotify · 2023-11-16T14:35:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2023-11-21T15:19:57Z

Ignore me, I'm just building this PR to verify whether this follow up PR introduced a regression

OSBotify · 2023-11-21T15:42:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/31225/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/31225/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/31225/NewExpensify.dmg	https://31225.pr-testing.expensify.com

OSBotify · 2023-11-22T00:50:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: double tap on currency selects AFN

d8b9866

BhuvaneshPatil requested a review from a team as a code owner November 11, 2023 11:14

melvin-bot Bot removed the request for review from a team November 11, 2023 11:14

melvin-bot Bot requested a review from getusha November 11, 2023 11:14

getusha approved these changes Nov 15, 2023

View reviewed changes

melvin-bot Bot requested a review from amyevans November 15, 2023 17:08

amyevans approved these changes Nov 15, 2023

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into 30508-do…

3fbdf32

…uble-tap-issue

amyevans merged commit 1deced4 into Expensify:main Nov 16, 2023

os-botify Bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

Julesssss added the Ready To Build label Nov 21, 2023

Julesssss mentioned this pull request Nov 21, 2023

Migrate LHNOptionsList to Flashlist #31052

Merged

58 tasks

melvin-bot Bot mentioned this pull request Nov 22, 2023

[HOLD for payment 2023-11-29] [$500] mWeb - AFN currency appears when double tapping currency in BNP page. #30508

Closed

6 tasks

ishpaul777 mentioned this pull request Nov 22, 2023

[$500] IOU - Blue box surrounding the currency after the currency selection #31687

Closed

6 tasks

Uh oh!

Conversation

BhuvaneshPatil commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 11, 2023

Uh oh!

getusha commented Nov 13, 2023

Uh oh!

BhuvaneshPatil commented Nov 13, 2023

Uh oh!

BhuvaneshPatil commented Nov 14, 2023

Uh oh!

getusha commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

getusha commented Nov 15, 2023

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

BhuvaneshPatil commented Nov 16, 2023

Uh oh!

BhuvaneshPatil commented Nov 16, 2023

Uh oh!

OSBotify commented Nov 16, 2023

Uh oh!

Julesssss commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Nov 21, 2023

Uh oh!

OSBotify commented Nov 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BhuvaneshPatil commented Nov 11, 2023 •

edited

Loading

getusha commented Nov 15, 2023 •

edited

Loading

Julesssss commented Nov 21, 2023 •

edited

Loading