[TS migration] Migrate 'FormElement.js' component to TypeScript by kubabutkiewicz · Pull Request #31012 · Expensify/App

kubabutkiewicz · 2023-11-07T16:47:12Z

Details

Fixed Issues

$ #24973

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go through sign in flow
Verify if everything works

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…s-migration/FormElement/component

melvin-bot · 2023-11-07T16:47:16Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…s-migration/FormElement/component

kubabutkiewicz · 2023-11-07T17:17:10Z

Removed accessibilityAutoComplete='on' since on is not supported value, let me know if you have more insight why this was added because now for me it seems that it's not doing anything

barttom · 2023-11-07T17:31:47Z

+    );
+}
+
+FormElement.displayName = 'BaseForm';


is it a proper displayName? Doesn't follow file name

It was here before so I am not sure if this should be changed in TS migration

If you take a look at blame here they must've missed it.

Let's change it to 'FormElement' to follow the guidelines, other than that LGTM!

barttom · 2023-11-07T17:32:26Z

+    return (
+        <View
+            role={ComponentUtils.ACCESSIBILITY_ROLE_FORM}
+            ref={ref as LegacyRef<View>}


can we use the same type to avoid assertion?

Also, could you clarify please why do you use LegacyRef here and why ref is defined as ForwardedRef<View | HTMLFormElement | null>?

VickyStash · 2023-11-07T17:36:47Z

+    return (
+        <View
+            role={ComponentUtils.ACCESSIBILITY_ROLE_FORM}
+            ref={ref as LegacyRef<View>}


Also, could you clarify please why do you use LegacyRef here and why ref is defined as ForwardedRef<View | HTMLFormElement | null>?

kubabutkiewicz · 2023-11-08T09:54:59Z

@VickyStash Actually there should be a type of ForwardedRef<View> this is adjusted. But I am doing assertion here because in SignInPageForm we are passing the ref of type HTMLFormElement but we can pass this type to the View ref thats why there is an assertion

This reverts commit 78a09b7.

…s-migration/FormElement/component

This reverts commit 78a09b7.

barttom · 2023-11-08T10:22:04Z

+    return (
+        <View
+            role={ComponentUtils.ACCESSIBILITY_ROLE_FORM}
+            ref={ref as ForwardedRef<View>}


still don't get it why You need assertion here and why this assertion is different then defined ref in property. Could You explain?

Sure , here which is SignInFormPage for web platform

we are passing ref of type HTMLFormElement
but in FormElement we are using View where View expect ref to be a type of View

Thats why we I need to assert it

The typing situation here is quite terrible. In React Native for Web, View component with role={ComponentUtils.ACCESSIBILITY_ROLE_FORM} will be backed by a HTMLFormElement (which we can access through the ref), while neither HTMLFormElement is a subtype of View nor the other way around. In runtime, though, if I remember correctly, React Native for Web will patch the returned element, so in practice we could say that it does conform to the View API.

It doesn't help that in TypeScript Object1 is assignable to Object2 in such scenario:

interface Object1 { prop1: boolean; } interface Object2 { prop1: string | number; }

...which is fundamentally unsound, as we can put a 123 inside prop1 of Object1 through an Object2 reference without a single type assertion. I wasn't fully aware about this until today.

This adds another layer of a mess to our situation, as you should't even be allowed to pass MutableRefObject<HTMLFormElement> to ForwardRef<HTMLFormElement | View>.

I won't even start about how most refs don't even end-up being mutable, although they always should be, type-wise.

Having said all that, I think we add even more terrible typing to a pile of terrible typing.

I would just stick with ForwardRef<View> in FormElement and cast once on the use-site (SignInPageForm):

const formViewRef = useRef<View | null>(null); useEffect(() => { const formViewCurrent = formViewRef.current; if (!formViewCurrent) { return; } const formCurrent = formViewCurrent as unknown as HTMLFormElement; // ... });

And yes, the as unknown is necessary, because this is a terrible cast. We just were hiding it from the type system before. And yes, it's probably worth commenting.

Alternatively, we could remove the "force cast" (as unknown as...) by using a slightly bizarre cast...

const formCurrent = formViewCurrent as (HTMLFormElement & View);

...as HTMLFormElement & View is, actually, the most precise type for what this object should be in runtime on React Native for Web.

blazejkustra

Change displayName to FormElement, LGTM!

melvin-bot · 2023-11-09T10:21:21Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…s-migration/FormElement/component

jakub-trzebiatowski

See these comments

Please tell me if something is not clear there. If necessary, I can explain in more detail while the current typing is problematic.

kubabutkiewicz · 2023-11-15T10:44:32Z

@cubuspl42 will check it today 😄

…s-migration/FormElement/component

kubabutkiewicz · 2023-11-15T17:33:48Z

@cubuspl42 really appreciate your deep review and I resolve your comment 😄

jakub-trzebiatowski · 2023-11-16T10:03:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

ts-migration-FormElement-web.mp4

Mobile Web - Chrome

ts-migration-FormElement-android-web-compressed.mp4

Mobile Web - Safari

ts-migration-FormElement-ios-web.mp4

Desktop

iOS

ts-migration-FormElement-ios.mp4

Android

approveButtonCollectPolicies-android-compressed.mp4

melvin-bot · 2023-11-16T10:03:46Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24973 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mountiny

Thanks!

OSBotify · 2023-11-16T17:55:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T00:49:42Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz added 3 commits October 16, 2023 15:09

ref: moved FormElement to TS

78a09b7

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

af566d8

…s-migration/FormElement/component

fix: typing

d340487

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

b52fbb3

…s-migration/FormElement/component

barttom reviewed Nov 7, 2023

View reviewed changes

VickyStash reviewed Nov 7, 2023

View reviewed changes

fix: changed a type

b2dc291

kubabutkiewicz added 3 commits November 8, 2023 10:55

Revert "ref: moved FormElement to TS"

7e7602f

This reverts commit 78a09b7.

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

1d8c3a3

…s-migration/FormElement/component

Revert "ref: moved FormElement to TS"

5578518

This reverts commit 78a09b7.

barttom reviewed Nov 8, 2023

View reviewed changes

fix: removed unnecessary type

f3133cb

blazejkustra approved these changes Nov 9, 2023

View reviewed changes

fix: changed dispalyName of component

30a3043

kubabutkiewicz marked this pull request as ready for review November 9, 2023 10:21

kubabutkiewicz requested a review from a team as a code owner November 9, 2023 10:21

melvin-bot Bot requested review from jakub-trzebiatowski and removed request for a team November 9, 2023 10:21

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

cadb376

…s-migration/FormElement/component

jakub-trzebiatowski suggested changes Nov 15, 2023

View reviewed changes

kubabutkiewicz added 2 commits November 15, 2023 18:29

fix: resolve comments

627b85a

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

2571645

…s-migration/FormElement/component

jakub-trzebiatowski approved these changes Nov 16, 2023

View reviewed changes

melvin-bot Bot requested a review from mountiny November 16, 2023 10:03

mountiny approved these changes Nov 16, 2023

View reviewed changes

mountiny merged commit a615c41 into Expensify:main Nov 16, 2023

kubabutkiewicz mentioned this pull request Nov 17, 2023

Add focus trap to the RHP (v2) #27670

Merged

os-botify Bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

Uh oh!

Conversation

kubabutkiewicz commented Nov 7, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 7, 2023

Uh oh!

kubabutkiewicz commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barttom Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz commented Nov 8, 2023

Uh oh!

barttom Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Nov 9, 2023

Uh oh!

jakub-trzebiatowski left a comment

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz commented Nov 15, 2023

Uh oh!

kubabutkiewicz commented Nov 15, 2023

Uh oh!

jakub-trzebiatowski commented Nov 16, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 16, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 16, 2023

Uh oh!

OSBotify commented Nov 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

kubabutkiewicz commented Nov 7, 2023 •

edited by github-actions Bot

Loading

kubabutkiewicz commented Nov 7, 2023 •

edited

Loading

barttom Nov 7, 2023 •

edited

Loading

barttom Nov 8, 2023 •

edited

Loading