Popover Fixes by neonbhai · Pull Request #30882 · Expensify/App

neonbhai · 2023-11-04T06:36:21Z

Details

We now confirm bank account deletion using a center alert modal style popover (this is bottom on mobile).

Fixed Issues

$ #29729
PROPOSAL: #29729 (comment)

Tests

Prerequisite: This feature is under the canUseWallets beta. Return true here to enable beta features.

Prerequisite: A bank account should be added to the user account.

Steps to add a bank Account:

Make sure you are using the staging server (Go to Preferences -> Use Staging Server)

Click on Profile Icon -> Workspaces -> Click on a workspace
Click on Bank Account.
Click on Connect Online With Plaid
Choose Wells Fargo. Use the following credentials:
- Username: user_good
- Password: pass_good
- Mobile Code: credential_good
Select Plaid Saving.
Select both additional information checkboxes. Click Continue.
Accept terms. Click on Connect Account Information
Click on Allow
You come back to connect Account Page. Click Save & Continue

Test Steps:

Click on profile picture -> Wallet
In the bank accounts card, we have a list of bank accounts. Click on a bank account.
Click Delete.
Verify that the confirmation popover shows in the middle for wide screens,
Verify that the confirmation popover is bottom docked in mobile screens

Verify that no errors appear in the JS console

Offline tests

Same as Tests Step.

QA Steps

Same as Tests Step.

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.android.mov

Android: mWeb Chrome

mWeb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

Web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2023-11-04T06:36:25Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-11-06T16:55:16Z

@neonbhai Can you complete the author checklist & fix the lint issue?

neonbhai · 2023-11-06T16:56:31Z

@Santhosh-Sellavel on it

neonbhai · 2023-11-07T20:38:11Z

Ready for review @Santhosh-Sellavel!

Santhosh-Sellavel · 2023-11-14T16:45:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native & iOS: Native

Android: mWeb Chrome & iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Santhosh-Sellavel · 2023-11-14T16:49:06Z

@neonbhai

🔴 🔴 Bug: Delete operation is not working

Screen.Recording.2023-11-14.at.10.17.23.PM.mov

Santhosh-Sellavel

Fix this #30882 (comment)

neonbhai · 2023-11-16T10:03:28Z

working on it!

We change showConfirmDeleteContent to showConfirmDeleteModal to better reflect its purpose

Santhosh-Sellavel · 2023-11-20T17:11:23Z

Any update?

Santhosh-Sellavel · 2023-11-23T17:22:48Z

bump @neonbhai

neonbhai · 2023-11-26T22:16:15Z

@Santhosh-Sellavel, updating this quickly

This reverts commit d7ead9f.

This moves ConfirmModal as child of Popover while preserving its visibility logic

neonbhai · 2023-11-27T03:12:45Z

All test videos updated!

neonbhai · 2023-11-28T02:55:10Z

Working on an improvement for this PR, please wait on the review!

neonbhai · 2023-11-30T12:58:26Z

Still working on this, I have run into a weird behavior

I was working on an improvement for the code, to separate the closing logic for both the modals. Since before they were coupled and two separate states were being handled by a single function.

This works well for all platforms except ios native.

On ios native, this modal even with isVisible prop true does not render.

Screencast:

a56ad237-e523-4939-a173-028124273cce.mp4

I've been spending all my time on this to figure out why this behavior occurs and if is has something to do with handing of modals in ios native

Asking on slack here for help from the community to see anyone has encountered this.

neonbhai · 2023-12-02T02:35:51Z

As suggested in Slack, The issue was being caused by the two modals opening successively. The root cause seems to be in https://github.com/react-native-modal/react-native-modal

One way around this, is to use InteractionManager to make sure the first modal closes before we open the other one. But this seems to add a delay to the opening of the confirm modal.

But the delay is noticeable.

To make it snappier, we can use a variable to hide the first modal, and then a function to close both the ConfirmModal and Popover visible states.

Pushing changes for this today.

We use a check to hide the delete menu View when the Confirm Modal is visible.

Santhosh-Sellavel · 2023-12-04T17:55:51Z

@neonbhai Will this be ready for review tomorrow?

neonbhai · 2023-12-04T18:03:51Z

Yes, just updating tests on android! The build takes ages 🥲

All other platforms tested!

neonbhai · 2023-12-04T18:10:06Z

All platforms tested!

neonbhai · 2023-12-04T18:12:44Z

Ready for review @Santhosh-Sellavel

Santhosh-Sellavel · 2023-12-04T18:14:50Z

Thanks will review it tomorrow, meanwhile please test carefully and ensure there are no regressions. Resolve merge conflicts if any thanks!

This removes the redundant call to hide DefaultDeleteMenu from Confirm Modal's onModalHide prop.

Santhosh-Sellavel · 2023-12-06T11:42:26Z

Can you fix lint please?

neonbhai · 2023-12-06T13:24:01Z

lint error was in different part of the codebase coming from the updated Typescript Checks. Fixed by merging!

Santhosh-Sellavel · 2023-12-13T19:04:16Z

Can we merge this one @jasperhuangg ?

OSBotify · 2023-12-14T00:40:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-14T16:05:28Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T16:45:16Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T02:01:34Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add popover with overlay to confirm Bank Account deletion

cfc058f

neonbhai requested a review from a team as a code owner November 4, 2023 06:36

melvin-bot Bot requested review from Santhosh-Sellavel and removed request for a team November 4, 2023 06:36

lint fix

c098335

neonbhai mentioned this pull request Nov 7, 2023

[HOLD for payment 2023-12-26] [$500] Wallet - Button to confirm bank account deletion is off-screen #29729

Closed

6 tasks

Santhosh-Sellavel suggested changes Nov 14, 2023

View reviewed changes

neonbhai and others added 4 commits November 16, 2023 17:24

Move onModalHide to ConfirmModal prop

9f46423

Improve Confirm Modal Visibility logic

146570d

Improve State Variable name

07ea059

We change showConfirmDeleteContent to showConfirmDeleteModal to better reflect its purpose

Merge branch 'Expensify:main' into popover-changes

9c43894

neonbhai and others added 4 commits November 27, 2023 03:57

Move ConfirmModal inside Popover

d7ead9f

Revert "Move ConfirmModal inside Popover"

fe6f5a9

This reverts commit d7ead9f.

Move Confirmation Modal component

b80cbc7

This moves ConfirmModal as child of Popover while preserving its visibility logic

Merge branch 'Expensify:main' into popover-changes

23f3865

Seperate closing logic for Popover and Confirm Modal

228b349

neonbhai added 2 commits December 4, 2023 19:26

Speed up Modal Visibility Time

1aa5fe0

We use a check to hide the delete menu View when the Confirm Modal is visible.

Fix Button onPress action

de41c2e

Santhosh-Sellavel reviewed Dec 5, 2023

View reviewed changes

Comment thread src/pages/settings/Wallet/WalletPage/WalletPage.js Outdated

Remove redundant state change.

34bf1da

This removes the redundant call to hide DefaultDeleteMenu from Confirm Modal's onModalHide prop.

Merge branch 'Expensify:main' into popover-changes

0ab3991

Santhosh-Sellavel approved these changes Dec 10, 2023

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg December 10, 2023 19:25

jasperhuangg approved these changes Dec 11, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Dec 13, 2023

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg December 13, 2023 19:03

jasperhuangg merged commit b950c1e into Expensify:main Dec 14, 2023

github-actions Bot mentioned this pull request Dec 14, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

Uh oh!

Conversation

neonbhai commented Nov 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 4, 2023

Uh oh!

Santhosh-Sellavel commented Nov 6, 2023

Uh oh!

neonbhai commented Nov 6, 2023

Uh oh!

neonbhai commented Nov 7, 2023

Uh oh!

Santhosh-Sellavel commented Nov 14, 2023 • edited by jasperhuangg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

neonbhai commented Nov 16, 2023

Uh oh!

Santhosh-Sellavel commented Nov 20, 2023

Uh oh!

Santhosh-Sellavel commented Nov 23, 2023

Uh oh!

neonbhai commented Nov 26, 2023

Uh oh!

neonbhai commented Nov 27, 2023

Uh oh!

neonbhai commented Nov 28, 2023

Uh oh!

neonbhai commented Nov 30, 2023

Screencast:

Uh oh!

neonbhai commented Dec 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel commented Dec 4, 2023

Uh oh!

neonbhai commented Dec 4, 2023

Uh oh!

neonbhai commented Dec 4, 2023

Uh oh!

neonbhai commented Dec 4, 2023

Uh oh!

Santhosh-Sellavel commented Dec 4, 2023

Uh oh!

Uh oh!

Santhosh-Sellavel commented Dec 6, 2023

Uh oh!

neonbhai commented Dec 6, 2023

Uh oh!

Santhosh-Sellavel commented Dec 13, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

OSBotify commented Dec 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

neonbhai commented Nov 4, 2023 •

edited

Loading

Santhosh-Sellavel commented Nov 14, 2023 •

edited by jasperhuangg

Loading

Santhosh-Sellavel commented Nov 14, 2023 •

edited

Loading

neonbhai commented Dec 2, 2023 •

edited

Loading