chore(node): bump node version to 20.9.0 by pac-guerreiro · Pull Request #30645 · Expensify/App

pac-guerreiro · 2023-10-31T15:56:39Z

Details

This PR represents the 2nd step of the plan to bump node version to 20.9.0 on the E/App and React Native Onyx.

On this step, the E/App will be modified to require node version 20.9.0 and bump react-native-onyx version to 1.0.118.

Fixed Issues

$ #25824
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

fabioh8010 · 2023-11-14T15:02:53Z

Hi @pac-guerreiro , I made some fixes and updated the branch against main. I also did some high-level tests using a build of your Onyx PR and everything seems ok! Just a note here, I had to run npm rebuild after installing dependencies in order to rebuild all previously built packages, otherwise we get issues when trying to start web/desktop apps or run tests. We should advice the community to run this command once this PR get merged.

pac-guerreiro · 2023-11-14T17:56:47Z

@fabioh8010 Thank you for the help you provided today with this task! 🙌

@roryabraham This PR can only be merged after the one for Onyx, because otherwise the app will not build because of incompatible node versions.

roryabraham · 2023-11-14T23:50:20Z

Onyx PR merged. Let's try to get this PR updated and get E/App onto Onyx 1.0.118 ASAP

melvin-bot · 2023-11-15T17:44:49Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pac-guerreiro · 2023-11-15T17:46:58Z

@roryabraham @pecanoro @DylanDylann

PR is ready for review!

Just a note, reassure tests are failing because they're comparing the current main branch which has the old node version with the current branch that has the new one, and the script doesn't change node version between tests as it seems.

roryabraham · 2023-11-15T20:06:07Z

@pac-guerreiro tests are failing

fabioh8010 · 2023-11-16T02:10:43Z

Hi @pac-guerreiro @roryabraham , I was investigating the problem with the tests and I discovered that the mock-fs library has some issues with Node 20 e.g here and here. So I've replaced it with memfs library and the unit tests seem ok now. @pac-guerreiro let's just do a final test from your side to ensure this changes didn't break anything (certainly not as it is only related to test environment).

roryabraham · 2023-11-16T15:44:50Z

It looks like reassure is failing because the baseline branch has the old version of the .nvmrc so won't install. I think to fix it we need to update the engines field in package.json on main to make it allow either 16.15.1 or 20.9.0, then merge this PR, then do another PR to make engines field strictly 20.9.0

getusha · 2023-11-16T16:06:31Z

@pac-guerreiro i think we should also update https://github.com/Expensify/App/pull/30645/files#diff-078cc99a41fdf153e17d55bbe6f7bc843ae352d21cbf649cea7860482cb93debR9-R10

# Conflicts: # package-lock.json # package.json

pac-guerreiro · 2023-11-16T17:12:44Z

@roryabraham @fabioh8010 @getusha

Requested changes applied

pac-guerreiro · 2023-11-16T17:13:37Z

Tests are passing now, except snyk but I don't have access to the logs

roryabraham · 2023-11-16T17:38:58Z

Snyk is a false negative. It says package.json and package-lock.json are out-of-sync, which does not appear to be true. I get no diff when doing an npm i.

since this only affects GitHub Actions and tests, I think we can merge this without C+ review. And of course, we'll need to follow up with another PR to upgrade .nvmrc to Node 20

roryabraham · 2023-11-16T17:39:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

roryabraham · 2023-11-16T17:40:40Z

Merging because snyk is a false negative. I have seen the same thing in other PRs

OSBotify · 2023-11-16T17:46:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T00:49:24Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pac-guerreiro and others added 5 commits November 15, 2023 17:00

chore(node): bump node version to 20.9.0

ce598bf

Fix typo

ee0fecc

Fix build-desktop script to use npx

2541e2f

Change e2e spec files to use Node 20

2e20691

chore(onyx): bump version to 1.0.118

b80a22a

pac-guerreiro marked this pull request as ready for review November 15, 2023 17:44

pac-guerreiro requested a review from a team as a code owner November 15, 2023 17:44

melvin-bot Bot requested review from getusha and removed request for a team November 15, 2023 17:44

Replace mock-fs with memfs

6fd1389

chore(node): strict version between 16.15.1 and 20.9.0

e041f70

pac-guerreiro added 2 commits November 16, 2023 16:53

chore(node): use 16.15.1 on github workflows

3aecdc1

Merge branch 'main' into bump-node-version-to-20

0b27b15

# Conflicts: # package-lock.json # package.json

roryabraham approved these changes Nov 16, 2023

View reviewed changes

roryabraham merged commit 50216be into Expensify:main Nov 16, 2023

pac-guerreiro deleted the bump-node-version-to-20 branch November 16, 2023 19:45

os-botify Bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

melvin-bot Bot mentioned this pull request Nov 22, 2023

[HOLD for payment 2023-11-29] Bump E/App and Onyx to use NodeJS 20.9.0 LTS #25824

Closed

Uh oh!

Conversation

pac-guerreiro commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

fabioh8010 commented Nov 14, 2023

Uh oh!

pac-guerreiro commented Nov 14, 2023

Uh oh!

roryabraham commented Nov 14, 2023

Uh oh!

melvin-bot Bot commented Nov 15, 2023

Uh oh!

pac-guerreiro commented Nov 15, 2023

Uh oh!

roryabraham commented Nov 15, 2023

Uh oh!

fabioh8010 commented Nov 16, 2023

Uh oh!

roryabraham commented Nov 16, 2023

Uh oh!

getusha commented Nov 16, 2023

Uh oh!

pac-guerreiro commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pac-guerreiro commented Nov 16, 2023

Uh oh!

roryabraham commented Nov 16, 2023

Uh oh!

roryabraham commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

roryabraham commented Nov 16, 2023

Uh oh!

OSBotify commented Nov 16, 2023

Uh oh!

OSBotify commented Nov 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pac-guerreiro commented Oct 31, 2023 •

edited

Loading

pac-guerreiro commented Nov 16, 2023 •

edited

Loading

roryabraham commented Nov 16, 2023 •

edited

Loading