fix: change moment of displaying chat after editing existed message by barttom · Pull Request #30564 · Expensify/App

barttom · 2023-10-30T10:11:45Z

Details

Fixed Issues

$ #29211
PROPOSAL: #29211 (comment)

Tests

Open the app
Navigate to any chat
Send a message
Long tap the message you just sent
Select "Edit"
With or without editing tap 'save' edited message or 'close' editing

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Navigate to any chat
Send a message
Long tap the message you just sent
Select "Edit"
With or without editing tap 'save' edited message or 'close' editing

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

29211_android.mp4

Android: mWeb Chrome

29211_androidweb.mp4

iOS: Native

29211_ios.mp4

iOS: mWeb Safari

29211_iosweb.mp4

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

melvin-bot · 2023-10-30T12:34:51Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2023-10-31T17:52:44Z

Maybe now we should rename keyboardDidHideListener ? Do we have a better name?

Also instead of using Platform.OS let's use getOperatingSystem.

I've changed the name, also added some comment to explain why we listen different events based on platform.

thesahindia · 2023-11-02T16:20:07Z


-let keyboardDidHideListener: EmitterSubscription | null = null;
+let keyboardEventListener: EmitterSubscription | null = null;
+// On iOS is visible delay with displaying input after keyboard has been closed with `keyboardDidHide` event


NAB

Suggested change

// On iOS is visible delay with displaying input after keyboard has been closed with `keyboardDidHide` event

// On iOS, there is a visible delay in displaying input after the keyboard has been closed with the `keyboardDidHide` event

comment fixed

thesahindia · 2023-11-02T18:59:40Z

Not sure why we weren't able to repro #15086 earlier. I just tested it again and now I can repro it.

Screen.Recording.2023-11-03.at.12.23.43.AM.mov

Can you also check this @barttom ?

barttom · 2023-11-03T12:33:34Z

@thesahindia Sorry, I can't reproduce that. Could you record a longer video or write steps that I can follow?
Also do YOu have disabled the 'Connect hardware keyboard' option in Your simulator?

Screen.Recording.2023-11-03.at.11.54.57.mp4

thesahindia · 2023-11-03T17:32:33Z

Ahh, my bad. I was using hardware keyboard, so the virtual keyboard wasn't opening and I was able to repro that issue but in real life the keyboard opens so it won't be possible to repro that issue. So I think we are good.

thesahindia · 2023-11-03T17:50:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- [ x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-03.at.11.20.18.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-02.at.11.31.40.PM.mov

iOS: Native

Screen.Recording.2023-11-03.at.10.59.22.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-03.at.11.08.35.PM.mov

MacOS: Chrome / Safari

MacOS: Desktop

thesahindia

LGTM!

OSBotify · 2023-11-07T14:18:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-08T08:31:00Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.96-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:46:31Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T16:02:39Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T21:56:06Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

barttom marked this pull request as ready for review October 30, 2023 12:34

barttom requested a review from a team as a code owner October 30, 2023 12:34

melvin-bot Bot requested review from thesahindia and removed request for a team October 30, 2023 12:34

barttom force-pushed the fix/29211/remove-delay-visibility-chat-input-after-editing-message branch from 3c5e420 to 3be5411 Compare October 31, 2023 08:21

barttom mentioned this pull request Oct 31, 2023

[$500] Chat - Input field briefly disappears after saving edited message #29211

Closed

6 tasks

thesahindia suggested changes Oct 31, 2023

View reviewed changes

barttom added 4 commits November 1, 2023 18:30

fix: change moment of displaying chat after editing existed message

400c622

fix: add previous solution for android

bc6fd72

refactor: change event handler method

45b03b0

fix: removed unused Platform dependency

b18fd59

barttom force-pushed the fix/29211/remove-delay-visibility-chat-input-after-editing-message branch from bc4275b to b18fd59 Compare November 1, 2023 17:32

thesahindia reviewed Nov 2, 2023

View reviewed changes

fix: changed comment description

a20986c

thesahindia approved these changes Nov 3, 2023

View reviewed changes

melvin-bot Bot requested a review from tgolen November 3, 2023 17:51

tgolen requested changes Nov 3, 2023

View reviewed changes

Comment thread src/libs/setShouldShowComposeInputKeyboardAware/index.native.ts Outdated

barttom added 2 commits November 7, 2023 09:54

fix: added files per native platform

1ef898c

fix: added files per native platform

c47a6fe

tgolen approved these changes Nov 7, 2023

View reviewed changes

tgolen merged commit b4ee8c4 into Expensify:main Nov 7, 2023

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-10 #31187

Closed

	// On iOS is visible delay with displaying input after keyboard has been closed with `keyboardDidHide` event
	// On iOS, there is a visible delay in displaying input after the keyboard has been closed with the `keyboardDidHide` event

Conversation

barttom commented Oct 30, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 30, 2023

Uh oh!

thesahindia Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

barttom Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

thesahindia Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

barttom Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Nov 2, 2023

Uh oh!

barttom commented Nov 3, 2023

Uh oh!

thesahindia commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thesahindia commented Nov 3, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 7, 2023

Uh oh!

OSBotify commented Nov 8, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thesahindia commented Nov 3, 2023 •

edited

Loading