ignore currency symbol for tbd by rojiphil · Pull Request #30459 · Expensify/App

rojiphil · 2023-10-26T17:41:16Z

@Santhosh-Sellavel @luacmartins

Details

This PR makes the following changes to the code:

Ensure that currencySymbol is set to empty string in getDistanceMerchant utility function when rate is not available.

Fixed Issues

$ #30376
PROPOSAL: #30376 (comment)

Tests

Precondition:

User A:

Create a new workspace 'My Workspace'
Invite User B to the workspace

User B:
3. Verify that User B sees the invited Workspace from User A in LHN.
(Note: Do not open workspace in User B's App)

Test Steps: User B
This is an offline test scenario

Go Offline
Go to + > Request money > Distance
Enter any start and finish point and click Next
Select My Workspace
Verify that the Distance page does not display currency symbol for Distance (should be something like TBD miles @ TBD / mile)
Click Request. Verify that ReportPreview does not display currency symbol for distance
Click on ReportPreview. Verify that the IOU Report does not display currency symbol for distance
Go to Transaction Details. Verify that distance does not display currency symbol.

Verify that no errors appear in the JS console

Offline tests

Same as the Steps for Tests Section.

QA Steps

Same as the Steps for Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS

30376-ios-native.mp4

Android

30376-android-native.mp4

Mobile Web - Chrome

30376-mweb-chrome.mp4

Mobile Web - Safari

30376-mweb-safari.mp4

Web

30376-web-safari.mp4

Desktop

30376-desktop.mp4

melvin-bot · 2023-10-26T17:51:40Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rojiphil · 2023-10-26T17:51:51Z

@Santhosh-Sellavel
PR checklist done. Works well too.
Over to you for review

rojiphil · 2023-10-29T09:53:03Z

@Santhosh-Sellavel
Gentle bump on PR review here

rojiphil · 2023-10-31T05:21:08Z

@Santhosh-Sellavel
Gentle reminder again on PR review here.

Santhosh-Sellavel · 2023-10-31T17:22:12Z

Sorry for the delay @rojiphil Can you make numbered steps instead a,b,c,d, etc.

Will review today, thanks!

Santhosh-Sellavel

Just minor, looks good will complete checklist with screens tomorrow caught up with some issues on new setup changes.

Santhosh-Sellavel · 2023-10-31T18:14:01Z

    const unitString = distanceInUnits === 1 ? singularDistanceUnit : distanceUnit;
    const ratePerUnit = rate ? PolicyUtils.getUnitRateValue({rate}, toLocaleDigit) : translate('common.tbd');
-    const currencySymbol = CurrencyUtils.getCurrencySymbol(currency) || `${currency} `;
+    // Set the currency symbol only if rate is valid


This seems unnecessary please remove this

Sure. The unnecessary comment is removed now.

rojiphil · 2023-11-01T03:04:44Z

Can you make numbered steps instead a,b,c,d, etc.

The steps are changed to numbered format.

rojiphil · 2023-11-01T03:07:32Z

@Santhosh-Sellavel
Works well too after removing the comment.
Kindly review

rojiphil · 2023-11-01T21:22:27Z

Just minor, looks good will complete checklist with screens tomorrow caught up with some issues on new setup changes.

@Santhosh-Sellavel
Seems like you could not take this further until now
Is it possible to prioritize this today?

Santhosh-Sellavel · 2023-11-02T05:18:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-11-02.at.10.33.53.AM.mov

MacOS: Desktop

Screen.Recording.2023-11-02.at.10.42.05.AM.mov

Santhosh-Sellavel

LGTM!

Unable to test on Android/mWeb, but that should be a blocker here so approving!

luacmartins

LGTM

OSBotify · 2023-11-02T16:16:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:33:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

puneetlath · 2023-11-08T19:01:53Z

According to QA this is still happening on iOS.

rojiphil · 2023-11-09T03:18:24Z

According to QA this is still happening on iOS.

@puneetlath
Have responded to this in the issue here

OSBotify · 2023-11-09T22:51:28Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:48:24Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ignore currency symbol for tbd

a46b01b

rojiphil marked this pull request as ready for review October 26, 2023 17:51

rojiphil requested a review from a team as a code owner October 26, 2023 17:51

melvin-bot Bot removed the request for review from a team October 26, 2023 17:51

melvin-bot Bot requested a review from Santhosh-Sellavel October 26, 2023 17:51

rojiphil mentioned this pull request Oct 26, 2023

[$500] Distance - Distance rate shows $TBD instead of TBD in offline mode #30376

Closed

6 tasks

Santhosh-Sellavel reviewed Oct 31, 2023

View reviewed changes

rojiphil added 2 commits November 1, 2023 07:24

Merge branch 'Expensify:main' into 30376-no-currency-for-tbd

1363569

removed unnecessary comment

0afb9dd

rojiphil requested a review from Santhosh-Sellavel November 1, 2023 03:07

Santhosh-Sellavel approved these changes Nov 2, 2023

View reviewed changes

melvin-bot Bot requested a review from luacmartins November 2, 2023 06:26

luacmartins approved these changes Nov 2, 2023

View reviewed changes

luacmartins merged commit f7d7a9d into Expensify:main Nov 2, 2023

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Conversation

rojiphil commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 26, 2023

Uh oh!

rojiphil commented Oct 26, 2023

Uh oh!

rojiphil commented Oct 29, 2023

Uh oh!

rojiphil commented Oct 31, 2023

Uh oh!

Santhosh-Sellavel commented Oct 31, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

rojiphil Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Nov 1, 2023

Uh oh!

rojiphil commented Nov 1, 2023

Uh oh!

rojiphil commented Nov 1, 2023

Uh oh!

Santhosh-Sellavel commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

puneetlath commented Nov 8, 2023

Uh oh!

rojiphil commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rojiphil commented Oct 26, 2023 •

edited

Loading

Santhosh-Sellavel commented Nov 2, 2023 •

edited

Loading