[Form Provider Refactor] WorkspaceSettingsPage by kowczarz · Pull Request #30355 · Expensify/App

kowczarz · 2023-10-25T15:49:09Z

Details

Fixed Issues

$ #30006

Tests

Ensure you're a member of any workspace and you have an admin permission
Press on your avatar > Workspaces > Select workspace you're the admin of > Settings
Test if modifying avatar, name and default currency works properly

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.native_H.265.mp4

Android: mWeb Chrome

android.web_H.265.mp4

iOS: Native

ios.native_H.265.mp4

iOS: mWeb Safari

ios.web_H.265.mp4

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop_H.265.mp4

melvin-bot · 2023-10-26T15:39:39Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2023-10-26T15:41:34Z

@luacmartins the PR is ready for review, if there will be some issues @cdOut or @adamgrzybowski will try to solve them or will try to keep the PR updated until I will be back.

0xmiroslav · 2023-10-26T16:55:01Z

Seems like recent regression. Button has no margin

0xmiroslav · 2023-10-26T16:56:25Z

@kowczarz Actually that doesn't happen on main. Caused by this PR. Let's fix that

luacmartins · 2023-10-26T17:00:11Z

@cdOut @adamgrzybowski could you please take a look at the above issue with the submit button style?

luacmartins

It seems like we have a style bug with the submit button

luacmartins · 2023-10-30T16:15:15Z

We're still pending the submit button style fix

cdOut · 2023-10-30T18:09:15Z

I'll look at it tomorrow since Kamil is currently OOO

cdOut · 2023-10-31T14:14:29Z

@0xmiroslav please retest this PR, the feature that should style submit buttons wasn't implemented in the new form components so I added it, should work now

0xmiroslav · 2023-10-31T20:24:32Z

Not caused by this PR but can we fix RBR style as well?

cdOut · 2023-10-31T22:19:19Z

Not caused by this PR but can we fix RBR style as well?

Sure, I could work on fixing this as well in this PR. @luacmartins should I work on it in here?

luacmartins · 2023-10-31T22:32:28Z

Yea, that's fine!

cdOut · 2023-11-02T13:18:14Z

Okay, I'll get on fixing that right away

luacmartins · 2023-11-02T16:19:47Z

Thank you!

cdOut · 2023-11-03T08:58:30Z

The margin styling error should be fixed, please recheck

0xmiroslav · 2023-11-03T09:00:04Z

Is this page different from others? I don't see any need of custom styling in other forms

cdOut · 2023-11-03T09:51:03Z

Is this page different from others? I don't see any need of custom styling in other forms

It is a little different, normally the input components would be wrapped with a view that's properly styled to have margin, but in this instance since the currency picker spans the whole container the first text input doesn't have proper margins, which I fixed

Unless this is something that is problematic on other pages then please send me which ones are affected

0xmiroslav · 2023-11-03T16:38:18Z

Conflicts!

luacmartins · 2023-11-03T16:42:48Z

@cdOut could you please resolve conflicts?

luacmartins

Still waiting for conflict resolution

cdOut · 2023-11-03T22:54:17Z

Resolved, the bug was fixed on main so I reverted the changes.

0xmiroslav · 2023-11-05T15:33:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

0xmiroslav

LGTM!

OSBotify · 2023-11-06T16:18:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:30:46Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:48:19Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:44:57Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kowczarz added 2 commits October 25, 2023 16:39

Refactor workspace settings page

e24cb35

Fix lint

4356a4b

kowczarz marked this pull request as ready for review October 26, 2023 15:39

kowczarz requested a review from a team as a code owner October 26, 2023 15:39

melvin-bot Bot requested review from 0xmiroslav and removed request for a team October 26, 2023 15:39

luacmartins self-requested a review October 26, 2023 16:59

luacmartins requested changes Oct 27, 2023

View reviewed changes

cdOut added 2 commits October 31, 2023 15:02

fix proper submit button styling in FormWrapper

8635361

merge main into form-refactor/workspace-settings-page

9f761fe

luacmartins self-requested a review October 31, 2023 18:22

luacmartins previously approved these changes Oct 31, 2023

View reviewed changes

fix proper margin in styling

be30678

cdOut dismissed luacmartins’s stale review via be30678 November 3, 2023 08:57

luacmartins reviewed Nov 3, 2023

View reviewed changes

cdOut added 2 commits November 3, 2023 23:49

merge main into form-refactor/workspace-settings-page

9eabb28

revert adding a wrapper view with styling

26edafa

0xmiroslav approved these changes Nov 5, 2023

View reviewed changes

melvin-bot Bot requested a review from luacmartins November 5, 2023 15:34

luacmartins approved these changes Nov 6, 2023

View reviewed changes

luacmartins merged commit 8d6e85a into Expensify:main Nov 6, 2023

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

kowczarz mentioned this pull request Dec 22, 2023

[$500] [Form Provider Refactor] WorkspaceSettingsPage #30006

Closed

Uh oh!

Conversation

kowczarz commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 26, 2023

Uh oh!

kowczarz commented Oct 26, 2023

Uh oh!

0xmiroslav commented Oct 26, 2023

Uh oh!

0xmiroslav commented Oct 26, 2023

Uh oh!

luacmartins commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Oct 30, 2023

Uh oh!

cdOut commented Oct 30, 2023

Uh oh!

cdOut commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented Oct 31, 2023

Uh oh!

cdOut commented Oct 31, 2023

Uh oh!

luacmartins commented Oct 31, 2023

Uh oh!

cdOut commented Nov 2, 2023

Uh oh!

luacmartins commented Nov 2, 2023

Uh oh!

cdOut commented Nov 3, 2023

Uh oh!

0xmiroslav commented Nov 3, 2023

Uh oh!

cdOut commented Nov 3, 2023

Uh oh!

0xmiroslav commented Nov 3, 2023

Uh oh!

luacmartins commented Nov 3, 2023

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

cdOut commented Nov 3, 2023

Uh oh!

0xmiroslav commented Nov 5, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

kowczarz commented Oct 25, 2023 •

edited

Loading

luacmartins commented Oct 26, 2023 •

edited

Loading

cdOut commented Oct 31, 2023 •

edited

Loading