Skip to content

fix error message positioning on amount page #30287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyevans merged 2 commits into from
Oct 27, 2023
Merged

fix error message positioning on amount page #30287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e963d
use absolute positioning for error message and ensure 12px of gap
aman-atg Oct 24, 2023
f63eba0
Merge branch 'main' of github.com:Expensify/App into aman/fix-error-m…
aman-atg Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/pages/iou/steps/MoneyRequestAmountForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,14 @@ function MoneyRequestAmountForm({amount, currency, isEditing, forwardedRef, onCu
}}
onKeyPress={textInputKeyPress}
/>
{!_.isEmpty(formError) && (
<FormHelpMessage
style={[styles.pAbsolute, styles.b0, styles.mb0, styles.ph5, styles.w100]}

@jjcoffee jjcoffee Jan 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely positioning the error message caused #32661 where the error message starts to overlap the amount input when zooming in.

isError
message={translate(formError)}
/>
)}
</View>
{!_.isEmpty(formError) && (
<FormHelpMessage
style={[styles.ph5]}
isError
message={translate(formError)}
/>
)}
<View
onMouseDown={(event) => onMouseDown(event, [NUM_PAD_CONTAINER_VIEW_ID, NUM_PAD_VIEW_ID])}
style={[styles.w100, styles.justifyContentEnd, styles.pageWrapper, styles.pt0]}
Expand All @@ -286,7 +286,7 @@ function MoneyRequestAmountForm({amount, currency, isEditing, forwardedRef, onCu
allowBubble
pressOnEnter
medium={isExtraSmallScreenHeight}
style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt2]}
style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt3]}
onPress={submitAndNavigateToNextPage}
text={buttonText}
/>
Expand Down