Feat: add jsDoc to billable#29327
Merged
Merged
Conversation
|
@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
0xmiroslav
reviewed
Oct 11, 2023
Comment on lines
+83
to
+87
| /** IOU isBillable */ | ||
| iouIsBillable: PropTypes.bool, | ||
|
|
||
| /** IOU Callback toggle billable state */ | ||
| onToggleBillable: PropTypes.func, |
Contributor
There was a problem hiding this comment.
As these are optional props, defaultProps is also required
Contributor
Author
There was a problem hiding this comment.
This should be as Category and Tags
Contributor
There was a problem hiding this comment.
don't get your comment. can you explain why default values are not needed?
Contributor
Author
There was a problem hiding this comment.
Ah, sorry, thought about different thing, added defaultProps
amyevans
requested changes
Oct 11, 2023
amyevans
left a comment
Contributor
There was a problem hiding this comment.
Could you also update https://github.com/Expensify/App/blob/main/src/pages/iou/propTypes/index.js please?
58 tasks
Contributor
Author
|
@amyevans updated |
amyevans
reviewed
Oct 12, 2023
| /** The category name */ | ||
| category: PropTypes.string, | ||
|
|
||
| /** The Billable */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** The Billable */ | |
| /** Whether the request is billable */ |
Sorry for the nitpicks here, just trying to make it as descriptive as possible for those who don't really know what it is
Contributor
Reviewer Checklist
Screenshots/VideosVerified no prop type warnings when creating or editing money request: WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
amyevans
approved these changes
Oct 13, 2023
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
The test is flaky, this PR definitely did not cause a performance regression. |
97 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.84-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.85-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR is only to add PropTypes for isBilalble and toggleBillable
Fixed Issues
$ #26128
Tests
N/A
Offline tests
Same as tests
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.