Skip to content

Android chrome crashes on opening password protected PDF #29103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youssef-lr merged 5 commits into from
Oct 11, 2023
Merged

Android chrome crashes on opening password protected PDF #29103

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3aafc7c
Fix app crash on opening password protected PDF
ZhenjaHorbach Oct 9, 2023
ba6bb2c
Update comment for retrieveMaxCanvasArea
ZhenjaHorbach Oct 10, 2023
83c0093
Update comment for retrieveMaxCanvasArea x2
ZhenjaHorbach Oct 10, 2023
1e2b7f4
Update comment for retrieveMaxCanvasArea x3
ZhenjaHorbach Oct 10, 2023
1793df2
Update comment for retrieveMaxCanvasArea x4
ZhenjaHorbach Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/libs/actions/CanvasSize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,25 @@
import Onyx from 'react-native-onyx';
import canvasSize from 'canvas-size';
import ONYXKEYS from '../../ONYXKEYS';
import * as Browser from '../Browser';

/**
* Calculate the max area of canvas on this specific platform and save it in onyx
*/
function retrieveMaxCanvasArea() {
canvasSize.maxArea({
onSuccess: (width, height) => {
Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height);
},
});
// We're limiting the maximum value on mobile web to prevent a crash related to rendering large canvas elements.
// More information at: https://github.com/jhildenbiddle/canvas-size/issues/13
canvasSize

@Ollyws Ollyws Oct 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
canvasSize
// We're limiting the maximum value on mobile web to prevent a crash related to rendering large canvas elements.
// More information at: https://github.com/jhildenbiddle/canvas-size/issues/13
canvasSize

.maxArea({

@Ollyws Ollyws Oct 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a comment here explaining why we're doing this? Thanks!

max: Browser.isMobile() ? 8192 : null,
usePromise: true,
useWorker: false,
})
.then(() => ({
onSuccess: (width, height) => {
Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height);
},
}));
}

/**
Expand Down