Skip to content

[TS migration] Migrate 'useThrottledButtonState.js' hook to TypeScript #28920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
Oct 9, 2023
Merged

[TS migration] Migrate 'useThrottledButtonState.js' hook to TypeScript #28920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e008d
Migrate to Typescript
MaciejSWM Oct 5, 2023
68afc35
Extract returned value to type
MaciejSWM Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/hooks/useThrottledButtonState.js → src/hooks/useThrottledButtonState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import {useEffect, useState} from 'react';

/**
* @returns {Array}
*/
export default function useThrottledButtonState() {
type ThrottledButtonState = [boolean, () => void];

@kubabutkiewicz kubabutkiewicz Oct 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type ThrottledButtonState = [boolean, () => void];
type ThrottledButtonState = [boolean, Dispatch<SetStateAction<boolean>>];

@MaciejSWM MaciejSWM Oct 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubabutkiewicz when I apply your suggestion, I'm getting this tooltip:

image

Which is expecting a boolean value to be passed to that function. In reality though, this function doesn't accept any params. LMK your thoughts.

@kubabutkiewicz kubabutkiewicz Oct 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I thought we are returning the state setter from this hook but we are returning function which is just setting state to false so nvm. LGTM


export default function useThrottledButtonState(): ThrottledButtonState {
const [isButtonActive, setIsButtonActive] = useState(true);

useEffect(() => {
Expand Down