Skip to content

[CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Sep 20, 2023
Merged

[CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1192a5
fix: regression of 26178
tienifr Sep 19, 2023
0ab7332
revert 27268
tienifr Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/libs/Navigation/NavigationRoot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import Log from '../Log';
import StatusBar from '../StatusBar';
import useCurrentReportID from '../../hooks/useCurrentReportID';
import useWindowDimensions from '../../hooks/useWindowDimensions';
import * as ReportActionContextMenu from '../../pages/home/report/ContextMenu/ReportActionContextMenu';
import * as EmojiPickerAction from '../actions/EmojiPickerAction';

// https://reactnavigation.org/docs/themes
const navigationTheme = {
Expand Down Expand Up @@ -123,10 +121,6 @@ function NavigationRoot(props) {
if (!state) {
return;
}
ReportActionContextMenu.hideContextMenu();
ReportActionContextMenu.hideDeleteModal();
EmojiPickerAction.hideEmojiPicker(true);

updateCurrentReportID(state);
parseAndLogRoute(state);
animateStatusBarBackgroundColor();
Expand Down
3 changes: 0 additions & 3 deletions src/pages/home/report/ReactionList/PopoverReactionList/BasePopoverReactionList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,6 @@ class BasePopoverReactionList extends React.Component {
* Hide the ReactionList modal popover.
*/
hideReactionList() {
if (!this.state.isPopoverVisible) {
return;
}
this.setState({
isPopoverVisible: false,
});
Expand Down
7 changes: 0 additions & 7 deletions src/pages/home/report/ReportActionsView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,6 @@ function ReportActionsView(props) {
}
}, [props.report, didSubscribeToReportTypingEvents, reportID]);

useEffect(() => {
if (isFocused || !context.reactionListRef || !context.reactionListRef.current) {
return;
}
context.reactionListRef.current.hideReactionList();
}, [isFocused, context.reactionListRef]);

/**
* Retrieves the next set of report actions for the chat once we are nearing the end of what we are currently
* displaying.
Expand Down