Return early if no valid sequenceNumber can be found#2777
Merged
Conversation
jasperhuangg
approved these changes
May 11, 2021
| // update the last read. Most likely, we have just created the report and it has no comments. But we should err on | ||
| // the side of caution and do nothing in this case. | ||
| if (_.isUndefined(sequenceNumber) | ||
| && (!reportMaxSequenceNumbers[reportID] && reportMaxSequenceNumbers[reportID] !== 0)) { |
Contributor
There was a problem hiding this comment.
NAB, but why not use ??
(reportMaxSequenceNumbers[reportID] ?? 0) !== 0
Contributor
Author
There was a problem hiding this comment.
Why should we use it? 😄
Contributor
Author
There was a problem hiding this comment.
Here's the result I want...
Only reject the value if undefined or null but not 0
and figure that out by looking for something falsy
!reportMaxSequenceNumbers[reportID]
and (&&)
that is not 0
reportMaxSequenceNumbers[reportID] !== 0
since if reportMaxSequenceNumbers[reportID] was 0 it would be falsy.
36 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.41-8🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @roryabraham
Details
Updates a check that only checks for an "undefined" sequenceNumber when it should be ignoring any invalid values for a
sequenceNumber. Seems like this PR actually did not make it to production. But I also happened to spot anullvalue inreportMaxSequenceNumberson dev so I think this is a good change regardless.Fixed Issues
No issue, but related to #2704
Tests
QA Steps
Same as #2704
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android