Skip to content

Fix three-dot button tooltip flickers #27732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 1 commit into from
Sep 20, 2023
Merged

Fix three-dot button tooltip flickers #27732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/PopoverWithMeasuredContent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ function PopoverWithMeasuredContent(props) {
but we can't measure its dimensions without first rendering it.
*/
<View
style={styles.invisible}
style={styles.invisiblePopover}
onLayout={measurePopover}
>
{props.children}
Expand Down
6 changes: 6 additions & 0 deletions src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2553,6 +2553,12 @@ const styles = (theme) => ({
opacity: 0,
},

invisiblePopover: {
position: 'absolute',
opacity: 0,
left: -9999,

@eVoloshchak eVoloshchak Mar 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ✋
Coming from #56014, this has caused a layout bug, since invisiblePopover was still taking up some space
This was resolved by adjusting it's vertical position using top: -999 so it's outside the viewable area

},

containerWithSpaceBetween: {
justifyContent: 'space-between',
width: '100%',
Expand Down