Skip to content

[No QA] fixed quickly Commenting on PRs hit api limit #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 11 commits into from
May 17, 2021
Merged

[No QA] fixed quickly Commenting on PRs hit api limit #2769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0bd8340
fix: quickly Commenting on PRs hit api limit
parasharrajat May 10, 2021
18e80f0
rebuild GH actions
parasharrajat May 10, 2021
346858e
added throttlling
parasharrajat May 11, 2021
e329f76
Merge branch 'main' of github.com:Expensify/Expensify.cash into gh-ac…
parasharrajat May 11, 2021
08f317d
typo
parasharrajat May 11, 2021
bbb8a86
new: throttled octo default instance in GithubUtils
parasharrajat May 13, 2021
b1341ea
move Throttling to GithubUtils
parasharrajat May 13, 2021
f115490
updated all github actions to use new throttled Octokit
parasharrajat May 13, 2021
ed2f64b
Merge branch 'main' of github.com:Expensify/Expensify.cash into gh-ac…
parasharrajat May 16, 2021
8aeeef7
test refactor
parasharrajat May 16, 2021
a1ada55
refactor github actions Tests
parasharrajat May 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/actions/checkDeployBlockers/checkDeployBlockers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
const _ = require('underscore');
const core = require('@actions/core');
const github = require('@actions/github');
const {GITHUB_OWNER, EXPENSIFY_CASH_REPO} = require('../../libs/GithubUtils');
const GithubUtils = require('../../libs/GithubUtils');

const run = function () {
const octokit = github.getOctokit(core.getInput('GITHUB_TOKEN', {required: true}));
const issueNumber = Number(core.getInput('ISSUE_NUMBER', {required: true}));

console.log(`Fetching issue number ${issueNumber}`);

return octokit.issues.get({
owner: GITHUB_OWNER,
repo: EXPENSIFY_CASH_REPO,
return GithubUtils.octokit.issues.get({
owner: GithubUtils.GITHUB_OWNER,
repo: GithubUtils.EXPENSIFY_CASH_REPO,
issue_number: issueNumber,
})
.then(({data}) => {
Expand All @@ -26,9 +24,9 @@ const run = function () {
return;
}

return octokit.issues.listComments({
owner: GITHUB_OWNER,
repo: EXPENSIFY_CASH_REPO,
return GithubUtils.octokit.issues.listComments({
owner: GithubUtils.GITHUB_OWNER,
repo: GithubUtils.EXPENSIFY_CASH_REPO,
issue_number: issueNumber,
per_page: 100,
});
Expand Down
Loading