Refactor modal stack navigators#2765
Merged
Merged
Conversation
jasperhuangg
approved these changes
May 11, 2021
jasperhuangg
left a comment
Contributor
There was a problem hiding this comment.
suuuper clean, tested and works great, awesome stuff :)
36 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.41-9🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This is just a quick refactor of the modal stack navigators to cut down on some of the boilerplate needed to add a new modal stack.
Fixed Issues
No Issue
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android