[No QA][TS migration] Migrate 'IOUUtils.js' lib to TypeScript#27332
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
No testing for ts migration
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24835 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
fabioh8010
left a comment
There was a problem hiding this comment.
LGTM, CK still need to do the checklist.
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-19.at.17.56.11.movScreen.Recording.2023-09-19.at.17.56.48.movDesktopScreen.Recording.2023-09-19.at.17.57.14.movMobile Web - ChromeScreen.Recording.2023-09-19.at.17.58.05.movAndroidScreen.Recording.2023-09-19.at.17.59.43.movMobile Web - SafariScreen.Recording.2023-09-19.at.18.00.32.moviOSScreen.Recording.2023-09-19.at.18.01.05.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀
|
| } else { | ||
| iouReportUpdate.total += isDeleting ? amount : -amount; | ||
| } | ||
| if (iouReportUpdate.total) { |
Details
Migration of
IOUUtils.jsto Typescript.Fixed Issues
$ #24835
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
a-web.mov
Mobile Web - Safari
i-web.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov