Skip to content

[No QA] [TS Migration] Migrate 'focusWithDelay' lib to TypeScript #27321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcochavezf merged 6 commits into from
Sep 20, 2023
Merged

[No QA] [TS Migration] Migrate 'focusWithDelay' lib to TypeScript #27321

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
875d7e8
ref: migrate focusWithDelay into Typescript
kubabutkiewicz Sep 13, 2023
0c03dbb
fix: removed JSDoc params
kubabutkiewicz Sep 13, 2023
7cc0bb1
ref: extract return type
kubabutkiewicz Sep 13, 2023
a5c44fb
ref: resolve comment
kubabutkiewicz Sep 14, 2023
2894fc0
Merge branch 'main' into ts-migration/focus-with-delay-lib
kubabutkiewicz Sep 18, 2023
3789cc3
ref: resolve comment from review
kubabutkiewicz Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/libs/focusWithDelay.js → src/libs/focusWithDelay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import {InteractionManager} from 'react-native';
import {InteractionManager, TextInput} from 'react-native';
import ComposerFocusManager from './ComposerFocusManager';

type FocusWithDelay = (shouldDelay?: boolean) => void;
/**
* Create a function that focuses a text input.
* @param {Object} textInput the text input to focus
* @returns {Function} a function that focuses the text input with a configurable delay
*/
function focusWithDelay(textInput) {
function focusWithDelay(textInput: TextInput | null): FocusWithDelay {
/**
* Focus the text input
* @param {Boolean} [shouldDelay=false] Impose delay before focusing the text input
* @param [shouldDelay] Impose delay before focusing the text input
*/
return (shouldDelay = false) => {
// There could be other animations running while we trigger manual focus.
Expand All @@ -18,6 +17,7 @@ function focusWithDelay(textInput) {
if (!textInput) {
return;
}

if (!shouldDelay) {
textInput.focus();
return;
Expand Down