fix: 26178 Context menu does not close after user goes to the previous page by tienifr · Pull Request #27268 · Expensify/App

tienifr · 2023-09-12T16:09:07Z

Details

Fixed Issues

$ #26178
PROPOSAL: #26178 (comment)

Tests

Open a chat
Send a message
Reply in thread of the message sent
Hold on the last sent message inside the thread (Or we can open the emoji picker)
Click on the back button
Verify that the context menu closes after user goes back to the previous page

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Open a chat
Send a message
Reply in thread of the message sent
Hold on the last sent message inside the thread (Or we can open the emoji picker)
Click on the back button
Verify that the context menu closes after user goes back to the previous page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-12.at.22.46.51.mov

Mobile Web - Chrome

Screenrecorder-2023-09-12-22-52-51-947.mp4

Mobile Web - Safari

Screen.Recording.2023-09-12.at.22.53.30.mov

Desktop

Screen.Recording.2023-09-12.at.23.04.39.mov

iOS

Screen.Recording.2023-09-12.at.23.13.13.mov

Android

Screen.Recording.2023-09-12.at.23.13.13.mov

…s page

melvin-bot · 2023-09-12T16:15:20Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif

Missing case:

Screen.Recording.2023-09-13.at.9.31.41.PM.mov

tienifr · 2023-09-14T05:24:21Z

@aimane-chnaif Thanks for pointing that out, I think reactionListPopover belongs to ReportActionsView, that why we can't use it in NavigationRoot, so I handle hide popover in ReportActionsView

aimane-chnaif · 2023-09-14T16:07:43Z

 const MemoizedReportActionsView = React.memo(ReportActionsView, arePropsEqual);

-export default compose(Performance.withRenderTrace({id: '<ReportActionsView> rendering'}), withWindowDimensions, withLocalize, withNetwork())(MemoizedReportActionsView);
+export default compose(Performance.withRenderTrace({id: '<ReportActionsView> rendering'}), withNavigationFocus, withWindowDimensions, withLocalize, withNetwork())(MemoizedReportActionsView);


There's already useIsFocused hook.

tienifr · 2023-09-15T03:31:44Z

@aimane-chnaif Thanks for pointing that out. I updated the PR

aimane-chnaif · 2023-09-15T03:32:43Z

please pull main

aimane-chnaif · 2023-09-15T05:36:32Z

    }, [props.report, didSubscribeToReportTypingEvents, reportID]);

+    useEffect(() => {
+        if (!isFocused && context.reactionListRef && context.reactionListRef.current) {


I don't quite understand this condition.
You meant if (isFocused || !context.reactionListRef || !context.reactionListRef.current)?

Also, make sure to re-test after your latest change.

@tienifr bump

@aimane-chnaif sorry for the delay. I want to hide the emoji popover when we switch to other chat, that means the current chat will be hidden -> isFocused is false.
We also need to make sure context.reactionListRef.current is defined before calling hideReactionList
I also tested this and there's no regression. Pls let me know if it's unclear

This is early return condition. It should be fully reversed

ah sorry @aimane-chnaif, I faced with the lint error about early return, so I accidentally moved context.reactionListRef.current.hideReactionList(); outside if block. Will update soon.

tienifr · 2023-09-15T16:00:15Z

@aimane-chnaif updated. Can you help review again? Thanks

aimane-chnaif · 2023-09-15T16:00:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

LGTM 🎉

tienifr · 2023-09-19T02:56:24Z

@youssef-lr Can you help take a look at this? Thanks

OSBotify · 2023-09-19T07:58:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-20T08:45:03Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:26:58Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits September 12, 2023 23:02

fix: 26178 Context menu does not close after user goes to the previou…

8fc67b5

…s page

fix lint

7b841ff

tienifr marked this pull request as ready for review September 12, 2023 16:15

tienifr requested a review from a team as a code owner September 12, 2023 16:15

melvin-bot Bot requested review from aimane-chnaif and removed request for a team September 12, 2023 16:15

aimane-chnaif reviewed Sep 13, 2023

View reviewed changes

tienifr added 2 commits September 14, 2023 11:28

Merge branch 'main' into fix/26178

9b74062

fix: hide emoji modal

011a2a7

aimane-chnaif reviewed Sep 14, 2023

View reviewed changes

remove HOC

933b72b

aimane-chnaif reviewed Sep 15, 2023

View reviewed changes

fix early return condition

e3c8200

aimane-chnaif approved these changes Sep 15, 2023

View reviewed changes

melvin-bot Bot requested a review from youssef-lr September 15, 2023 16:01

youssef-lr approved these changes Sep 19, 2023

View reviewed changes

youssef-lr merged commit 436b75d into Expensify:main Sep 19, 2023

Pujan92 mentioned this pull request Sep 19, 2023

[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Dev: Web - App crashing on creating new workspace #27782

Closed

6 tasks

aimane-chnaif mentioned this pull request Sep 19, 2023

[CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798

Merged

59 tasks

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

melvin-bot Bot mentioned this pull request Sep 22, 2023

[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page #26178

Closed

6 tasks

Uh oh!

Conversation

tienifr commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 12, 2023

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Sep 14, 2023

Uh oh!

aimane-chnaif Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr commented Sep 15, 2023

Uh oh!

aimane-chnaif commented Sep 15, 2023

Uh oh!

aimane-chnaif Sep 15, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Sep 15, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Sep 15, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Sep 15, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr commented Sep 15, 2023

Uh oh!

aimane-chnaif commented Sep 15, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Sep 19, 2023

Uh oh!

OSBotify commented Sep 19, 2023

Uh oh!

OSBotify commented Sep 20, 2023

Uh oh!

OSBotify commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Sep 12, 2023 •

edited

Loading

tienifr Sep 15, 2023 •

edited

Loading