Skip to content

Fix: Leaving thread navigates to Concierge page #27127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 11 commits into from
Sep 20, 2023
Merged

Fix: Leaving thread navigates to Concierge page #27127

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c418112
fix: leave thread navigates to concierge
tienifr Sep 11, 2023
cf3bc06
dismiss modal
tienifr Sep 11, 2023
61ed38f
navigate to concierge for rooms
tienifr Sep 12, 2023
5c81ddb
Merge branch 'main' of https://github.com/tienifr/App into fix/26250
tienifr Sep 12, 2023
1164b34
navigate back to lhn
tienifr Sep 12, 2023
30e7690
fix: cannot edit money request transaction in offline
tienifr Sep 12, 2023
486e1a3
Revert "fix: cannot edit money request transaction in offline"
tienifr Sep 12, 2023
11881cd
Merge branch 'main' of https://github.com/tienifr/App into fix/26250
tienifr Sep 15, 2023
41fd438
Merge branch 'main' of https://github.com/tienifr/App into fix/26250
tienifr Sep 15, 2023
8a111c4
Merge branch 'main' of https://github.com/tienifr/App into fix/26250
tienifr Sep 18, 2023
319365f
Merge branch 'main' of https://github.com/tienifr/App into fix/26250
tienifr Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,6 +1822,10 @@ function leaveRoom(reportID) {
if (Navigation.getTopmostReportId() === reportID) {
Navigation.goBack();
}
if (report.parentReportID) {
Navigation.navigate(ROUTES.getReportRoute(report.parentReportID), CONST.NAVIGATION.TYPE.FORCED_UP);

@eVoloshchak eVoloshchak Oct 19, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from #28087
CONST.NAVIGATION.TYPE.FORCED_UP has caused an edge case on web, where if you reply in a thread, refresh the page and select 'Leave the thread', LHN disappears from the screen

return;
}
navigateToConciergeChat();
}

Expand Down