Skip to content

[NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks"#25963

Merged
thienlnam merged 1 commit into
mainfrom
revert-25866-react-navigation-native-fix
Aug 25, 2023
Merged

[NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks"#25963
thienlnam merged 1 commit into
mainfrom
revert-25866-react-navigation-native-fix

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Straight revert of #25866

@mountiny mountiny requested a review from a team as a code owner August 25, 2023 17:59
@melvin-bot melvin-bot Bot requested review from srikarparsi and removed request for a team August 25, 2023 17:59
@melvin-bot

melvin-bot Bot commented Aug 25, 2023

Copy link
Copy Markdown

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Fixing the race condition on history.go due to buggy queue async callbacks" [NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks" Aug 25, 2023
@thienlnam thienlnam merged commit 8fcfb4f into main Aug 25, 2023
@thienlnam thienlnam deleted the revert-25866-react-navigation-native-fix branch August 25, 2023 18:06
@melvin-bot melvin-bot Bot added the Emergency label Aug 25, 2023
@melvin-bot

melvin-bot Bot commented Aug 25, 2023

Copy link
Copy Markdown

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@thienlnam

Copy link
Copy Markdown
Contributor

Merged without passing checklists since this is a straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.58-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.59-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants