Fix multiple metro versions by janicduplessis · Pull Request #25912 · Expensify/App

janicduplessis · 2023-08-25T01:40:40Z

Details

I noticed the repo contains multiple versions of metro

❯ npm list metro
new.expensify@1.3.56-22 /Users/janicduplessis/Developer/Expensify-App
├─┬ @react-native/metro-config@0.72.9
│ └─┬ metro-config@0.76.7
│   └─┬ metro@0.76.7
│     └─┬ metro-transform-worker@0.76.7
│       └── metro@0.76.7 deduped
├─┬ metro-config@0.71.3
│ └─┬ metro@0.71.3
│   └─┬ metro-transform-worker@0.71.3
│     └── metro@0.71.3 deduped
└─┬ react-native@0.72.3
  └─┬ @react-native-community/cli@11.3.5
    └─┬ @react-native-community/cli-plugin-metro@11.3.5
      ├─┬ metro-config@0.76.7
      │ └── metro@0.76.7 deduped
      └─┬ metro@0.76.7
        └─┬ metro-transform-worker@0.76.7
          └── metro@0.76.7 deduped

To fix this I removed the old version of metro-config in package.json (we should not need to specify a version of it since it will be a transitive dependency. Then I ran npm dedupe (https://docs.npmjs.com/cli/v8/commands/npm-dedupe) which reorganize node_modules to reduce duplication of packages. After this you can see there is only one copy of metro left. This will also help with other deps that might have been duplicated for no reason.

❯ npm list metro
new.expensify@1.3.56-22 /Users/janicduplessis/Developer/Expensify-App
├─┬ @react-native/metro-config@0.72.9
│ └─┬ metro-config@0.76.7
│   └─┬ metro@0.76.7
│     └─┬ metro-transform-worker@0.76.7
│       └── metro@0.76.7 deduped
└─┬ react-native@0.72.3
  └─┬ @react-native-community/cli@11.3.5
    └─┬ @react-native-community/cli-plugin-metro@11.3.5
      └── metro@0.76.7 deduped

This also caused some new lint errors to appear, probably because a newer version of eslint plugins is now being picked up.

/Users/janicduplessis/Developer/Expensify-App/src/components/SignInButtons/GoogleSignIn/index.website.js
  75:17  error  Unknown property 'accessibilityrole' found   react/no-unknown-property
  76:17  error  Unknown property 'accessibilitylabel' found  react/no-unknown-property
  83:17  error  Unknown property 'accessibilityrole' found   react/no-unknown-property
  84:17  error  Unknown property 'accessibilitylabel' found  react/no-unknown-property

/Users/janicduplessis/Developer/Expensify-App/src/components/Tooltip/TooltipRend
eredOnPageBody.js
  62:35  error  Function component is not a function declaration  react/function-component-definition

/Users/janicduplessis/Developer/Expensify-App/src/components/Tooltip/index.native.js
  14:17  error  Function component is not a function declaration  react/function-component-definition

/Users/janicduplessis/Developer/Expensify-App/src/components/UserDetailsTooltip/index.js
  12:28  error  Function component is not a function declaration  react/function-component-definition

The react/function-component-definition is trivial to fix, the react/no-unknown-property seems to surface an actual issue. Props accessibilityrole and accessibilitylabel do not exist on div, those look like RN view props, which should map to role and aria-label on web.

Fixed Issues

$
PROPOSAL: N/A

Tests

Verified that only one copy of metro exists and is the correct version for RN 0.72. Tested that app runs fine on all platforms.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-08-25T01:41:15Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hannojg · 2023-08-25T15:14:36Z

Janic you're the og

MariaHCD · 2023-08-28T12:10:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-28.at.4.08.07.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-28.at.4.56.04.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-28.at.4.33.44.PM.mov

Desktop

Screen.Recording.2023-08-28.at.4.08.57.PM.mov

iOS

Screen.Recording.2023-08-28.at.4.31.54.PM.mov

Android

Screen.Recording.2023-08-28.at.4.58.53.PM.mov

OSBotify · 2023-08-28T13:18:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shubham1206agra · 2023-08-28T18:41:23Z

@janicduplessis I am getting this error

transform[stderr]: Error: Cannot find module '/Users/prachiagrawal/code/App/node_modules/@react-native-community/cli-plugin-metro/node_modules/jest-worker/build/workers/processChild.js'
transform[stderr]:     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
transform[stderr]:     at Function.Module._load (node:internal/modules/cjs/loader:778:27)
transform[stderr]:     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
transform[stderr]:     at node:internal/main/run_main_module:17:47 {
transform[stderr]:   code: 'MODULE_NOT_FOUND',
transform[stderr]:   requireStack: []
transform[stderr]: }
transform[stderr]: node:internal/modules/cjs/loader:936
transform[stderr]:   throw err;
transform[stderr]:   ^

I suspect it's coming from this PR. Can ou help me with this?

OSBotify · 2023-08-28T18:48:02Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

janicduplessis · 2023-08-28T19:27:53Z

Can you try to delete and reinstall node_modules

OSBotify · 2023-08-30T01:17:05Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:55:24Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:55:42Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix metro version

cd96339

janicduplessis requested a review from a team as a code owner August 25, 2023 01:40

melvin-bot Bot removed the request for review from a team August 25, 2023 01:41

melvin-bot Bot requested a review from MariaHCD August 25, 2023 01:41

Fix lint

f486f77

janicduplessis changed the title ~~Fix metro version~~ Fix duplicate metro version Aug 25, 2023

janicduplessis changed the title ~~Fix duplicate metro version~~ Fix multiple metro versions Aug 25, 2023

MariaHCD approved these changes Aug 28, 2023

View reviewed changes

MariaHCD merged commit fd64023 into Expensify:main Aug 28, 2023

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

janicduplessis deleted the @janic/fix-metro branch August 30, 2023 01:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix multiple metro versions#25912

Fix multiple metro versions#25912
MariaHCD merged 2 commits into
Expensify:mainfrom
janicduplessis:@janic/fix-metro

janicduplessis commented Aug 25, 2023 •

edited

Loading

Uh oh!

melvin-bot Bot commented Aug 25, 2023

Uh oh!

hannojg commented Aug 25, 2023 •

edited

Loading

Uh oh!

MariaHCD commented Aug 28, 2023 •

edited

Loading

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

shubham1206agra commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

janicduplessis commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

janicduplessis commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 25, 2023

Uh oh!

hannojg commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariaHCD commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

shubham1206agra commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

janicduplessis commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

janicduplessis commented Aug 25, 2023 •

edited

Loading

hannojg commented Aug 25, 2023 •

edited

Loading

MariaHCD commented Aug 28, 2023 •

edited

Loading