Skip to content

[No QA] [TS migration] Migrate 'visibility' style to TypeScript #25828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techievivek merged 2 commits into from
Aug 28, 2023
Merged

[No QA] [TS migration] Migrate 'visibility' style to TypeScript #25828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b8ce2
Migrate visibility to TS
fabioh8010 Aug 23, 2023
8a937a2
Fix types
fabioh8010 Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,14 +638,14 @@ const styles = {
},

visuallyHidden: {
...visibility('hidden'),
...visibility.hidden,
overflow: 'hidden',
width: 0,
height: 0,
},

visibilityHidden: {
...visibility('hidden'),
...visibility.hidden,
Comment thread
fabioh8010 marked this conversation as resolved.
},

loadingVBAAnimation: {
Expand Down Expand Up @@ -3047,7 +3047,7 @@ const styles = {
left: '50%',
top: 0,
zIndex: 100,
...visibility('hidden'),
...visibility.hidden,
},

floatingMessageCounterWrapperAndroid: {
Expand All @@ -3057,7 +3057,7 @@ const styles = {
position: 'absolute',
top: 0,
zIndex: 100,
...visibility('hidden'),
...visibility.hidden,
},

floatingMessageCounterSubWrapperAndroid: {
Expand All @@ -3067,7 +3067,7 @@ const styles = {

floatingMessageCounter: {
left: '-50%',
...visibility('visible'),
...visibility.visible,
},

floatingMessageCounterTransformation: (translateY) => ({
Expand Down
1 change: 0 additions & 1 deletion src/styles/utilities/visibility/index.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/styles/utilities/visibility/index.native.js
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions src/styles/utilities/visibility/index.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import VisibilityStyles from './types';

const visibility: VisibilityStyles = {
visible: {},
hidden: {},
};

export default visibility;
12 changes: 12 additions & 0 deletions src/styles/utilities/visibility/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import VisibilityStyles from './types';

const visibility: VisibilityStyles = {
visible: {
visibility: 'visible',
},
hidden: {
visibility: 'hidden',
},
};

export default visibility;
5 changes: 5 additions & 0 deletions src/styles/utilities/visibility/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import {CSSProperties} from 'react';

type VisibilityStyles = Record<'visible' | 'hidden', Partial<Pick<CSSProperties, 'visibility'>>>;

export default VisibilityStyles;