Mention list doesnt automatically popup when typing @ by WikusKriek · Pull Request #25660 · Expensify/App

WikusKriek · 2023-08-22T08:42:36Z

Details

Suggestion list will display when opening chat and typing @ on all platforms except iOS native.

Fixed Issues

$ #25649
PROPOSAL:

Tests

Open app
Navigate to group chat
Tap on the compose box
Type "@"
Verify that the suggestion list displays

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Test Steps

PR Author Checklist

Screenshots/Videos

Web

Web.2023-08-13.at.17.53.34.mov

Screen.Recording.2023-08-23.at.14.23.49.mov

Mobile Web - Chrome

Android.chrome.2023-08-13.at.17.51.57.mov

Mobile Web - Safari

IOS.safari.2023-08-13.at.16.41.03.mov

Screen.Recording.2023-08-23.at.14.54.50.mov

Desktop

Desktop.2023-08-13.at.17.55.39.mov

iOS

Screen.Recording.2023-08-22.at.13.03.53.mov

Screen.Recording.2023-08-23.at.14.45.23.mov

Android

Android.native.2023-08-13.at.17.46.09.mov

melvin-bot · 2023-08-22T08:43:09Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

techievivek · 2023-08-22T09:24:47Z

@WikusKriek Does this fix the native ios as well?

WikusKriek · 2023-08-22T11:07:37Z

@techievivek this is ready.

WikusKriek · 2023-08-22T13:14:16Z

Actually found that waiting for selection to update in state and then calling calculateMentionSuggestion fixes the issue on all platforms.

const onSelectionChange = (e) => {
        LayoutAnimation.configureNext(LayoutAnimation.create(50, LayoutAnimation.Types.easeInEaseOut, LayoutAnimation.Properties.opacity));
        setSelection(e.nativeEvent.selection);

        /**
         * we pass here e.nativeEvent.selection.end directly to calculateEmojiSuggestion
         * because in other case calculateEmojiSuggestion will have an old calculation value
         * of suggestion instead of current one
         */
    };

    useEffect(() => {
        calculateEmojiSuggestion(selection.end);
        calculateMentionSuggestion(selection.end);
    }, [calculateEmojiSuggestion, calculateMentionSuggestion, selection.end]);
    ```

techievivek · 2023-08-23T12:02:09Z

@WikusKriek Sorry for the delay in reviews, only web/desktop seems to be working for me, I am unable to build on ios/android.(something is messed up on my end).

Actually found that waiting for selection to update in state and then calling calculateMentionSuggestion fixes the issue on all platforms.

Do you think you can push that change in this PR?

WikusKriek · 2023-08-23T12:08:59Z

@WikusKriek Sorry for the delay in reviews, only web/desktop seems to be working for me, I am unable to build on ios/android.(something is messed up on my end).

Actually found that waiting for selection to update in state and then calling calculateMentionSuggestion fixes the issue on all platforms.

Do you think you can push that change in this PR?

No worries I also had quite a battle with android builds the past few days. I can push that change yes.

WikusKriek · 2023-08-23T12:59:42Z

@techievivek I applied the new changes, am busy uploading new screen recordings. Still have android left.
But this is ready for review.

…p-when-typing

techievivek · 2023-08-23T16:51:29Z

@WikusKriek Did you fix the issue with native ios? I can't see that in the screen recording.

techievivek · 2023-08-23T16:51:44Z

Going to pass this to a C+ so they can move this forward.

situchan · 2023-08-23T16:59:02Z

+    const onSelectionChange = (e) => {
+        LayoutAnimation.configureNext(LayoutAnimation.create(50, LayoutAnimation.Types.easeInEaseOut, LayoutAnimation.Properties.opacity));
+        setSelection(e.nativeEvent.selection);
+    };


useCallback can still be used with empty dependency array

bump for this minor change

Done @situchan.

situchan · 2023-08-23T17:49:56Z

@WikusKriek Did you fix the issue with native ios? I can't see that in the screen recording.

I confirmed fix on iOS as well

situchan · 2023-08-23T18:05:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

LGTM

OSBotify · 2023-08-24T06:54:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-28T18:51:17Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:20:20Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:58:54Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:59:12Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: sellection end check

b93d8e9

WikusKriek requested a review from a team as a code owner August 22, 2023 08:42

melvin-bot Bot removed the request for review from a team August 22, 2023 08:43

melvin-bot Bot requested a review from arosiclair August 22, 2023 08:43

fix: remove sellection dependency

434923a

WikusKriek mentioned this pull request Aug 22, 2023

[HOLD for payment 2023-09-27] [HOLD for payment 2023-09-06] [$1000] Mention list doesnt automatically popup when typing @ #25649

Closed

6 tasks

sakluger mentioned this pull request Aug 22, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

arosiclair requested review from techievivek and removed request for arosiclair August 22, 2023 21:42

WikusKriek added 2 commits August 23, 2023 14:47

fix: iOS suggestion not showing

c680833

chore: remove comment

b569af6

Merge branch 'main' into 25649-Mention-list-doesnt-automatically-popu…

13fac95

…p-when-typing

techievivek requested a review from situchan August 23, 2023 16:57

situchan reviewed Aug 23, 2023

View reviewed changes

fix: insert caallback

d4e4d85

situchan approved these changes Aug 23, 2023

View reviewed changes

Beamanator approved these changes Aug 24, 2023

View reviewed changes

Beamanator merged commit 9a6c643 into Expensify:main Aug 24, 2023

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

Conversation

WikusKriek commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 22, 2023

Uh oh!

techievivek commented Aug 22, 2023

Uh oh!

WikusKriek commented Aug 22, 2023

Uh oh!

WikusKriek commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techievivek commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WikusKriek commented Aug 23, 2023

Uh oh!

WikusKriek commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techievivek commented Aug 23, 2023

Uh oh!

techievivek commented Aug 23, 2023

Uh oh!

situchan Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

situchan Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

WikusKriek Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

situchan commented Aug 23, 2023

Uh oh!

situchan commented Aug 23, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WikusKriek commented Aug 22, 2023 •

edited

Loading

WikusKriek commented Aug 22, 2023 •

edited

Loading

techievivek commented Aug 23, 2023 •

edited

Loading

WikusKriek commented Aug 23, 2023 •

edited

Loading