[No QA] Allow mapbox token to stop listening to all listeners and add a network listener by tgolen · Pull Request #25408 · Expensify/App

tgolen · 2023-08-17T14:53:28Z

Details

This PR adds the ability to stop all the listeners for the mapbox token and let's the token expire naturally. This is used for when discount requests unmount.

It also adds a listener for the network connection so that if the token has expired, it will fetch a new one.

Fixed Issues

$ #24612

Tests

Note: this can only be tested in web/desktop by an engineer that can modify the local code

USE THIS DIFF FOR TESTING

@@ -0,0 +1,44 @@
diff --git a/src/libs/Navigation/AppNavigator/AuthScreens.js b/src/libs/Navigation/AppNavigator/AuthScreens.js
index 439c1642cc..f58d4f9694 100644
--- a/src/libs/Navigation/AppNavigator/AuthScreens.js
+++ b/src/libs/Navigation/AppNavigator/AuthScreens.js
@@ -34,6 +34,7 @@ import FullScreenNavigator from './Navigators/FullScreenNavigator';
 import styles from '../../../styles/styles';
 import * as SessionUtils from '../../SessionUtils';
 import getNavigationModalCardStyle from '../../../styles/getNavigationModalCardStyles';
+import * as MapboxToken from '../../actions/MapboxToken';
 
 let timezone;
 let currentAccountID;
@@ -130,6 +131,9 @@ class AuthScreens extends React.Component {
             User.subscribeToUserEvents();
         });
 
+        MapboxToken.init();
+        // setTimeout(MapboxToken.stop, 2000);
+
         // If we are on this screen then we are "logged in", but the user might not have "just logged in". They could be reopening the app
         // or returning from background. If so, we'll assume they have some app data already and we can call reconnectApp() instead of openApp().
         // Note: If a Guide has enabled the memory only key mode then we do want to run OpenApp as their app will not be rehydrated with
diff --git a/src/libs/actions/MapboxToken.js b/src/libs/actions/MapboxToken.js
index 8859300478..573b75931a 100644
--- a/src/libs/actions/MapboxToken.js
+++ b/src/libs/actions/MapboxToken.js
@@ -21,7 +21,7 @@ let appStateSubscription;
 let currentToken;
 let refreshTimeoutID;
 let isCurrentlyFetchingToken = false;
-const REFRESH_INTERVAL = 1000 * 60 * 25;
+const REFRESH_INTERVAL = 1000;
 
 const setExpirationTimer = () => {
     console.debug('[MapboxToken] refreshing token on an interval', REFRESH_INTERVAL, 'ms');
@@ -118,7 +118,7 @@ const init = () => {
             callback: (val) => {
                 // When the network reconnects, check if the token has expired. If it has, then clearing the token will
                 // trigger the fetch of a new one
-                if (network && network.isOffline && val && !val.isOffline && !isCurrentlyFetchingToken && hasTokenExpired()) {
+                if (network && network.isOffline && val && !val.isOffline && !isCurrentlyFetchingToken) {
                     console.debug('[MapboxToken] Token is expired after network came online');
                     clearToken();
                 }

Modify REFRESH_INTERVAL to be 1000 only
Load the app
Open the JS console and filter for [MapboxToken]
Verify you see the token has initialized, been fetched once, then stopped
Now remove or comment out setTimeout(MapboxToken.stop, 2000); from AuthScreens.js
When the page refreshes, verify the token is refreshed every second
Go to Settings > Preferences and turn on Force offline
Verify in the JS console that the fetching of the token has stopped
Turn off Force offline
Verify in the JS console that the network reconnected, detected an expired token, and began fetching it again

Verify that no errors appear in the JS console

Offline tests

Included above

QA Steps

None

Verify that no errors appear in the JS console