[No QA] Ensure that no other updates are made to Onyx while missing Onyx updates are fetched and applied by tgolen · Pull Request #24607 · Expensify/App

tgolen · 2023-08-15T20:51:27Z

Details

This PR adds a mechanism to pause and unpause the sequential network queue. This is needed so that if the client is missing updates that the server has, then the missing updates are fetched and applied to Onyx, and then finally the sequential queue is unpaused.

This PR also removes the priorityRequest option now since it is not needed.

Fixed Issues

$ #24606

Tests

C+, please test that this version of the app still works as expected for the default actions (navigating, sending messages, etc etc)

This can only be tested by an internal employee on the RELIABLE_UPDATES beta

Sign into two different clients (web and any other platform) with two different accounts
User A on web, go to preferences and turn on force offline mode
User A, send a comment to User B
User A, go back to preferences (but don't do anything)
User A, switch to another tab to simulate background mode
User B on another platform, send two comments to User A
User B, delete the first comment
User A on web, go to NewDot tab
User A, turn off the force offline mode option
Verify that User A never sees the first comment from User B
Verify that both users see two comments (one from each user)

Verify that no errors appear in the JS console

Offline tests

Included in tests above

QA Steps

This won't be able to be QA'ed yet. We will be doing manual testing later this week.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Uploading 2023-08-15_14-40-27.mp4…

Mobile Web - Chrome

Note: This can only be tested with web and desktop for now

Mobile Web - Safari

Note: This can only be tested with web and desktop for now

Desktop

See video under the web section

iOS

Note: This can only be tested with web and desktop for now

Android

Note: This can only be tested with web and desktop for now

melvin-bot · 2023-08-15T21:00:59Z

@rushatgabhane @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

danieldoglas

LGTM

rushatgabhane · 2023-08-16T12:50:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

4510be94-90a4-4884-8a3f-de8183d7df71.mp4

Mobile Web - Chrome

WhatsApp.Video.2023-08-16.at.19.06.09.mp4

Mobile Web - Safari

Screen.Recording.2023-08-17.at.01.00.23.mov

Desktop

Screen.Recording.2023-08-17.at.01.05.00.mov

iOS

e3a95007-3800-4962-b289-69a3c955641a.mp4

Android

Screen.Recording.2023-08-17.at.01.00.54.mov

rushatgabhane

LGTM too

melvin-bot · 2023-08-16T19:38:07Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…tate

OSBotify · 2023-08-16T21:15:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:20:01Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:26:31Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:09:32Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

JmillsExpensify · 2023-10-05T20:41:39Z

Can I get a payment summary for @rushatgabhane from an Expensify employee?

danieldoglas · 2023-10-06T13:29:34Z

@JmillsExpensify this should be $1k for @rushatgabhane since it was created before the price change!

JmillsExpensify · 2023-10-07T15:22:55Z

$1,000 payment approved for @rushatgabhane based on comment above.

ntdiary · 2024-12-30T13:20:43Z

+    const numberOfPersistedRequests = PersistedRequests.getAll().length || 0;
+    console.debug(`[SequentialQueue] Unpausing the queue and flushing ${numberOfPersistedRequests} requests`);
+    isQueuePaused = false;
+    flush();


Coming from #52027, the flush resets the isReadyPromise, causing the pending get request to remain unresolved, we add a boolean parameter to ensure that unpause won't reset isReadyPromise. :)

tgolen added 5 commits August 15, 2023 13:58

Add skeleton methods for pausing/unpausing

d0d7bcb

Build out queue paused logic

e644798

Add some debugging

3b150bb

Return a promise when getting missing onyx updates

79646c3

Remove code for priority requests

9dbd78b

tgolen requested a review from danieldoglas August 15, 2023 20:51

tgolen self-assigned this Aug 15, 2023

tgolen marked this pull request as ready for review August 15, 2023 20:56

tgolen requested a review from a team as a code owner August 15, 2023 20:56

melvin-bot Bot requested review from rushatgabhane and removed request for a team August 15, 2023 21:00

danieldoglas reviewed Aug 15, 2023

View reviewed changes

Comment thread src/libs/actions/App.js Outdated

danieldoglas previously approved these changes Aug 16, 2023

View reviewed changes

danieldoglas requested review from allroundexperts and rushatgabhane and removed request for allroundexperts and rushatgabhane August 16, 2023 12:41

rushatgabhane approved these changes Aug 16, 2023

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify August 16, 2023 19:38

Change promise resolution so that queue can't get stuck in a paused s…

b7a862e

…tate

tgolen dismissed danieldoglas’s stale review via b7a862e August 16, 2023 20:37

danieldoglas approved these changes Aug 16, 2023

View reviewed changes

danieldoglas merged commit 85e34d6 into main Aug 16, 2023

danieldoglas deleted the tgolen-reorder-onyxupdates branch August 16, 2023 21:11

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot Bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-09-18] Incremental Onyx Updates are not applied in the correct order #24606

Closed

ntdiary reviewed Dec 30, 2024

View reviewed changes

Conversation

tgolen commented Aug 15, 2023 • edited by danieldoglas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 15, 2023

Uh oh!

Uh oh!

danieldoglas left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 16, 2023

Uh oh!

OSBotify commented Aug 16, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

JmillsExpensify commented Oct 5, 2023

Uh oh!

danieldoglas commented Oct 6, 2023

Uh oh!

JmillsExpensify commented Oct 7, 2023

Uh oh!

ntdiary Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tgolen commented Aug 15, 2023 •

edited by danieldoglas

Loading

rushatgabhane commented Aug 16, 2023 •

edited

Loading